[INFO] crate tight 0.1.3 is already in cache [INFO] extracting crate tight 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/tight/0.1.3 [INFO] extracting crate tight 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tight/0.1.3 [INFO] validating manifest of tight-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tight-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tight-0.1.3 [INFO] finished frobbing tight-0.1.3 [INFO] frobbed toml for tight-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/tight/0.1.3/Cargo.toml [INFO] started frobbing tight-0.1.3 [INFO] finished frobbing tight-0.1.3 [INFO] frobbed toml for tight-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tight/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tight-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tight/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c7379ae5acc7ec93df9804a67783e121b7a491b549c37142e7c1c3dcf3a595e [INFO] running `"docker" "start" "-a" "7c7379ae5acc7ec93df9804a67783e121b7a491b549c37142e7c1c3dcf3a595e"` [INFO] [stderr] Checking tight v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/validation.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / match re.is_match(arg.as_str()) { [INFO] [stderr] 19 | | true => Ok(()), [INFO] [stderr] 20 | | false => Err(String::from("Must be a number, and an optionally-plural version of day, week, month or year (e.g. \"2 days\")")) [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if re.is_match(arg.as_str()) { Ok(()) } else { Err(String::from("Must be a number, and an optionally-plural version of day, week, month or year (e.g. \"2 days\")")) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/validation.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match re.is_match(arg.as_str()) { [INFO] [stderr] 35 | | true => Ok(()), [INFO] [stderr] 36 | | false => Err(String::from("Must be a number, and an optionally-plural version of day, week, month or year (e.g. \"2 days\")")) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if re.is_match(arg.as_str()) { Ok(()) } else { Err(String::from("Must be a number, and an optionally-plural version of day, week, month or year (e.g. \"2 days\")")) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/validation.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / match re.is_match(arg.as_str()) { [INFO] [stderr] 19 | | true => Ok(()), [INFO] [stderr] 20 | | false => Err(String::from("Must be a number, and an optionally-plural version of day, week, month or year (e.g. \"2 days\")")) [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if re.is_match(arg.as_str()) { Ok(()) } else { Err(String::from("Must be a number, and an optionally-plural version of day, week, month or year (e.g. \"2 days\")")) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/validation.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match re.is_match(arg.as_str()) { [INFO] [stderr] 35 | | true => Ok(()), [INFO] [stderr] 36 | | false => Err(String::from("Must be a number, and an optionally-plural version of day, week, month or year (e.g. \"2 days\")")) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if re.is_match(arg.as_str()) { Ok(()) } else { Err(String::from("Must be a number, and an optionally-plural version of day, week, month or year (e.g. \"2 days\")")) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:550:46 [INFO] [stderr] | [INFO] [stderr] 550 | std::env::current_dir().unwrap_or(PathBuf::from(".")).display()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:679:8 [INFO] [stderr] | [INFO] [stderr] 679 | Ok(format!("{}", "status called")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"status called".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:550:46 [INFO] [stderr] | [INFO] [stderr] 550 | std::env::current_dir().unwrap_or(PathBuf::from(".")).display()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:679:8 [INFO] [stderr] | [INFO] [stderr] 679 | Ok(format!("{}", "status called")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"status called".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.93s [INFO] running `"docker" "inspect" "7c7379ae5acc7ec93df9804a67783e121b7a491b549c37142e7c1c3dcf3a595e"` [INFO] running `"docker" "rm" "-f" "7c7379ae5acc7ec93df9804a67783e121b7a491b549c37142e7c1c3dcf3a595e"` [INFO] [stdout] 7c7379ae5acc7ec93df9804a67783e121b7a491b549c37142e7c1c3dcf3a595e