[INFO] crate tiff-encoder 0.1.2 is already in cache [INFO] extracting crate tiff-encoder 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/tiff-encoder/0.1.2 [INFO] extracting crate tiff-encoder 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tiff-encoder/0.1.2 [INFO] validating manifest of tiff-encoder-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tiff-encoder-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tiff-encoder-0.1.2 [INFO] finished frobbing tiff-encoder-0.1.2 [INFO] frobbed toml for tiff-encoder-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/tiff-encoder/0.1.2/Cargo.toml [INFO] started frobbing tiff-encoder-0.1.2 [INFO] finished frobbing tiff-encoder-0.1.2 [INFO] frobbed toml for tiff-encoder-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tiff-encoder/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tiff-encoder-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tiff-encoder/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14fa162f02ef041a23d39f668c717a9976eaffd25aecb833a1c319740b79e173 [INFO] running `"docker" "start" "-a" "14fa162f02ef041a23d39f668c717a9976eaffd25aecb833a1c319740b79e173"` [INFO] [stderr] Checking tiff-encoder v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:351:13 [INFO] [stderr] | [INFO] [stderr] 351 | ifds: ifds, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ifds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:351:13 [INFO] [stderr] | [INFO] [stderr] 351 | ifds: ifds, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ifds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:47:52 [INFO] [stderr] | [INFO] [stderr] 47 | TiffTypeValues::new(values.into_iter().map(|value| BYTE(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BYTE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/tiff_type.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn from_str(s: &str) -> TiffTypeValues { [INFO] [stderr] 81 | | let mut values = Vec::with_capacity(s.chars().count()); [INFO] [stderr] 82 | | for c in s.chars() { [INFO] [stderr] 83 | | if c >= (128 as char) { [INFO] [stderr] ... | [INFO] [stderr] 88 | | Self::values(values) [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tiff_type.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:106:52 [INFO] [stderr] | [INFO] [stderr] 106 | TiffTypeValues::new(values.into_iter().map(|value| ASCII::new(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ASCII::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:138:52 [INFO] [stderr] | [INFO] [stderr] 138 | TiffTypeValues::new(values.into_iter().map(|value| SHORT(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SHORT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:168:52 [INFO] [stderr] | [INFO] [stderr] 168 | TiffTypeValues::new(values.into_iter().map(|value| LONG(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LONG` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:235:52 [INFO] [stderr] | [INFO] [stderr] 235 | TiffTypeValues::new(values.into_iter().map(|value| SBYTE(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SBYTE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:264:52 [INFO] [stderr] | [INFO] [stderr] 264 | TiffTypeValues::new(values.into_iter().map(|value| UNDEFINED(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `UNDEFINED` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:293:52 [INFO] [stderr] | [INFO] [stderr] 293 | TiffTypeValues::new(values.into_iter().map(|value| SSHORT(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SSHORT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:323:52 [INFO] [stderr] | [INFO] [stderr] 323 | TiffTypeValues::new(values.into_iter().map(|value| SLONG(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SLONG` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:390:52 [INFO] [stderr] | [INFO] [stderr] 390 | TiffTypeValues::new(values.into_iter().map(|value| FLOAT(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FLOAT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:420:52 [INFO] [stderr] | [INFO] [stderr] 420 | TiffTypeValues::new(values.into_iter().map(|value| DOUBLE(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DOUBLE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:87:11 [INFO] [stderr] | [INFO] [stderr] 87 | fn id(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:518:12 [INFO] [stderr] | [INFO] [stderr] 518 | if ifds.len() == 0 { panic!("Cannot create a chain without IFDs.") } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ifds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Ifd` [INFO] [stderr] --> src/lib.rs:599:5 [INFO] [stderr] | [INFO] [stderr] 599 | / pub fn new() -> Ifd { [INFO] [stderr] 600 | | Ifd { [INFO] [stderr] 601 | | entries: BTreeMap::new(), [INFO] [stderr] 602 | | } [INFO] [stderr] 603 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 585 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1075:30 [INFO] [stderr] | [INFO] [stderr] 1075 | let block_size = self.data.get(0).unwrap().size(); // Data has size of 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.data[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:1229:45 [INFO] [stderr] | [INFO] [stderr] 1229 | Offsets::new(blocks.into_iter().map(|block| ByteBlock(block)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ByteBlock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1264:12 [INFO] [stderr] | [INFO] [stderr] 1264 | if values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:47:52 [INFO] [stderr] | [INFO] [stderr] 47 | TiffTypeValues::new(values.into_iter().map(|value| BYTE(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BYTE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/tiff_type.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn from_str(s: &str) -> TiffTypeValues { [INFO] [stderr] 81 | | let mut values = Vec::with_capacity(s.chars().count()); [INFO] [stderr] 82 | | for c in s.chars() { [INFO] [stderr] 83 | | if c >= (128 as char) { [INFO] [stderr] ... | [INFO] [stderr] 88 | | Self::values(values) [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tiff_type.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:106:52 [INFO] [stderr] | [INFO] [stderr] 106 | TiffTypeValues::new(values.into_iter().map(|value| ASCII::new(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ASCII::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:138:52 [INFO] [stderr] | [INFO] [stderr] 138 | TiffTypeValues::new(values.into_iter().map(|value| SHORT(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SHORT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:168:52 [INFO] [stderr] | [INFO] [stderr] 168 | TiffTypeValues::new(values.into_iter().map(|value| LONG(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LONG` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:235:52 [INFO] [stderr] | [INFO] [stderr] 235 | TiffTypeValues::new(values.into_iter().map(|value| SBYTE(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SBYTE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:264:52 [INFO] [stderr] | [INFO] [stderr] 264 | TiffTypeValues::new(values.into_iter().map(|value| UNDEFINED(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `UNDEFINED` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:293:52 [INFO] [stderr] | [INFO] [stderr] 293 | TiffTypeValues::new(values.into_iter().map(|value| SSHORT(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SSHORT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:323:52 [INFO] [stderr] | [INFO] [stderr] 323 | TiffTypeValues::new(values.into_iter().map(|value| SLONG(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SLONG` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:390:52 [INFO] [stderr] | [INFO] [stderr] 390 | TiffTypeValues::new(values.into_iter().map(|value| FLOAT(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FLOAT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tiff_type.rs:420:52 [INFO] [stderr] | [INFO] [stderr] 420 | TiffTypeValues::new(values.into_iter().map(|value| DOUBLE(value)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DOUBLE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:87:11 [INFO] [stderr] | [INFO] [stderr] 87 | fn id(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:518:12 [INFO] [stderr] | [INFO] [stderr] 518 | if ifds.len() == 0 { panic!("Cannot create a chain without IFDs.") } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ifds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Ifd` [INFO] [stderr] --> src/lib.rs:599:5 [INFO] [stderr] | [INFO] [stderr] 599 | / pub fn new() -> Ifd { [INFO] [stderr] 600 | | Ifd { [INFO] [stderr] 601 | | entries: BTreeMap::new(), [INFO] [stderr] 602 | | } [INFO] [stderr] 603 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 585 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1075:30 [INFO] [stderr] | [INFO] [stderr] 1075 | let block_size = self.data.get(0).unwrap().size(); // Data has size of 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.data[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:1229:45 [INFO] [stderr] | [INFO] [stderr] 1229 | Offsets::new(blocks.into_iter().map(|block| ByteBlock(block)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ByteBlock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1264:12 [INFO] [stderr] | [INFO] [stderr] 1264 | if values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.05s [INFO] running `"docker" "inspect" "14fa162f02ef041a23d39f668c717a9976eaffd25aecb833a1c319740b79e173"` [INFO] running `"docker" "rm" "-f" "14fa162f02ef041a23d39f668c717a9976eaffd25aecb833a1c319740b79e173"` [INFO] [stdout] 14fa162f02ef041a23d39f668c717a9976eaffd25aecb833a1c319740b79e173