[INFO] crate tidalcache 0.1.0 is already in cache [INFO] extracting crate tidalcache 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/tidalcache/0.1.0 [INFO] extracting crate tidalcache 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tidalcache/0.1.0 [INFO] validating manifest of tidalcache-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tidalcache-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tidalcache-0.1.0 [INFO] finished frobbing tidalcache-0.1.0 [INFO] frobbed toml for tidalcache-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/tidalcache/0.1.0/Cargo.toml [INFO] started frobbing tidalcache-0.1.0 [INFO] finished frobbing tidalcache-0.1.0 [INFO] frobbed toml for tidalcache-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tidalcache/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tidalcache-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tidalcache/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0083d49e69cb9afbe23a941b8722b80739b1d95d667d7723e064180739a2fd7 [INFO] running `"docker" "start" "-a" "b0083d49e69cb9afbe23a941b8722b80739b1d95d667d7723e064180739a2fd7"` [INFO] [stderr] Checking tidalcache v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | url: url [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | url: url [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/lib.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | use serde_json::{Value, Error}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/lib.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | use serde_json::{Value, Error}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:116:4 [INFO] [stderr] | [INFO] [stderr] 116 | match rb.send() { [INFO] [stderr] | _____________^ [INFO] [stderr] 117 | | Ok(mut response) => { [INFO] [stderr] 118 | | match response.text() { [INFO] [stderr] 119 | | Ok(text) => { [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | if let Ok(mut response) = rb.send() { [INFO] [stderr] 117 | match response.text() { [INFO] [stderr] 118 | Ok(text) => { [INFO] [stderr] 119 | //println!("Text: {:?}", text); [INFO] [stderr] 120 | if let Ok(jr) = serde_json::from_str(&text) { [INFO] [stderr] 121 | result = Some(jr); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:118:6 [INFO] [stderr] | [INFO] [stderr] 118 | match response.text() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 119 | | Ok(text) => { [INFO] [stderr] 120 | | //println!("Text: {:?}", text); [INFO] [stderr] 121 | | if let Ok(jr) = serde_json::from_str(&text) { [INFO] [stderr] ... | [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Ok(text) = response.text() { [INFO] [stderr] 119 | //println!("Text: {:?}", text); [INFO] [stderr] 120 | if let Ok(jr) = serde_json::from_str(&text) { [INFO] [stderr] 121 | result = Some(jr); [INFO] [stderr] 122 | } [INFO] [stderr] 123 | //result = serde_json::from_str(&text); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:149:4 [INFO] [stderr] | [INFO] [stderr] 149 | match rb.send() { [INFO] [stderr] | _____________^ [INFO] [stderr] 150 | | Ok(mut response) => { [INFO] [stderr] 151 | | match response.text() { [INFO] [stderr] 152 | | Ok(text) => { [INFO] [stderr] ... | [INFO] [stderr] 163 | | } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 149 | if let Ok(mut response) = rb.send() { [INFO] [stderr] 150 | match response.text() { [INFO] [stderr] 151 | Ok(text) => { [INFO] [stderr] 152 | return Some(text); [INFO] [stderr] 153 | } [INFO] [stderr] 154 | Err(_) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:151:6 [INFO] [stderr] | [INFO] [stderr] 151 | match response.text() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 152 | | Ok(text) => { [INFO] [stderr] 153 | | return Some(text); [INFO] [stderr] 154 | | } [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 151 | if let Ok(text) = response.text() { [INFO] [stderr] 152 | return Some(text); [INFO] [stderr] 153 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:116:4 [INFO] [stderr] | [INFO] [stderr] 116 | match rb.send() { [INFO] [stderr] | _____________^ [INFO] [stderr] 117 | | Ok(mut response) => { [INFO] [stderr] 118 | | match response.text() { [INFO] [stderr] 119 | | Ok(text) => { [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | if let Ok(mut response) = rb.send() { [INFO] [stderr] 117 | match response.text() { [INFO] [stderr] 118 | Ok(text) => { [INFO] [stderr] 119 | //println!("Text: {:?}", text); [INFO] [stderr] 120 | if let Ok(jr) = serde_json::from_str(&text) { [INFO] [stderr] 121 | result = Some(jr); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:118:6 [INFO] [stderr] | [INFO] [stderr] 118 | match response.text() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 119 | | Ok(text) => { [INFO] [stderr] 120 | | //println!("Text: {:?}", text); [INFO] [stderr] 121 | | if let Ok(jr) = serde_json::from_str(&text) { [INFO] [stderr] ... | [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Ok(text) = response.text() { [INFO] [stderr] 119 | //println!("Text: {:?}", text); [INFO] [stderr] 120 | if let Ok(jr) = serde_json::from_str(&text) { [INFO] [stderr] 121 | result = Some(jr); [INFO] [stderr] 122 | } [INFO] [stderr] 123 | //result = serde_json::from_str(&text); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:149:4 [INFO] [stderr] | [INFO] [stderr] 149 | match rb.send() { [INFO] [stderr] | _____________^ [INFO] [stderr] 150 | | Ok(mut response) => { [INFO] [stderr] 151 | | match response.text() { [INFO] [stderr] 152 | | Ok(text) => { [INFO] [stderr] ... | [INFO] [stderr] 163 | | } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 149 | if let Ok(mut response) = rb.send() { [INFO] [stderr] 150 | match response.text() { [INFO] [stderr] 151 | Ok(text) => { [INFO] [stderr] 152 | return Some(text); [INFO] [stderr] 153 | } [INFO] [stderr] 154 | Err(_) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:151:6 [INFO] [stderr] | [INFO] [stderr] 151 | match response.text() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 152 | | Ok(text) => { [INFO] [stderr] 153 | | return Some(text); [INFO] [stderr] 154 | | } [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 151 | if let Ok(text) = response.text() { [INFO] [stderr] 152 | return Some(text); [INFO] [stderr] 153 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.69s [INFO] running `"docker" "inspect" "b0083d49e69cb9afbe23a941b8722b80739b1d95d667d7723e064180739a2fd7"` [INFO] running `"docker" "rm" "-f" "b0083d49e69cb9afbe23a941b8722b80739b1d95d667d7723e064180739a2fd7"` [INFO] [stdout] b0083d49e69cb9afbe23a941b8722b80739b1d95d667d7723e064180739a2fd7