[INFO] crate ticker 0.1.1 is already in cache [INFO] extracting crate ticker 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/ticker/0.1.1 [INFO] extracting crate ticker 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ticker/0.1.1 [INFO] validating manifest of ticker-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ticker-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ticker-0.1.1 [INFO] finished frobbing ticker-0.1.1 [INFO] frobbed toml for ticker-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/ticker/0.1.1/Cargo.toml [INFO] started frobbing ticker-0.1.1 [INFO] finished frobbing ticker-0.1.1 [INFO] frobbed toml for ticker-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ticker/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ticker-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ticker/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6430a3cd668bca57e43dd056502091dff37ff2e0033818b35fe16076d87aae24 [INFO] running `"docker" "start" "-a" "6430a3cd668bca57e43dd056502091dff37ff2e0033818b35fe16076d87aae24"` [INFO] [stderr] warning: unused manifest key: package.docs [INFO] [stderr] Checking ticker v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:50:42 [INFO] [stderr] | [INFO] [stderr] 50 | if let Err(_) = send.send(()) { [INFO] [stderr] | ___________________________________- ^^^^^^ [INFO] [stderr] 51 | | return; [INFO] [stderr] 52 | | } [INFO] [stderr] | |___________________________________- help: try this: `if send.send(()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | let _ = self.ticker.recv.recv().expect("ticker channel to live"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:50:42 [INFO] [stderr] | [INFO] [stderr] 50 | if let Err(_) = send.send(()) { [INFO] [stderr] | ___________________________________- ^^^^^^ [INFO] [stderr] 51 | | return; [INFO] [stderr] 52 | | } [INFO] [stderr] | |___________________________________- help: try this: `if send.send(()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | let _ = self.ticker.recv.recv().expect("ticker channel to live"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.65s [INFO] running `"docker" "inspect" "6430a3cd668bca57e43dd056502091dff37ff2e0033818b35fe16076d87aae24"` [INFO] running `"docker" "rm" "-f" "6430a3cd668bca57e43dd056502091dff37ff2e0033818b35fe16076d87aae24"` [INFO] [stdout] 6430a3cd668bca57e43dd056502091dff37ff2e0033818b35fe16076d87aae24