[INFO] crate tiberius 0.3.1 is already in cache [INFO] extracting crate tiberius 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/tiberius/0.3.1 [INFO] extracting crate tiberius 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tiberius/0.3.1 [INFO] validating manifest of tiberius-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tiberius-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tiberius-0.3.1 [INFO] finished frobbing tiberius-0.3.1 [INFO] frobbed toml for tiberius-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/tiberius/0.3.1/Cargo.toml [INFO] started frobbing tiberius-0.3.1 [INFO] finished frobbing tiberius-0.3.1 [INFO] frobbed toml for tiberius-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tiberius/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tiberius-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tiberius/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ba386031191aa201e7d2675185870c63072792e276eb7396569025a07a09e59 [INFO] running `"docker" "start" "-a" "5ba386031191aa201e7d2675185870c63072792e276eb7396569025a07a09e59"` [INFO] [stderr] Checking futures-state-stream v0.1.1 [INFO] [stderr] Checking winauth v0.0.3 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking tiberius v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport.rs:344:17 [INFO] [stderr] | [INFO] [stderr] 344 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport.rs:353:17 [INFO] [stderr] | [INFO] [stderr] 353 | packet_size: packet_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:581:13 [INFO] [stderr] | [INFO] [stderr] 581 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:583:13 [INFO] [stderr] | [INFO] [stderr] 583 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:262:21 [INFO] [stderr] | [INFO] [stderr] 262 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:333:13 [INFO] [stderr] | [INFO] [stderr] 333 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:366:49 [INFO] [stderr] | [INFO] [stderr] 366 | let token = Arc::new(TokenColMetaData { columns: columns }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | param_ordinal: param_ordinal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `param_ordinal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:550:13 [INFO] [stderr] | [INFO] [stderr] 550 | param_name: param_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `param_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:551:13 [INFO] [stderr] | [INFO] [stderr] 551 | udf: udf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:553:13 [INFO] [stderr] | [INFO] [stderr] 553 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | Statement { sql: sql } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sql` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport.rs:344:17 [INFO] [stderr] | [INFO] [stderr] 344 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport.rs:353:17 [INFO] [stderr] | [INFO] [stderr] 353 | packet_size: packet_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:581:13 [INFO] [stderr] | [INFO] [stderr] 581 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:583:13 [INFO] [stderr] | [INFO] [stderr] 583 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:262:21 [INFO] [stderr] | [INFO] [stderr] 262 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:333:13 [INFO] [stderr] | [INFO] [stderr] 333 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:366:49 [INFO] [stderr] | [INFO] [stderr] 366 | let token = Arc::new(TokenColMetaData { columns: columns }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | param_ordinal: param_ordinal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `param_ordinal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:550:13 [INFO] [stderr] | [INFO] [stderr] 550 | param_name: param_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `param_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:551:13 [INFO] [stderr] | [INFO] [stderr] 551 | udf: udf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:553:13 [INFO] [stderr] | [INFO] [stderr] 553 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | Statement { sql: sql } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sql` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/plp.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | (0xffffffffffffffff, ReadTyMode::Plp) => None, // NULL value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/plp.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | (0xfffffffffffffffe, ReadTyMode::Plp) => Some(Vec::new()), // unknown size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | SqlServerV7 = 0x70000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | SqlServer2000 = 0x71000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | SqlServer2000Sp1 = 0x71000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | SqlServer2005 = 0x72090002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7209_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | SqlServer2008 = 0x730A0003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x730A_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | SqlServer2008R2 = 0x730B0003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x730B_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | SqlServerN = 0x74000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7400_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:266:38 [INFO] [stderr] | [INFO] [stderr] 266 | const BIG_ENDIAN = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:268:38 [INFO] [stderr] | [INFO] [stderr] 268 | const CHARSET_EBDDIC = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:270:38 [INFO] [stderr] | [INFO] [stderr] 270 | const FLOAT_VAX = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:271:38 [INFO] [stderr] | [INFO] [stderr] 271 | const FLOAT_ND5000 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:272:38 [INFO] [stderr] | [INFO] [stderr] 272 | const DUMPLOAD_ON = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:276:38 [INFO] [stderr] | [INFO] [stderr] 276 | const USE_DB_NOTIFY = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:278:38 [INFO] [stderr] | [INFO] [stderr] 278 | const INITIAL_DB_FATAL = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:280:38 [INFO] [stderr] | [INFO] [stderr] 280 | const LANG_CHANGE_WARN = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:286:38 [INFO] [stderr] | [INFO] [stderr] 286 | const INIT_LANG_FATAL = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:291:38 [INFO] [stderr] | [INFO] [stderr] 291 | const ODBC_DRIVER = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:292:38 [INFO] [stderr] | [INFO] [stderr] 292 | const TRANS_BOUNDARY = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:293:38 [INFO] [stderr] | [INFO] [stderr] 293 | const CACHE_CONNECT = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:295:38 [INFO] [stderr] | [INFO] [stderr] 295 | const USER_TYPE_SERVER = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:297:38 [INFO] [stderr] | [INFO] [stderr] 297 | const USER_TYPE_REM_USER = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:299:38 [INFO] [stderr] | [INFO] [stderr] 299 | const USER_TYPE_SQL_REPL = 0b00110000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:300:38 [INFO] [stderr] | [INFO] [stderr] 300 | const INTEGRATED_SECURITY = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:306:38 [INFO] [stderr] | [INFO] [stderr] 306 | const SQL_TSQL = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:308:38 [INFO] [stderr] | [INFO] [stderr] 308 | const OLEDB_DRIVER = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:309:38 [INFO] [stderr] | [INFO] [stderr] 309 | const READ_ONLY_INTENT = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:314:38 [INFO] [stderr] | [INFO] [stderr] 314 | const REQUEST_CHANGE_PWD = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:316:38 [INFO] [stderr] | [INFO] [stderr] 316 | const SEND_YUKON_BINARY = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:318:38 [INFO] [stderr] | [INFO] [stderr] 318 | const SPAWN_USER_INSTANCE = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:321:38 [INFO] [stderr] | [INFO] [stderr] 321 | const SUPPORT_UNKNOWN_COLL = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/mod.rs:829:58 [INFO] [stderr] | [INFO] [stderr] 829 | assert_eq!(row.get::<_, f64>(0), 18446744073709554000000000000000f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_554_000_000_000_000_000f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/mod.rs:843:58 [INFO] [stderr] | [INFO] [stderr] 843 | assert_eq!(row.get::<_, f64>(1), 3333333f64); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_333_333f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/mod.rs:871:113 [INFO] [stderr] | [INFO] [stderr] 871 | assert_eq!(row.get::<_, Option<&str>>(0).map(|x| x.chars().filter(|x| *x == '4').count()), Some(127420)); [INFO] [stderr] | ^^^^^^ help: consider: `127_420` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:515:9 [INFO] [stderr] | [INFO] [stderr] 515 | return Ok(Async::Ready(SqlConnection(conn))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(SqlConnection(conn)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread': use tokio-current-thread crate or functions in tokio::runtime::current_thread instead [INFO] [stderr] --> src/collation.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | use tokio::executor::current_thread; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread': use tokio-current-thread crate or functions in tokio::runtime::current_thread instead [INFO] [stderr] --> src/types/time.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | use tokio::executor::current_thread; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread': use tokio-current-thread crate or functions in tokio::runtime::current_thread instead [INFO] [stderr] --> src/types/time.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | use tokio::executor::current_thread; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread': use tokio-current-thread crate or functions in tokio::runtime::current_thread instead [INFO] [stderr] --> src/types/mod.rs:750:9 [INFO] [stderr] | [INFO] [stderr] 750 | use tokio::executor::current_thread; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread': use tokio-current-thread crate or functions in tokio::runtime::current_thread instead [INFO] [stderr] --> src/lib.rs:1046:9 [INFO] [stderr] | [INFO] [stderr] 1046 | use tokio::executor::current_thread; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/plp.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | (0xffffffffffffffff, ReadTyMode::Plp) => None, // NULL value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/plp.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | (0xfffffffffffffffe, ReadTyMode::Plp) => Some(Vec::new()), // unknown size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | SqlServerV7 = 0x70000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | SqlServer2000 = 0x71000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | SqlServer2000Sp1 = 0x71000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | SqlServer2005 = 0x72090002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7209_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | SqlServer2008 = 0x730A0003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x730A_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | SqlServer2008R2 = 0x730B0003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x730B_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | SqlServerN = 0x74000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7400_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:266:38 [INFO] [stderr] | [INFO] [stderr] 266 | const BIG_ENDIAN = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:268:38 [INFO] [stderr] | [INFO] [stderr] 268 | const CHARSET_EBDDIC = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:270:38 [INFO] [stderr] | [INFO] [stderr] 270 | const FLOAT_VAX = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:271:38 [INFO] [stderr] | [INFO] [stderr] 271 | const FLOAT_ND5000 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:272:38 [INFO] [stderr] | [INFO] [stderr] 272 | const DUMPLOAD_ON = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:276:38 [INFO] [stderr] | [INFO] [stderr] 276 | const USE_DB_NOTIFY = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:278:38 [INFO] [stderr] | [INFO] [stderr] 278 | const INITIAL_DB_FATAL = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:280:38 [INFO] [stderr] | [INFO] [stderr] 280 | const LANG_CHANGE_WARN = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:286:38 [INFO] [stderr] | [INFO] [stderr] 286 | const INIT_LANG_FATAL = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:291:38 [INFO] [stderr] | [INFO] [stderr] 291 | const ODBC_DRIVER = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:292:38 [INFO] [stderr] | [INFO] [stderr] 292 | const TRANS_BOUNDARY = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:293:38 [INFO] [stderr] | [INFO] [stderr] 293 | const CACHE_CONNECT = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:295:38 [INFO] [stderr] | [INFO] [stderr] 295 | const USER_TYPE_SERVER = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:297:38 [INFO] [stderr] | [INFO] [stderr] 297 | const USER_TYPE_REM_USER = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:299:38 [INFO] [stderr] | [INFO] [stderr] 299 | const USER_TYPE_SQL_REPL = 0b00110000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:300:38 [INFO] [stderr] | [INFO] [stderr] 300 | const INTEGRATED_SECURITY = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:306:38 [INFO] [stderr] | [INFO] [stderr] 306 | const SQL_TSQL = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:308:38 [INFO] [stderr] | [INFO] [stderr] 308 | const OLEDB_DRIVER = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:309:38 [INFO] [stderr] | [INFO] [stderr] 309 | const READ_ONLY_INTENT = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:314:38 [INFO] [stderr] | [INFO] [stderr] 314 | const REQUEST_CHANGE_PWD = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:316:38 [INFO] [stderr] | [INFO] [stderr] 316 | const SEND_YUKON_BINARY = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:318:38 [INFO] [stderr] | [INFO] [stderr] 318 | const SPAWN_USER_INSTANCE = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol.rs:321:38 [INFO] [stderr] | [INFO] [stderr] 321 | const SUPPORT_UNKNOWN_COLL = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:515:9 [INFO] [stderr] | [INFO] [stderr] 515 | return Ok(Async::Ready(SqlConnection(conn))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(SqlConnection(conn)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/lib.rs:754:17 [INFO] [stderr] | [INFO] [stderr] 754 | / connect_params.auth = match connect_params.auth { [INFO] [stderr] 755 | | AuthMethod::SqlServer(ref mut username, _) | [INFO] [stderr] 756 | | AuthMethod::WinAuth(ref mut username, _) => { [INFO] [stderr] 757 | | *username = value.into_owned().into(); [INFO] [stderr] ... | [INFO] [stderr] 763 | | } [INFO] [stderr] 764 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/lib.rs:767:17 [INFO] [stderr] | [INFO] [stderr] 767 | / connect_params.auth = match connect_params.auth { [INFO] [stderr] 768 | | AuthMethod::SqlServer(_, ref mut password) | [INFO] [stderr] 769 | | AuthMethod::WinAuth(_, ref mut password) => { [INFO] [stderr] 770 | | *password = value.into_owned().into(); [INFO] [stderr] ... | [INFO] [stderr] 776 | | } [INFO] [stderr] 777 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/lib.rs:754:17 [INFO] [stderr] | [INFO] [stderr] 754 | / connect_params.auth = match connect_params.auth { [INFO] [stderr] 755 | | AuthMethod::SqlServer(ref mut username, _) | [INFO] [stderr] 756 | | AuthMethod::WinAuth(ref mut username, _) => { [INFO] [stderr] 757 | | *username = value.into_owned().into(); [INFO] [stderr] ... | [INFO] [stderr] 763 | | } [INFO] [stderr] 764 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/lib.rs:767:17 [INFO] [stderr] | [INFO] [stderr] 767 | / connect_params.auth = match connect_params.auth { [INFO] [stderr] 768 | | AuthMethod::SqlServer(_, ref mut password) | [INFO] [stderr] 769 | | AuthMethod::WinAuth(_, ref mut password) => { [INFO] [stderr] 770 | | *password = value.into_owned().into(); [INFO] [stderr] ... | [INFO] [stderr] 776 | | } [INFO] [stderr] 777 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `to_sec_fragments` [INFO] [stderr] --> src/types/time.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | fn to_sec_fragments(time: &NaiveTime) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/transport.rs:329:12 [INFO] [stderr] | [INFO] [stderr] 329 | Ok(writer.write_u8(size as u8)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 329 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/transport.rs:335:12 [INFO] [stderr] | [INFO] [stderr] 335 | Ok(writer.write_u16::(size as u16)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 335 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/plp.rs:53:45 [INFO] [stderr] | [INFO] [stderr] 53 | ReadTyMode::FixedSize(_) => input.read_u16::()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(input.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/protocol.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | .ok_or(Error::Protocol("header: invalid packet type".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Protocol("header: invalid packet type".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/protocol.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or(Error::Protocol("header: invalid packet status".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Protocol("header: invalid packet status".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/protocol.rs:236:33 [INFO] [stderr] | [INFO] [stderr] 236 | cursor.set_position(offset as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/protocol.rs:249:72 [INFO] [stderr] | [INFO] [stderr] 249 | ret.encryption = EncryptionLevel::from_u8(encrypt).ok_or(Error::Protocol( [INFO] [stderr] | ________________________________________________________________________^ [INFO] [stderr] 250 | | format!("invalid encryption value: {}", encrypt).into() [INFO] [stderr] 251 | | ))?; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 249 | ret.encryption = EncryptionLevel::from_u8(encrypt).ok_or_else(|| Error::Protocol( [INFO] [stderr] 250 | format!("invalid encryption value: {}", encrypt).into() [INFO] [stderr] 251 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/protocol.rs:438:36 [INFO] [stderr] | [INFO] [stderr] 438 | for (i, value) in var_data.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buffer`. [INFO] [stderr] --> src/protocol.rs:471:28 [INFO] [stderr] | [INFO] [stderr] 471 | for idx in data_offset..new_position { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 471 | for in buffer.iter_mut().take(new_position).skip(data_offset) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/protocol.rs:498:42 [INFO] [stderr] | [INFO] [stderr] 498 | cursor.write_u32::(header.length as u32 - HEADER_BYTES as u32)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/time.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn days(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:92:45 [INFO] [stderr] | [INFO] [stderr] 92 | self.increments as f64 / 10f64.powi(self.scale as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:93:49 [INFO] [stderr] | [INFO] [stderr] 93 | == t.increments as f64 / 10f64.powi(t.scale as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(t.scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `types::time::Time` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types/time.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | / impl Time { [INFO] [stderr] 98 | | #[inline] [INFO] [stderr] 99 | | pub fn len(&self) -> Result { [INFO] [stderr] 100 | | Ok(match self.scale { [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:135:27 [INFO] [stderr] | [INFO] [stderr] 135 | (0...2, 3) => rd.read_u16::()? as u64 | (rd.read_u8()? as u64) << 16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:135:67 [INFO] [stderr] | [INFO] [stderr] 135 | (0...2, 3) => rd.read_u16::()? as u64 | (rd.read_u8()? as u64) << 16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:136:27 [INFO] [stderr] | [INFO] [stderr] 136 | (3...4, 4) => rd.read_u32::()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | (5...7, 5) => rd.read_u32::()? as u64 | (rd.read_u8()? as u64) << 32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:137:67 [INFO] [stderr] | [INFO] [stderr] 137 | (5...7, 5) => rd.read_u32::()? as u64 | (rd.read_u8()? as u64) << 32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:199:51 [INFO] [stderr] | [INFO] [stderr] 199 | NaiveTime::from_num_seconds_from_midnight(sec_fragments as u32, 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(sec_fragments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/time.rs:203:22 [INFO] [stderr] | [INFO] [stderr] 203 | fn to_days(date: &NaiveDate, start_year: i32) -> i64 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/time.rs:210:31 [INFO] [stderr] | [INFO] [stderr] 210 | fn to_sec_fragments(time: &NaiveTime) -> i64 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveTime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | from_days(dt.days as i64, 1900), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(dt.days)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:223:27 [INFO] [stderr] | [INFO] [stderr] 223 | from_days(dt.days as i64, 1900), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(dt.days)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:224:36 [INFO] [stderr] | [INFO] [stderr] 224 | from_sec_fragments(dt.seconds_fragments as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dt.seconds_fragments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:227:27 [INFO] [stderr] | [INFO] [stderr] 227 | from_days(dt.0.days() as i64, 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dt.0.days())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:228:107 [INFO] [stderr] | [INFO] [stderr] 228 | NaiveTime::from_hms(0,0,0) + Duration::nanoseconds(dt.1.increments as i64 * 10i64.pow(9 - dt.1.scale as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(dt.1.scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:230:65 [INFO] [stderr] | [INFO] [stderr] 230 | NaiveDate: ColumnData::Date(ref date) => from_days(date.days() as i64, 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.days())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:238:25 [INFO] [stderr] | [INFO] [stderr] 238 | let nanos = time.num_seconds_from_midnight() as u64 * 1e9 as u64 + time.nanosecond() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(time.num_seconds_from_midnight())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:238:80 [INFO] [stderr] | [INFO] [stderr] 238 | let nanos = time.num_seconds_from_midnight() as u64 * 1e9 as u64 + time.nanosecond() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(time.nanosecond())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/mod.rs:405:34 [INFO] [stderr] | [INFO] [stderr] 405 | .ok_or(Error::Encoding("encoding: unspported encoding".into()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Encoding("encoding: unspported encoding".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:422:33 [INFO] [stderr] | [INFO] [stderr] 422 | trans.inner.read_i32::()? as f64 / 1e4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(trans.inner.read_i32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:425:44 [INFO] [stderr] | [INFO] [stderr] 425 | let high = trans.inner.read_i32::()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(trans.inner.read_i32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:426:43 [INFO] [stderr] | [INFO] [stderr] 426 | let low = trans.inner.read_u32::()? as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(trans.inner.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:501:39 [INFO] [stderr] | [INFO] [stderr] 501 | 12 => LittleEndian::read_u32(&buf[8..]) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(LittleEndian::read_u32(&buf[8..]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:521:34 [INFO] [stderr] | [INFO] [stderr] 521 | 5 => trans.inner.read_u32::()? as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(trans.inner.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:541:60 [INFO] [stderr] | [INFO] [stderr] 541 | ColumnData::F64(value / 10f64.powi(*scale as i32)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(*scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | .ok_or(Error::Protocol("loginack: invalid tds version".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Protocol("loginack: invalid tds version".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:267:18 [INFO] [stderr] | [INFO] [stderr] 267 | .ok_or(Error::Protocol("done(variant): invalid status".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Protocol("done(variant): invalid status".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/tokens.rs:277:41 [INFO] [stderr] | [INFO] [stderr] 277 | const CDF_NULLABLE = 1<<0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: item `query::QueryRow` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/query.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | / impl QueryRow { [INFO] [stderr] 283 | | /// Returns the amount of columns in the row [INFO] [stderr] 284 | | pub fn len(&self) -> usize { [INFO] [stderr] 285 | | self.0.columns.len() [INFO] [stderr] ... | [INFO] [stderr] 311 | | } [INFO] [stderr] 312 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/stmt.rs:181:30 [INFO] [stderr] | [INFO] [stderr] 181 | .or_insert(Vec::with_capacity(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Vec::with_capacity(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: function is never used: `to_sec_fragments` [INFO] [stderr] --> src/types/time.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | fn to_sec_fragments(time: &NaiveTime) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:410:95 [INFO] [stderr] | [INFO] [stderr] 410 | let (domain, username) = if let Some(idx) = username.find("\\") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:529:12 [INFO] [stderr] | [INFO] [stderr] 529 | stmts: FnvHashMap, i32, Option>)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ConnectParams` [INFO] [stderr] --> src/lib.rs:559:5 [INFO] [stderr] | [INFO] [stderr] 559 | / pub fn new() -> ConnectParams { [INFO] [stderr] 560 | | ConnectParams { [INFO] [stderr] 561 | | host: Cow::Borrowed(""), [INFO] [stderr] 562 | | ssl: if cfg!(feature = "tls") { [INFO] [stderr] ... | [INFO] [stderr] 571 | | } [INFO] [stderr] 572 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 557 | impl Default for ConnectParams { [INFO] [stderr] 558 | fn default() -> Self { [INFO] [stderr] 559 | Self::new() [INFO] [stderr] 560 | } [INFO] [stderr] 561 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:691:57 [INFO] [stderr] | [INFO] [stderr] 691 | } else if input.trim_left().starts_with(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:692:65 [INFO] [stderr] | [INFO] [stderr] 692 | input = input.trim_left().trim_left_matches(";"); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:729:75 [INFO] [stderr] | [INFO] [stderr] 729 | let addr = (parts[0], 1434).to_socket_addrs()?.nth(0).ok_or(Error::Conversion( [INFO] [stderr] | ___________________________________________________________________________^ [INFO] [stderr] 730 | | "connection string: could not resolve server address".into(), [INFO] [stderr] 731 | | ))?; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 729 | let addr = (parts[0], 1434).to_socket_addrs()?.nth(0).ok_or_else(|| Error::Conversion( [INFO] [stderr] 730 | "connection string: could not resolve server address".into(), [INFO] [stderr] 731 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:736:71 [INFO] [stderr] | [INFO] [stderr] 736 | let addr = (host, port).to_socket_addrs()?.nth(0).ok_or(Error::Conversion( [INFO] [stderr] | _______________________________________________________________________^ [INFO] [stderr] 737 | | "connection string: could not resolve server address".into(), [INFO] [stderr] 738 | | ))?; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 736 | let addr = (host, port).to_socket_addrs()?.nth(0).ok_or_else(|| Error::Conversion( [INFO] [stderr] 737 | "connection string: could not resolve server address".into(), [INFO] [stderr] 738 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:801:25 [INFO] [stderr] | [INFO] [stderr] 801 | let target = target.ok_or(Error::Conversion( [INFO] [stderr] | _________________________^ [INFO] [stderr] 802 | | "connection string pointing into the void. no connection endpoint specified.".into(), [INFO] [stderr] 803 | | ))?; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 801 | let target = target.ok_or_else(|| Error::Conversion( [INFO] [stderr] 802 | "connection string pointing into the void. no connection endpoint specified.".into(), [INFO] [stderr] 803 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/transport.rs:329:12 [INFO] [stderr] | [INFO] [stderr] 329 | Ok(writer.write_u8(size as u8)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 329 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/transport.rs:335:12 [INFO] [stderr] | [INFO] [stderr] 335 | Ok(writer.write_u16::(size as u16)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 335 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/plp.rs:53:45 [INFO] [stderr] | [INFO] [stderr] 53 | ReadTyMode::FixedSize(_) => input.read_u16::()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(input.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/protocol.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | .ok_or(Error::Protocol("header: invalid packet type".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Protocol("header: invalid packet type".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/protocol.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or(Error::Protocol("header: invalid packet status".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Protocol("header: invalid packet status".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: Could not compile `tiberius`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/protocol.rs:236:33 [INFO] [stderr] | [INFO] [stderr] 236 | cursor.set_position(offset as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/protocol.rs:249:72 [INFO] [stderr] | [INFO] [stderr] 249 | ret.encryption = EncryptionLevel::from_u8(encrypt).ok_or(Error::Protocol( [INFO] [stderr] | ________________________________________________________________________^ [INFO] [stderr] 250 | | format!("invalid encryption value: {}", encrypt).into() [INFO] [stderr] 251 | | ))?; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 249 | ret.encryption = EncryptionLevel::from_u8(encrypt).ok_or_else(|| Error::Protocol( [INFO] [stderr] 250 | format!("invalid encryption value: {}", encrypt).into() [INFO] [stderr] 251 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/protocol.rs:438:36 [INFO] [stderr] | [INFO] [stderr] 438 | for (i, value) in var_data.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buffer`. [INFO] [stderr] --> src/protocol.rs:471:28 [INFO] [stderr] | [INFO] [stderr] 471 | for idx in data_offset..new_position { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 471 | for in buffer.iter_mut().take(new_position).skip(data_offset) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/protocol.rs:498:42 [INFO] [stderr] | [INFO] [stderr] 498 | cursor.write_u32::(header.length as u32 - HEADER_BYTES as u32)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/time.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn days(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:92:45 [INFO] [stderr] | [INFO] [stderr] 92 | self.increments as f64 / 10f64.powi(self.scale as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:93:49 [INFO] [stderr] | [INFO] [stderr] 93 | == t.increments as f64 / 10f64.powi(t.scale as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(t.scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `types::time::Time` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types/time.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | / impl Time { [INFO] [stderr] 98 | | #[inline] [INFO] [stderr] 99 | | pub fn len(&self) -> Result { [INFO] [stderr] 100 | | Ok(match self.scale { [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:135:27 [INFO] [stderr] | [INFO] [stderr] 135 | (0...2, 3) => rd.read_u16::()? as u64 | (rd.read_u8()? as u64) << 16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:135:67 [INFO] [stderr] | [INFO] [stderr] 135 | (0...2, 3) => rd.read_u16::()? as u64 | (rd.read_u8()? as u64) << 16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:136:27 [INFO] [stderr] | [INFO] [stderr] 136 | (3...4, 4) => rd.read_u32::()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | (5...7, 5) => rd.read_u32::()? as u64 | (rd.read_u8()? as u64) << 32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:137:67 [INFO] [stderr] | [INFO] [stderr] 137 | (5...7, 5) => rd.read_u32::()? as u64 | (rd.read_u8()? as u64) << 32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rd.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:199:51 [INFO] [stderr] | [INFO] [stderr] 199 | NaiveTime::from_num_seconds_from_midnight(sec_fragments as u32, 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(sec_fragments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/time.rs:203:22 [INFO] [stderr] | [INFO] [stderr] 203 | fn to_days(date: &NaiveDate, start_year: i32) -> i64 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/time.rs:210:31 [INFO] [stderr] | [INFO] [stderr] 210 | fn to_sec_fragments(time: &NaiveTime) -> i64 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveTime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | from_days(dt.days as i64, 1900), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(dt.days)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:223:27 [INFO] [stderr] | [INFO] [stderr] 223 | from_days(dt.days as i64, 1900), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(dt.days)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:224:36 [INFO] [stderr] | [INFO] [stderr] 224 | from_sec_fragments(dt.seconds_fragments as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dt.seconds_fragments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:227:27 [INFO] [stderr] | [INFO] [stderr] 227 | from_days(dt.0.days() as i64, 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dt.0.days())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:228:107 [INFO] [stderr] | [INFO] [stderr] 228 | NaiveTime::from_hms(0,0,0) + Duration::nanoseconds(dt.1.increments as i64 * 10i64.pow(9 - dt.1.scale as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(dt.1.scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:230:65 [INFO] [stderr] | [INFO] [stderr] 230 | NaiveDate: ColumnData::Date(ref date) => from_days(date.days() as i64, 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.days())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:238:25 [INFO] [stderr] | [INFO] [stderr] 238 | let nanos = time.num_seconds_from_midnight() as u64 * 1e9 as u64 + time.nanosecond() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(time.num_seconds_from_midnight())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/time.rs:238:80 [INFO] [stderr] | [INFO] [stderr] 238 | let nanos = time.num_seconds_from_midnight() as u64 * 1e9 as u64 + time.nanosecond() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(time.nanosecond())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/mod.rs:405:34 [INFO] [stderr] | [INFO] [stderr] 405 | .ok_or(Error::Encoding("encoding: unspported encoding".into()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Encoding("encoding: unspported encoding".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:422:33 [INFO] [stderr] | [INFO] [stderr] 422 | trans.inner.read_i32::()? as f64 / 1e4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(trans.inner.read_i32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:425:44 [INFO] [stderr] | [INFO] [stderr] 425 | let high = trans.inner.read_i32::()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(trans.inner.read_i32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:426:43 [INFO] [stderr] | [INFO] [stderr] 426 | let low = trans.inner.read_u32::()? as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(trans.inner.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:501:39 [INFO] [stderr] | [INFO] [stderr] 501 | 12 => LittleEndian::read_u32(&buf[8..]) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(LittleEndian::read_u32(&buf[8..]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:521:34 [INFO] [stderr] | [INFO] [stderr] 521 | 5 => trans.inner.read_u32::()? as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(trans.inner.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:541:60 [INFO] [stderr] | [INFO] [stderr] 541 | ColumnData::F64(value / 10f64.powi(*scale as i32)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(*scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/types/mod.rs:781:5 [INFO] [stderr] | [INFO] [stderr] 781 | / test_datatype!( [INFO] [stderr] 782 | | test_bit_1: bool => true, [INFO] [stderr] 783 | | test_bit_0: bool => false, [INFO] [stderr] 784 | | test_i8 : i8 => 127i8, [INFO] [stderr] ... | [INFO] [stderr] 798 | | test_null_some: Option<&str> => Some("hello world") [INFO] [stderr] 799 | | ); [INFO] [stderr] | |______^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/types/mod.rs:781:5 [INFO] [stderr] | [INFO] [stderr] 781 | / test_datatype!( [INFO] [stderr] 782 | | test_bit_1: bool => true, [INFO] [stderr] 783 | | test_bit_0: bool => false, [INFO] [stderr] 784 | | test_i8 : i8 => 127i8, [INFO] [stderr] ... | [INFO] [stderr] 798 | | test_null_some: Option<&str> => Some("hello world") [INFO] [stderr] 799 | | ); [INFO] [stderr] | |______^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/types/mod.rs:781:5 [INFO] [stderr] | [INFO] [stderr] 781 | / test_datatype!( [INFO] [stderr] 782 | | test_bit_1: bool => true, [INFO] [stderr] 783 | | test_bit_0: bool => false, [INFO] [stderr] 784 | | test_i8 : i8 => 127i8, [INFO] [stderr] ... | [INFO] [stderr] 798 | | test_null_some: Option<&str> => Some("hello world") [INFO] [stderr] 799 | | ); [INFO] [stderr] | |______^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/types/mod.rs:781:5 [INFO] [stderr] | [INFO] [stderr] 781 | / test_datatype!( [INFO] [stderr] 782 | | test_bit_1: bool => true, [INFO] [stderr] 783 | | test_bit_0: bool => false, [INFO] [stderr] 784 | | test_i8 : i8 => 127i8, [INFO] [stderr] ... | [INFO] [stderr] 798 | | test_null_some: Option<&str> => Some("hello world") [INFO] [stderr] 799 | | ); [INFO] [stderr] | |______^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/types/mod.rs:829:25 [INFO] [stderr] | [INFO] [stderr] 829 | assert_eq!(row.get::<_, f64>(0), 18446744073709554000000000000000f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/types/mod.rs:829:25 [INFO] [stderr] | [INFO] [stderr] 829 | assert_eq!(row.get::<_, f64>(0), 18446744073709554000000000000000f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/types/mod.rs:842:25 [INFO] [stderr] | [INFO] [stderr] 842 | assert_eq!(row.get::<_, f64>(0), 32.32f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/types/mod.rs:842:25 [INFO] [stderr] | [INFO] [stderr] 842 | assert_eq!(row.get::<_, f64>(0), 32.32f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/types/mod.rs:843:25 [INFO] [stderr] | [INFO] [stderr] 843 | assert_eq!(row.get::<_, f64>(1), 3333333f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/types/mod.rs:843:25 [INFO] [stderr] | [INFO] [stderr] 843 | assert_eq!(row.get::<_, f64>(1), 3333333f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | .ok_or(Error::Protocol("loginack: invalid tds version".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Protocol("loginack: invalid tds version".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:267:18 [INFO] [stderr] | [INFO] [stderr] 267 | .ok_or(Error::Protocol("done(variant): invalid status".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Protocol("done(variant): invalid status".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/tokens.rs:277:41 [INFO] [stderr] | [INFO] [stderr] 277 | const CDF_NULLABLE = 1<<0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: item `query::QueryRow` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/query.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | / impl QueryRow { [INFO] [stderr] 283 | | /// Returns the amount of columns in the row [INFO] [stderr] 284 | | pub fn len(&self) -> usize { [INFO] [stderr] 285 | | self.0.columns.len() [INFO] [stderr] ... | [INFO] [stderr] 311 | | } [INFO] [stderr] 312 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/stmt.rs:181:30 [INFO] [stderr] | [INFO] [stderr] 181 | .or_insert(Vec::with_capacity(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Vec::with_capacity(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:410:95 [INFO] [stderr] | [INFO] [stderr] 410 | let (domain, username) = if let Some(idx) = username.find("\\") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:529:12 [INFO] [stderr] | [INFO] [stderr] 529 | stmts: FnvHashMap, i32, Option>)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ConnectParams` [INFO] [stderr] --> src/lib.rs:559:5 [INFO] [stderr] | [INFO] [stderr] 559 | / pub fn new() -> ConnectParams { [INFO] [stderr] 560 | | ConnectParams { [INFO] [stderr] 561 | | host: Cow::Borrowed(""), [INFO] [stderr] 562 | | ssl: if cfg!(feature = "tls") { [INFO] [stderr] ... | [INFO] [stderr] 571 | | } [INFO] [stderr] 572 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 557 | impl Default for ConnectParams { [INFO] [stderr] 558 | fn default() -> Self { [INFO] [stderr] 559 | Self::new() [INFO] [stderr] 560 | } [INFO] [stderr] 561 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:691:57 [INFO] [stderr] | [INFO] [stderr] 691 | } else if input.trim_left().starts_with(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:692:65 [INFO] [stderr] | [INFO] [stderr] 692 | input = input.trim_left().trim_left_matches(";"); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:729:75 [INFO] [stderr] | [INFO] [stderr] 729 | let addr = (parts[0], 1434).to_socket_addrs()?.nth(0).ok_or(Error::Conversion( [INFO] [stderr] | ___________________________________________________________________________^ [INFO] [stderr] 730 | | "connection string: could not resolve server address".into(), [INFO] [stderr] 731 | | ))?; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 729 | let addr = (parts[0], 1434).to_socket_addrs()?.nth(0).ok_or_else(|| Error::Conversion( [INFO] [stderr] 730 | "connection string: could not resolve server address".into(), [INFO] [stderr] 731 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:736:71 [INFO] [stderr] | [INFO] [stderr] 736 | let addr = (host, port).to_socket_addrs()?.nth(0).ok_or(Error::Conversion( [INFO] [stderr] | _______________________________________________________________________^ [INFO] [stderr] 737 | | "connection string: could not resolve server address".into(), [INFO] [stderr] 738 | | ))?; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 736 | let addr = (host, port).to_socket_addrs()?.nth(0).ok_or_else(|| Error::Conversion( [INFO] [stderr] 737 | "connection string: could not resolve server address".into(), [INFO] [stderr] 738 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:801:25 [INFO] [stderr] | [INFO] [stderr] 801 | let target = target.ok_or(Error::Conversion( [INFO] [stderr] | _________________________^ [INFO] [stderr] 802 | | "connection string pointing into the void. no connection endpoint specified.".into(), [INFO] [stderr] 803 | | ))?; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 801 | let target = target.ok_or_else(|| Error::Conversion( [INFO] [stderr] 802 | "connection string pointing into the void. no connection endpoint specified.".into(), [INFO] [stderr] 803 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:1054:53 [INFO] [stderr] | [INFO] [stderr] 1054 | env::var("TIBERIUS_TEST_CONNECTION_STRING").unwrap_or( [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 1055 | | "server=tcp:localhost,1433;integratedSecurity=true;TrustServerCertificate=true" [INFO] [stderr] 1056 | | .to_owned(), [INFO] [stderr] 1057 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1054 | env::var("TIBERIUS_TEST_CONNECTION_STRING").unwrap_or_else(|_| "server=tcp:localhost,1433;integratedSecurity=true;TrustServerCertificate=true" [INFO] [stderr] 1055 | .to_owned()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tiberius`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5ba386031191aa201e7d2675185870c63072792e276eb7396569025a07a09e59"` [INFO] running `"docker" "rm" "-f" "5ba386031191aa201e7d2675185870c63072792e276eb7396569025a07a09e59"` [INFO] [stdout] 5ba386031191aa201e7d2675185870c63072792e276eb7396569025a07a09e59