[INFO] crate thumbsdbkit 1.0.1 is already in cache [INFO] extracting crate thumbsdbkit 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/thumbsdbkit/1.0.1 [INFO] extracting crate thumbsdbkit 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thumbsdbkit/1.0.1 [INFO] validating manifest of thumbsdbkit-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thumbsdbkit-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thumbsdbkit-1.0.1 [INFO] finished frobbing thumbsdbkit-1.0.1 [INFO] frobbed toml for thumbsdbkit-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/thumbsdbkit/1.0.1/Cargo.toml [INFO] started frobbing thumbsdbkit-1.0.1 [INFO] finished frobbing thumbsdbkit-1.0.1 [INFO] frobbed toml for thumbsdbkit-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thumbsdbkit/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thumbsdbkit-1.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/thumbsdbkit/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89f0319e9aab34328a5f07c3b7d1c06eb31a10bcf04a624a175f76a2ec7169f1 [INFO] running `"docker" "start" "-a" "89f0319e9aab34328a5f07c3b7d1c06eb31a10bcf04a624a175f76a2ec7169f1"` [INFO] [stderr] Checking ole v0.1.15 [INFO] [stderr] Checking thumbsdb v0.1.2 [INFO] [stderr] Checking thumbsdbkit v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kit.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | details: details, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `details` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kit.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | idirid: idirid, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `idirid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kit.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | color: color [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kit.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | details: details, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `details` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kit.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | idirid: idirid, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `idirid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kit.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | color: color [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:22:31 [INFO] [stderr] | [INFO] [stderr] 22 | const DIF_TIME_WINDOWS: u64 = 116444736000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `116_444_736_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:22:31 [INFO] [stderr] | [INFO] [stderr] 22 | const DIF_TIME_WINDOWS: u64 = 116444736000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `116_444_736_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/format.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match self.color { [INFO] [stderr] 52 | | true => match name { [INFO] [stderr] 53 | | "" => [INFO] [stderr] 54 | | ansi_term::Colour::Yellow.paint(name).to_string(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | false => std::string::String::from(name) [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 51 | if self.color { match name { [INFO] [stderr] 52 | "" => [INFO] [stderr] 53 | ansi_term::Colour::Yellow.paint(name).to_string(), [INFO] [stderr] 54 | _ => ansi_term::Colour::Green.paint(name).to_string() [INFO] [stderr] 55 | } } else { std::string::String::from(name) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/format.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / let result: std::string::String; [INFO] [stderr] 64 | | if date == 0 { [INFO] [stderr] 65 | | result = std::string::String::from("(no MAC specified)"); [INFO] [stderr] 66 | | } else { [INFO] [stderr] 67 | | result = chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 68 | | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 63 | let result = if date == 0 { std::string::String::from("(no MAC specified)") } else { chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 64 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:3 [INFO] [stderr] | [INFO] [stderr] 76 | / match kit::kit(&matches) { [INFO] [stderr] 77 | | Err(e) => eprintln!("An error has occured: {}", e), [INFO] [stderr] 78 | | _ => {} [INFO] [stderr] 79 | | } [INFO] [stderr] | |___^ help: try this: `if let Err(e) = kit::kit(&matches) { eprintln!("An error has occured: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/format.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match self.color { [INFO] [stderr] 52 | | true => match name { [INFO] [stderr] 53 | | "" => [INFO] [stderr] 54 | | ansi_term::Colour::Yellow.paint(name).to_string(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | false => std::string::String::from(name) [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 51 | if self.color { match name { [INFO] [stderr] 52 | "" => [INFO] [stderr] 53 | ansi_term::Colour::Yellow.paint(name).to_string(), [INFO] [stderr] 54 | _ => ansi_term::Colour::Green.paint(name).to_string() [INFO] [stderr] 55 | } } else { std::string::String::from(name) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/format.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / let result: std::string::String; [INFO] [stderr] 64 | | if date == 0 { [INFO] [stderr] 65 | | result = std::string::String::from("(no MAC specified)"); [INFO] [stderr] 66 | | } else { [INFO] [stderr] 67 | | result = chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 68 | | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 63 | let result = if date == 0 { std::string::String::from("(no MAC specified)") } else { chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 64 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:3 [INFO] [stderr] | [INFO] [stderr] 76 | / match kit::kit(&matches) { [INFO] [stderr] 77 | | Err(e) => eprintln!("An error has occured: {}", e), [INFO] [stderr] 78 | | _ => {} [INFO] [stderr] 79 | | } [INFO] [stderr] | |___^ help: try this: `if let Err(e) = kit::kit(&matches) { eprintln!("An error has occured: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.26s [INFO] running `"docker" "inspect" "89f0319e9aab34328a5f07c3b7d1c06eb31a10bcf04a624a175f76a2ec7169f1"` [INFO] running `"docker" "rm" "-f" "89f0319e9aab34328a5f07c3b7d1c06eb31a10bcf04a624a175f76a2ec7169f1"` [INFO] [stdout] 89f0319e9aab34328a5f07c3b7d1c06eb31a10bcf04a624a175f76a2ec7169f1