[INFO] crate thumbsdb 0.1.2 is already in cache
[INFO] extracting crate thumbsdb 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/thumbsdb/0.1.2
[INFO] extracting crate thumbsdb 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thumbsdb/0.1.2
[INFO] validating manifest of thumbsdb-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of thumbsdb-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing thumbsdb-0.1.2
[INFO] finished frobbing thumbsdb-0.1.2
[INFO] frobbed toml for thumbsdb-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/thumbsdb/0.1.2/Cargo.toml
[INFO] started frobbing thumbsdb-0.1.2
[INFO] finished frobbing thumbsdb-0.1.2
[INFO] frobbed toml for thumbsdb-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thumbsdb/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting thumbsdb-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/thumbsdb/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0e2e97f8530f4e7f7713671b97ca1f4c427f7970968d722563beef8e7cb189f7
[INFO] running `"docker" "start" "-a" "0e2e97f8530f4e7f7713671b97ca1f4c427f7970968d722563beef8e7cb189f7"`
[INFO] [stderr]     Checking ole v0.1.15
[INFO] [stderr]     Checking thumbsdb v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thumbnail.rs:90:11
[INFO] [stderr]    |
[INFO] [stderr] 90 |           id: id,
[INFO] [stderr]    |           ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thumbnail.rs:91:11
[INFO] [stderr]    |
[INFO] [stderr] 91 |           time: time
[INFO] [stderr]    |           ^^^^^^^^^^ help: replace it with: `time`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iterator.rs:30:7
[INFO] [stderr]    |
[INFO] [stderr] 30 |       thumbsdb: thumbsdb,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^ help: replace it with: `thumbsdb`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thumbnail.rs:90:11
[INFO] [stderr]    |
[INFO] [stderr] 90 |           id: id,
[INFO] [stderr]    |           ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thumbnail.rs:91:11
[INFO] [stderr]    |
[INFO] [stderr] 91 |           time: time
[INFO] [stderr]    |           ^^^^^^^^^^ help: replace it with: `time`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iterator.rs:30:7
[INFO] [stderr]    |
[INFO] [stderr] 30 |       thumbsdb: thumbsdb,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^ help: replace it with: `thumbsdb`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/util.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for <item> in &buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators
[INFO] [stderr]   --> src/util.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/util.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for <item> in &buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators
[INFO] [stderr]   --> src/util.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:39:17
[INFO] [stderr]    |
[INFO] [stderr] 39 |       result += (buf[i] as u32) * 256u32.pow(p);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/util.rs:50:14
[INFO] [stderr]    |
[INFO] [stderr] 50 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 50 |     for <item> in &buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators
[INFO] [stderr]   --> src/util.rs:50:14
[INFO] [stderr]    |
[INFO] [stderr] 50 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |       result += (buf[i] as i32) * 256i32.pow(p);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/util.rs:62:14
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for <item> in &buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators
[INFO] [stderr]   --> src/util.rs:62:14
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:63:17
[INFO] [stderr]    |
[INFO] [stderr] 63 |       result += (buf[i] as u64) * 256u64.pow(p);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/thumbnail.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |         |e| e.name() != &name).next() {
[INFO] [stderr]     |             ^^^^^^^^^^^^-----
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: use the right value directly: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/thumbnail.rs:123:10
[INFO] [stderr]     |
[INFO] [stderr] 123 |       if &buf[12 .. 14] == &JPEG_HEADER {
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 123 |       if buf[12 .. 14] == JPEG_HEADER {
[INFO] [stderr]     |          ^^^^^^^^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/util.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for <item> in &buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators
[INFO] [stderr]   --> src/util.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/util.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for <item> in &buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators
[INFO] [stderr]   --> src/util.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:39:17
[INFO] [stderr]    |
[INFO] [stderr] 39 |       result += (buf[i] as u32) * 256u32.pow(p);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/util.rs:50:14
[INFO] [stderr]    |
[INFO] [stderr] 50 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 50 |     for <item> in &buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators
[INFO] [stderr]   --> src/util.rs:50:14
[INFO] [stderr]    |
[INFO] [stderr] 50 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |       result += (buf[i] as i32) * 256i32.pow(p);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/util.rs:62:14
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for <item> in &buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators
[INFO] [stderr]   --> src/util.rs:62:14
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:63:17
[INFO] [stderr]    |
[INFO] [stderr] 63 |       result += (buf[i] as u64) * 256u64.pow(p);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/thumbnail.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |         |e| e.name() != &name).next() {
[INFO] [stderr]     |             ^^^^^^^^^^^^-----
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: use the right value directly: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/thumbnail.rs:123:10
[INFO] [stderr]     |
[INFO] [stderr] 123 |       if &buf[12 .. 14] == &JPEG_HEADER {
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 123 |       if buf[12 .. 14] == JPEG_HEADER {
[INFO] [stderr]     |          ^^^^^^^^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.38s
[INFO] running `"docker" "inspect" "0e2e97f8530f4e7f7713671b97ca1f4c427f7970968d722563beef8e7cb189f7"`
[INFO] running `"docker" "rm" "-f" "0e2e97f8530f4e7f7713671b97ca1f4c427f7970968d722563beef8e7cb189f7"`
[INFO] [stdout] 0e2e97f8530f4e7f7713671b97ca1f4c427f7970968d722563beef8e7cb189f7