[INFO] crate thrussh-config 0.1.0 is already in cache [INFO] extracting crate thrussh-config 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/thrussh-config/0.1.0 [INFO] extracting crate thrussh-config 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thrussh-config/0.1.0 [INFO] validating manifest of thrussh-config-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thrussh-config-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thrussh-config-0.1.0 [INFO] finished frobbing thrussh-config-0.1.0 [INFO] frobbed toml for thrussh-config-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/thrussh-config/0.1.0/Cargo.toml [INFO] started frobbing thrussh-config-0.1.0 [INFO] finished frobbing thrussh-config-0.1.0 [INFO] frobbed toml for thrussh-config-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thrussh-config/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thrussh-config-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/thrussh-config/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb6de6df741abbc2d5ab4941ccf7090846cd757d2d3c81bf21ef849b11185833 [INFO] running `"docker" "start" "-a" "cb6de6df741abbc2d5ab4941ccf7090846cd757d2d3c81bf21ef849b11185833"` [INFO] [stderr] Compiling thrussh-libsodium v0.1.3 [INFO] [stderr] Checking cryptovec v0.4.6 [INFO] [stderr] Checking yasna v0.1.3 [INFO] [stderr] Checking thrussh-keys v0.11.9 [INFO] [stderr] Checking thrussh v0.20.7 [INFO] [stderr] Checking thrussh-config v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/proxy.rs:95:46 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(n) => Ok(Async::Ready(n)), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 95 | Ok(n) => Ok(Async::Ready(())), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | / match lower.as_str() { [INFO] [stderr] 92 | | "host" => { [INFO] [stderr] 93 | | if value.trim_left() == host { [INFO] [stderr] 94 | | config = Some(Config::default()) [INFO] [stderr] ... | [INFO] [stderr] 97 | | _ => {} [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 91 | if let "host" = lower.as_str() { [INFO] [stderr] 92 | if value.trim_left() == host { [INFO] [stderr] 93 | config = Some(Config::default()) [INFO] [stderr] 94 | } [INFO] [stderr] 95 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/proxy.rs:95:46 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(n) => Ok(Async::Ready(n)), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 95 | Ok(n) => Ok(Async::Ready(())), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | / match lower.as_str() { [INFO] [stderr] 92 | | "host" => { [INFO] [stderr] 93 | | if value.trim_left() == host { [INFO] [stderr] 94 | | config = Some(Config::default()) [INFO] [stderr] ... | [INFO] [stderr] 97 | | _ => {} [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 91 | if let "host" = lower.as_str() { [INFO] [stderr] 92 | if value.trim_left() == host { [INFO] [stderr] 93 | config = Some(Config::default()) [INFO] [stderr] 94 | } [INFO] [stderr] 95 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.78s [INFO] running `"docker" "inspect" "cb6de6df741abbc2d5ab4941ccf7090846cd757d2d3c81bf21ef849b11185833"` [INFO] running `"docker" "rm" "-f" "cb6de6df741abbc2d5ab4941ccf7090846cd757d2d3c81bf21ef849b11185833"` [INFO] [stdout] cb6de6df741abbc2d5ab4941ccf7090846cd757d2d3c81bf21ef849b11185833