[INFO] crate thrift 0.0.4 is already in cache [INFO] extracting crate thrift 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/thrift/0.0.4 [INFO] extracting crate thrift 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thrift/0.0.4 [INFO] validating manifest of thrift-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thrift-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thrift-0.0.4 [INFO] finished frobbing thrift-0.0.4 [INFO] frobbed toml for thrift-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/thrift/0.0.4/Cargo.toml [INFO] started frobbing thrift-0.0.4 [INFO] finished frobbing thrift-0.0.4 [INFO] frobbed toml for thrift-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thrift/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thrift-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/thrift/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bffaab85ca11d445c1ae74e988eabd02d6c897141581c33953933ed80f4e07b6 [INFO] running `"docker" "start" "-a" "bffaab85ca11d445c1ae74e988eabd02d6c897141581c33953933ed80f4e07b6"` [INFO] [stderr] Checking try_from v0.2.2 [INFO] [stderr] Checking integer-encoding v1.0.5 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking thrift v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/binary.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/binary.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/binary.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/binary.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/compact.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/compact.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/compact.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:624:13 [INFO] [stderr] | [INFO] [stderr] 624 | message_type: message_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:625:13 [INFO] [stderr] | [INFO] [stderr] 625 | sequence_number: sequence_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:674:13 [INFO] [stderr] | [INFO] [stderr] 674 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:694:13 [INFO] [stderr] | [INFO] [stderr] 694 | element_type: element_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:695:13 [INFO] [stderr] | [INFO] [stderr] 695 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:714:13 [INFO] [stderr] | [INFO] [stderr] 714 | element_type: element_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:715:13 [INFO] [stderr] | [INFO] [stderr] 715 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:742:13 [INFO] [stderr] | [INFO] [stderr] 742 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport/buffered.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport/framed.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:526:13 [INFO] [stderr] | [INFO] [stderr] 526 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:623:13 [INFO] [stderr] | [INFO] [stderr] 623 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/binary.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/binary.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/binary.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/binary.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/compact.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/compact.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/compact.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:624:13 [INFO] [stderr] | [INFO] [stderr] 624 | message_type: message_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:625:13 [INFO] [stderr] | [INFO] [stderr] 625 | sequence_number: sequence_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:674:13 [INFO] [stderr] | [INFO] [stderr] 674 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:694:13 [INFO] [stderr] | [INFO] [stderr] 694 | element_type: element_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:695:13 [INFO] [stderr] | [INFO] [stderr] 695 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:714:13 [INFO] [stderr] | [INFO] [stderr] 714 | element_type: element_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:715:13 [INFO] [stderr] | [INFO] [stderr] 715 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/mod.rs:742:13 [INFO] [stderr] | [INFO] [stderr] 742 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport/buffered.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport/framed.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:526:13 [INFO] [stderr] | [INFO] [stderr] 526 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:623:13 [INFO] [stderr] | [INFO] [stderr] 623 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary.rs:28:40 [INFO] [stderr] | [INFO] [stderr] 28 | const BINARY_PROTOCOL_VERSION_1: u32 = 0x80010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8001_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/protocol/binary.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server/multiplexed.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | const MISSING_SEPARATOR_AND_NO_DEFAULT: &'static str = "missing service separator and no default processor set"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `map_entry` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/multiplexed.rs:74:48 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(map_entry))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_entry` [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/protocol/binary.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'threadpool::ThreadPool::new_with_name': use ThreadPool::with_name [INFO] [stderr] --> src/server/threaded.rs:158:26 [INFO] [stderr] | [INFO] [stderr] 158 | worker_pool: ThreadPool::new_with_name( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary.rs:28:40 [INFO] [stderr] | [INFO] [stderr] 28 | const BINARY_PROTOCOL_VERSION_1: u32 = 0x80010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8001_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/protocol/binary.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/compact.rs:703:93 [INFO] [stderr] | [INFO] [stderr] 703 | o_prot.write_message_begin(&TMessageIdentifier::new("bar", TMessageType::Reply, 991828)) [INFO] [stderr] | ^^^^^^ help: consider: `991_828` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/compact.rs:725:81 [INFO] [stderr] | [INFO] [stderr] 725 | let ident = TMessageIdentifier::new("service_call", TMessageType::Call, 1283948); [INFO] [stderr] | ^^^^^^^ help: consider: `1_283_948` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/protocol/binary.rs:331:54 [INFO] [stderr] | [INFO] [stderr] 331 | let header = BINARY_PROTOCOL_VERSION_1 | (message_type as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(message_type)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/protocol/compact.rs:89:29 [INFO] [stderr] | [INFO] [stderr] 89 | element_count = possible_element_count as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(possible_element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/protocol/compact.rs:192:48 [INFO] [stderr] | [INFO] [stderr] 192 | self.last_read_field_id += field_delta as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i16::from(field_delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/compact.rs:2221:53 [INFO] [stderr] | [INFO] [stderr] 2221 | let ident = TSetIdentifier::new(TType::Map, 3928429); [INFO] [stderr] | ^^^^^^^ help: consider: `3_928_429` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/compact.rs:2285:66 [INFO] [stderr] | [INFO] [stderr] 2285 | let ident = TMapIdentifier::new(TType::Map, TType::List, 1928349); [INFO] [stderr] | ^^^^^^^ help: consider: `1_928_349` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server/multiplexed.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | const MISSING_SEPARATOR_AND_NO_DEFAULT: &'static str = "missing service separator and no default processor set"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `map_entry` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/multiplexed.rs:74:48 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(feature = "cargo-clippy", allow(map_entry))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_entry` [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/protocol/binary.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'threadpool::ThreadPool::new_with_name': use ThreadPool::with_name [INFO] [stderr] --> src/server/threaded.rs:158:26 [INFO] [stderr] | [INFO] [stderr] 158 | worker_pool: ThreadPool::new_with_name( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/protocol/binary.rs:331:54 [INFO] [stderr] | [INFO] [stderr] 331 | let header = BINARY_PROTOCOL_VERSION_1 | (message_type as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(message_type)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/protocol/compact.rs:89:29 [INFO] [stderr] | [INFO] [stderr] 89 | element_count = possible_element_count as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(possible_element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/protocol/compact.rs:192:48 [INFO] [stderr] | [INFO] [stderr] 192 | self.last_read_field_id += field_delta as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i16::from(field_delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/protocol/compact.rs:1135:5 [INFO] [stderr] | [INFO] [stderr] 1135 | / fn must_round_trip_struct_with_mix_of_long_and_delta_fields() { [INFO] [stderr] 1136 | | let (mut i_prot, mut o_prot) = test_objects(); [INFO] [stderr] 1137 | | [INFO] [stderr] 1138 | | // no bytes should be written however [INFO] [stderr] ... | [INFO] [stderr] 1238 | | assert_success!(i_prot.read_struct_end()); [INFO] [stderr] 1239 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/protocol/compact.rs:1296:5 [INFO] [stderr] | [INFO] [stderr] 1296 | / fn must_round_trip_nested_structs_0() { [INFO] [stderr] 1297 | | // last field of the containing struct is a delta [INFO] [stderr] 1298 | | // first field of the the contained struct is a delta [INFO] [stderr] 1299 | | [INFO] [stderr] ... | [INFO] [stderr] 1410 | | assert_success!(i_prot.read_struct_end()); [INFO] [stderr] 1411 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/protocol/compact.rs:1468:5 [INFO] [stderr] | [INFO] [stderr] 1468 | / fn must_round_trip_nested_structs_1() { [INFO] [stderr] 1469 | | // last field of the containing struct is a delta [INFO] [stderr] 1470 | | // first field of the the contained struct is a full write [INFO] [stderr] 1471 | | [INFO] [stderr] ... | [INFO] [stderr] 1582 | | assert_success!(i_prot.read_struct_end()); [INFO] [stderr] 1583 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/protocol/compact.rs:1640:5 [INFO] [stderr] | [INFO] [stderr] 1640 | / fn must_round_trip_nested_structs_2() { [INFO] [stderr] 1641 | | let (mut i_prot, mut o_prot) = test_objects(); [INFO] [stderr] 1642 | | [INFO] [stderr] 1643 | | // start containing struct [INFO] [stderr] ... | [INFO] [stderr] 1751 | | assert_success!(i_prot.read_struct_end()); [INFO] [stderr] 1752 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/protocol/compact.rs:1810:5 [INFO] [stderr] | [INFO] [stderr] 1810 | / fn must_round_trip_nested_structs_3() { [INFO] [stderr] 1811 | | // last field of the containing struct is a full write [INFO] [stderr] 1812 | | // first field of the the contained struct is a full write [INFO] [stderr] 1813 | | [INFO] [stderr] ... | [INFO] [stderr] 1924 | | assert_success!(i_prot.read_struct_end()); [INFO] [stderr] 1925 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/protocol/compact.rs:1974:5 [INFO] [stderr] | [INFO] [stderr] 1974 | / fn must_round_trip_bool_field() { [INFO] [stderr] 1975 | | let (mut i_prot, mut o_prot) = test_objects(); [INFO] [stderr] 1976 | | [INFO] [stderr] 1977 | | // no bytes should be written however [INFO] [stderr] ... | [INFO] [stderr] 2074 | | assert_success!(i_prot.read_struct_end()); [INFO] [stderr] 2075 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `readable_bytes` [INFO] [stderr] --> src/transport/buffered.rs:328:18 [INFO] [stderr] | [INFO] [stderr] 328 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 328 | for (i, ) in readable_bytes.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/transport/buffered.rs:346:18 [INFO] [stderr] | [INFO] [stderr] 346 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 346 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.74s [INFO] running `"docker" "inspect" "bffaab85ca11d445c1ae74e988eabd02d6c897141581c33953933ed80f4e07b6"` [INFO] running `"docker" "rm" "-f" "bffaab85ca11d445c1ae74e988eabd02d6c897141581c33953933ed80f4e07b6"` [INFO] [stdout] bffaab85ca11d445c1ae74e988eabd02d6c897141581c33953933ed80f4e07b6