[INFO] crate threshold-secret-sharing 0.2.2 is already in cache [INFO] extracting crate threshold-secret-sharing 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/threshold-secret-sharing/0.2.2 [INFO] extracting crate threshold-secret-sharing 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threshold-secret-sharing/0.2.2 [INFO] validating manifest of threshold-secret-sharing-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of threshold-secret-sharing-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing threshold-secret-sharing-0.2.2 [INFO] finished frobbing threshold-secret-sharing-0.2.2 [INFO] frobbed toml for threshold-secret-sharing-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/threshold-secret-sharing/0.2.2/Cargo.toml [INFO] started frobbing threshold-secret-sharing-0.2.2 [INFO] finished frobbing threshold-secret-sharing-0.2.2 [INFO] frobbed toml for threshold-secret-sharing-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threshold-secret-sharing/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting threshold-secret-sharing-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/threshold-secret-sharing/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd715389436e877c2751f47bc8ad95d6e838214738986f86fd7966da1b898718 [INFO] running `"docker" "start" "-a" "cd715389436e877c2751f47bc8ad95d6e838214738986f86fd7966da1b898718"` [INFO] [stderr] Checking threshold-secret-sharing v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fields/montgomery.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | r_inv: r_inv, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `r_inv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fields/montgomery.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | n_quote: n_quote, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `n_quote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/numtheory.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let r = gcd(b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numtheory.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numtheory.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | coefficients: coefficients, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coefficients` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/packed.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/packed.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/packed.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:504:17 [INFO] [stderr] | [INFO] [stderr] 504 | threshold: threshold, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:505:17 [INFO] [stderr] | [INFO] [stderr] 505 | share_count: share_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `share_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:506:17 [INFO] [stderr] | [INFO] [stderr] 506 | secret_count: secret_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secret_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:507:17 [INFO] [stderr] | [INFO] [stderr] 507 | prime: prime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `prime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | omega_secrets: omega_secrets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `omega_secrets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:509:17 [INFO] [stderr] | [INFO] [stderr] 509 | omega_shares: omega_shares, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `omega_shares` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fields/montgomery.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | r_inv: r_inv, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `r_inv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fields/montgomery.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | n_quote: n_quote, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `n_quote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/numtheory.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let r = gcd(b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numtheory.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numtheory.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | coefficients: coefficients, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coefficients` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/packed.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/packed.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/packed.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:504:17 [INFO] [stderr] | [INFO] [stderr] 504 | threshold: threshold, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:505:17 [INFO] [stderr] | [INFO] [stderr] 505 | share_count: share_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `share_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:506:17 [INFO] [stderr] | [INFO] [stderr] 506 | secret_count: secret_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secret_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:507:17 [INFO] [stderr] | [INFO] [stderr] 507 | prime: prime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `prime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | omega_secrets: omega_secrets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `omega_secrets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packed.rs:509:17 [INFO] [stderr] | [INFO] [stderr] 509 | omega_shares: omega_shares, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `omega_shares` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/fields/fft.rs:116:36 [INFO] [stderr] | [INFO] [stderr] 116 | let big_omega = zp.qpow(omega, (data.len() as u32 / 3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/fields/mod.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / macro_rules! all_fields_test { [INFO] [stderr] 99 | | ($field:ty) => { [INFO] [stderr] 100 | | #[test] fn test_convert() { ::fields::test::test_convert::<$field>(); } [INFO] [stderr] 101 | | #[test] fn test_add() { ::fields::test::test_add::<$field>(); } [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/fields/montgomery.rs:61:15 [INFO] [stderr] | [INFO] [stderr] 61 | Value((if t >= (self.n) { t - (self.n) } else { t })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/fields/montgomery.rs:61:15 [INFO] [stderr] | [INFO] [stderr] 61 | Value((if t >= (self.n) { t - (self.n) } else { t })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:92:12 [INFO] [stderr] | [INFO] [stderr] 92 | prime: 746497, [INFO] [stderr] | ^^^^^^ help: consider: `746_497` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | omega_shares: 610121, [INFO] [stderr] | ^^^^^^ help: consider: `610_121` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | prime: 5038849, [INFO] [stderr] | ^^^^^^^ help: consider: `5_038_849` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | omega_secrets: 4318906, [INFO] [stderr] | ^^^^^^^ help: consider: `4_318_906` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | omega_shares: 1814687, [INFO] [stderr] | ^^^^^^^ help: consider: `1_814_687` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/packed.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | coefficients [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/packed.rs:161:28 [INFO] [stderr] | [INFO] [stderr] 161 | let coefficients = fft2_inverse(&values, self.omega_secrets, self.prime); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/packed.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | points [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/packed.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | let points = fft3(&coefficients, self.omega_shares, self.prime); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/packed.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | secrets [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/packed.rs:195:23 [INFO] [stderr] | [INFO] [stderr] 195 | let secrets = (1..self.reconstruct_limit()) [INFO] [stderr] | _______________________^ [INFO] [stderr] 196 | | .map(|e| mod_pow(self.omega_secrets, e as u32, self.prime)) [INFO] [stderr] 197 | | .map(|point| newton_evaluate(&poly, point, self.prime)) [INFO] [stderr] 198 | | .take(self.secret_count) [INFO] [stderr] 199 | | .collect(); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/fields/fft.rs:116:36 [INFO] [stderr] | [INFO] [stderr] 116 | let big_omega = zp.qpow(omega, (data.len() as u32 / 3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fields/fft.rs:208:25 [INFO] [stderr] | [INFO] [stderr] 208 | let zp = F::new(5038849); [INFO] [stderr] | ^^^^^^^ help: consider: `5_038_849` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fields/fft.rs:209:33 [INFO] [stderr] | [INFO] [stderr] 209 | let omega = zp.from_u64(4318906); [INFO] [stderr] | ^^^^^^^ help: consider: `4_318_906` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fields/fft.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | let zp = F::new(5038849); [INFO] [stderr] | ^^^^^^^ help: consider: `5_038_849` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fields/fft.rs:240:33 [INFO] [stderr] | [INFO] [stderr] 240 | let omega = zp.from_u64(1814687); [INFO] [stderr] | ^^^^^^^ help: consider: `1_814_687` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/fields/montgomery.rs:61:15 [INFO] [stderr] | [INFO] [stderr] 61 | Value((if t >= (self.n) { t - (self.n) } else { t })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/fields/montgomery.rs:61:15 [INFO] [stderr] | [INFO] [stderr] 61 | Value((if t >= (self.n) { t - (self.n) } else { t })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:92:12 [INFO] [stderr] | [INFO] [stderr] 92 | prime: 746497, [INFO] [stderr] | ^^^^^^ help: consider: `746_497` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | omega_shares: 610121, [INFO] [stderr] | ^^^^^^ help: consider: `610_121` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | prime: 5038849, [INFO] [stderr] | ^^^^^^^ help: consider: `5_038_849` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | omega_secrets: 4318906, [INFO] [stderr] | ^^^^^^^ help: consider: `4_318_906` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packed.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | omega_shares: 1814687, [INFO] [stderr] | ^^^^^^^ help: consider: `1_814_687` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/packed.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | coefficients [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/packed.rs:161:28 [INFO] [stderr] | [INFO] [stderr] 161 | let coefficients = fft2_inverse(&values, self.omega_secrets, self.prime); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/packed.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | points [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/packed.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | let points = fft3(&coefficients, self.omega_shares, self.prime); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/packed.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | secrets [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/packed.rs:195:23 [INFO] [stderr] | [INFO] [stderr] 195 | let secrets = (1..self.reconstruct_limit()) [INFO] [stderr] | _______________________^ [INFO] [stderr] 196 | | .map(|e| mod_pow(self.omega_secrets, e as u32, self.prime)) [INFO] [stderr] 197 | | .map(|point| newton_evaluate(&poly, point, self.prime)) [INFO] [stderr] 198 | | .take(self.secret_count) [INFO] [stderr] 199 | | .collect(); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fields/mod.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | e = e >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `e >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:37:54 [INFO] [stderr] | [INFO] [stderr] 37 | let tmp = ::numtheory::mod_inverse(r as i64, prime as i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | (tmp + prime as i64) as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | let tmp = ::numtheory::mod_inverse(prime as i64, r as i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fields/montgomery.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 47 | | (r as i64 - tmp) as u32 [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fields/montgomery.rs:44:34 [INFO] [stderr] | [INFO] [stderr] 44 | let n_quote = if tmp > 0 { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 45 | | (r as i64 - tmp) as u32 [INFO] [stderr] 46 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:49:54 [INFO] [stderr] | [INFO] [stderr] 49 | let r_cube = ::numtheory::mod_pow(r as i64 % prime as i64, 3u32, prime as i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:49:74 [INFO] [stderr] | [INFO] [stderr] 49 | let r_cube = ::numtheory::mod_pow(r as i64 % prime as i64, 3u32, prime as i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | let m: u64 = (a as u32).wrapping_mul(self.n_quote) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((a as u32).wrapping_mul(self.n_quote))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | let t: u32 = ((a + m * (self.n as u64)) >> 32) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | self.n as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | let sum = a.0 as u64 + b.0 as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | let sum = a.0 as u64 + b.0 as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | if sum > self.n as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:75:26 [INFO] [stderr] | [INFO] [stderr] 75 | Value((sum - self.n as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | Value((a.0 as u64 + self.n as u64 - b.0 as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:85:33 [INFO] [stderr] | [INFO] [stderr] 85 | Value((a.0 as u64 + self.n as u64 - b.0 as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:85:49 [INFO] [stderr] | [INFO] [stderr] 85 | Value((a.0 as u64 + self.n as u64 - b.0 as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | self.redc((a.0 as u64).wrapping_mul(b.0 as u64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | self.redc((a.0 as u64).wrapping_mul(b.0 as u64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:94:52 [INFO] [stderr] | [INFO] [stderr] 94 | let ar_modn_inv = ::numtheory::mod_inverse(a.0 as i64, self.n as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:94:64 [INFO] [stderr] | [INFO] [stderr] 94 | let ar_modn_inv = ::numtheory::mod_inverse(a.0 as i64, self.n as i64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:95:53 [INFO] [stderr] | [INFO] [stderr] 95 | self.redc((ar_modn_inv as u64).wrapping_mul(self.r_cube as u64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.r_cube)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | Value(((a << 32) % self.n as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | a.0 as u64 * self.r_inv as u64 % self.n as u64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | a.0 as u64 * self.r_inv as u64 % self.n as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.r_inv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:107:42 [INFO] [stderr] | [INFO] [stderr] 107 | a.0 as u64 * self.r_inv as u64 % self.n as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/numtheory.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | e = e >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `e >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `points` [INFO] [stderr] --> src/numtheory.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | for j in 0..values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 190 | for (j, ) in points.iter().enumerate().take(values.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/numtheory.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | let ref newton_coefs = poly.coefficients; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^--------------------- help: try: `let newton_coefs = &poly.coefficients;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/shamir.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | (1..self.share_count + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=self.share_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `threshold-secret-sharing`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fields/mod.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | e = e >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `e >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:37:54 [INFO] [stderr] | [INFO] [stderr] 37 | let tmp = ::numtheory::mod_inverse(r as i64, prime as i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | (tmp + prime as i64) as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | let tmp = ::numtheory::mod_inverse(prime as i64, r as i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fields/montgomery.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 47 | | (r as i64 - tmp) as u32 [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fields/montgomery.rs:44:34 [INFO] [stderr] | [INFO] [stderr] 44 | let n_quote = if tmp > 0 { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 45 | | (r as i64 - tmp) as u32 [INFO] [stderr] 46 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:49:54 [INFO] [stderr] | [INFO] [stderr] 49 | let r_cube = ::numtheory::mod_pow(r as i64 % prime as i64, 3u32, prime as i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:49:74 [INFO] [stderr] | [INFO] [stderr] 49 | let r_cube = ::numtheory::mod_pow(r as i64 % prime as i64, 3u32, prime as i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(prime)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | let m: u64 = (a as u32).wrapping_mul(self.n_quote) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((a as u32).wrapping_mul(self.n_quote))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | let t: u32 = ((a + m * (self.n as u64)) >> 32) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | self.n as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | let sum = a.0 as u64 + b.0 as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | let sum = a.0 as u64 + b.0 as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | if sum > self.n as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:75:26 [INFO] [stderr] | [INFO] [stderr] 75 | Value((sum - self.n as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | Value((a.0 as u64 + self.n as u64 - b.0 as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:85:33 [INFO] [stderr] | [INFO] [stderr] 85 | Value((a.0 as u64 + self.n as u64 - b.0 as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:85:49 [INFO] [stderr] | [INFO] [stderr] 85 | Value((a.0 as u64 + self.n as u64 - b.0 as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | self.redc((a.0 as u64).wrapping_mul(b.0 as u64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | self.redc((a.0 as u64).wrapping_mul(b.0 as u64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:94:52 [INFO] [stderr] | [INFO] [stderr] 94 | let ar_modn_inv = ::numtheory::mod_inverse(a.0 as i64, self.n as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:94:64 [INFO] [stderr] | [INFO] [stderr] 94 | let ar_modn_inv = ::numtheory::mod_inverse(a.0 as i64, self.n as i64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:95:53 [INFO] [stderr] | [INFO] [stderr] 95 | self.redc((ar_modn_inv as u64).wrapping_mul(self.r_cube as u64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.r_cube)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | Value(((a << 32) % self.n as u64) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | a.0 as u64 * self.r_inv as u64 % self.n as u64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | a.0 as u64 * self.r_inv as u64 % self.n as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.r_inv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fields/montgomery.rs:107:42 [INFO] [stderr] | [INFO] [stderr] 107 | a.0 as u64 * self.r_inv as u64 % self.n as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/numtheory.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | e = e >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `e >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `points` [INFO] [stderr] --> src/numtheory.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | for j in 0..values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 190 | for (j, ) in points.iter().enumerate().take(values.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/numtheory.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | let ref newton_coefs = poly.coefficients; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^--------------------- help: try: `let newton_coefs = &poly.coefficients;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/shamir.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | (1..self.share_count + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=self.share_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/shamir.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | let ref tss = SHAMIR_5_20; [INFO] [stderr] | ----^^^^^^^--------------- help: try: `let tss = &SHAMIR_5_20;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/packed.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | let ref pss = PSS_4_8_3; [INFO] [stderr] | ----^^^^^^^------------- help: try: `let pss = &PSS_4_8_3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/packed.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | let ref pss = PSS_4_26_3; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let pss = &PSS_4_26_3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/packed.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | let ref pss = PSS_4_26_3; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let pss = &PSS_4_26_3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/packed.rs:252:43 [INFO] [stderr] | [INFO] [stderr] 252 | let recovered_secrets: Vec = (1..secrets.len() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=secrets.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/packed.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | let ref pss = PSS_155_19682_100; [INFO] [stderr] | ----^^^^^^^--------------------- help: try: `let pss = &PSS_155_19682_100;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/packed.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | let ref pss = PSS_4_26_3; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let pss = &PSS_4_26_3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/packed.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | let ref pss = PSS_4_26_3; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let pss = &PSS_4_26_3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/packed.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | let ref pss = PSS_4_26_3; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let pss = &PSS_4_26_3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `threshold-secret-sharing`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cd715389436e877c2751f47bc8ad95d6e838214738986f86fd7966da1b898718"` [INFO] running `"docker" "rm" "-f" "cd715389436e877c2751f47bc8ad95d6e838214738986f86fd7966da1b898718"` [INFO] [stdout] cd715389436e877c2751f47bc8ad95d6e838214738986f86fd7966da1b898718