[INFO] crate threefish-cipher 0.3.0 is already in cache [INFO] extracting crate threefish-cipher 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/threefish-cipher/0.3.0 [INFO] extracting crate threefish-cipher 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threefish-cipher/0.3.0 [INFO] validating manifest of threefish-cipher-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of threefish-cipher-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing threefish-cipher-0.3.0 [INFO] finished frobbing threefish-cipher-0.3.0 [INFO] frobbed toml for threefish-cipher-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/threefish-cipher/0.3.0/Cargo.toml [INFO] started frobbing threefish-cipher-0.3.0 [INFO] finished frobbing threefish-cipher-0.3.0 [INFO] frobbed toml for threefish-cipher-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threefish-cipher/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting threefish-cipher-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/threefish-cipher/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb702aa6eb1e8d258228d0da7f2adb648cb2bffb47294afce769abb3fab36417 [INFO] running `"docker" "start" "-a" "cb702aa6eb1e8d258228d0da7f2adb648cb2bffb47294afce769abb3fab36417"` [INFO] [stderr] Compiling hex-literal-impl v0.1.1 [INFO] [stderr] Checking byteorder v1.3.1 [INFO] [stderr] Checking block-cipher-trait v0.6.2 [INFO] [stderr] Checking threefish-cipher v0.3.0 (/opt/crater/workdir) [INFO] [stderr] Checking hex-literal v0.1.2 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | pub const C240: u64 = 0x1BD11BDAA9FC1A22; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1BD1_1BDA_A9FC_1A22` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | for s in 0..($rounds / 4 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=$rounds / 4` [INFO] [stderr] ... [INFO] [stderr] 154 | impl_threefish!(Threefish256, 72, 4, U32, R_256, P_256); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | for s in 0..($rounds / 4 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=$rounds / 4` [INFO] [stderr] ... [INFO] [stderr] 155 | impl_threefish!(Threefish512, 72, 8, U64, R_512, P_512); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | for s in 0..($rounds / 4 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=$rounds / 4` [INFO] [stderr] ... [INFO] [stderr] 156 | impl_threefish!(Threefish1024, 80, 16, U128, R_1024, P_1024); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: expected expression, found keyword `mut` [INFO] [stderr] --> benches/lib.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | state.encrypt_block(mut GenericArray::from_slice(input)); [INFO] [stderr] | ^^^ expected expression [INFO] [stderr] [INFO] [stderr] error: expected expression, found keyword `mut` [INFO] [stderr] --> benches/lib.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | state.encrypt_block(mut GenericArray::from_slice(input)); [INFO] [stderr] | ^^^ expected expression [INFO] [stderr] [INFO] [stderr] error: expected expression, found keyword `mut` [INFO] [stderr] --> benches/lib.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | state.encrypt_block(mut GenericArray::from_slice(input)); [INFO] [stderr] | ^^^ expected expression [INFO] [stderr] [INFO] [stderr] error[E0463]: can't find crate for `threefish` [INFO] [stderr] --> benches/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | extern crate threefish; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `threefish-cipher`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | pub const C240: u64 = 0x1BD11BDAA9FC1A22; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1BD1_1BDA_A9FC_1A22` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:175:51 [INFO] [stderr] | [INFO] [stderr] 175 | let fish = Threefish256::with_tweak(&key, 0x0706050403020100, 0x0f0e0d0c0b0a0908); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0706_0504_0302_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:175:71 [INFO] [stderr] | [INFO] [stderr] 175 | let fish = Threefish256::with_tweak(&key, 0x0706050403020100, 0x0f0e0d0c0b0a0908); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0f0e_0d0c_0b0a_0908` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:196:51 [INFO] [stderr] | [INFO] [stderr] 196 | let fish = Threefish512::with_tweak(&key, 0x0706050403020100, 0x0f0e0d0c0b0a0908); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0706_0504_0302_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:196:71 [INFO] [stderr] | [INFO] [stderr] 196 | let fish = Threefish512::with_tweak(&key, 0x0706050403020100, 0x0f0e0d0c0b0a0908); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0f0e_0d0c_0b0a_0908` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:226:52 [INFO] [stderr] | [INFO] [stderr] 226 | let fish = Threefish1024::with_tweak(&key, 0x0706050403020100, 0x0f0e0d0c0b0a0908); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0706_0504_0302_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:226:72 [INFO] [stderr] | [INFO] [stderr] 226 | let fish = Threefish1024::with_tweak(&key, 0x0706050403020100, 0x0f0e0d0c0b0a0908); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0f0e_0d0c_0b0a_0908` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | for s in 0..($rounds / 4 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=$rounds / 4` [INFO] [stderr] ... [INFO] [stderr] 154 | impl_threefish!(Threefish256, 72, 4, U32, R_256, P_256); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | for s in 0..($rounds / 4 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=$rounds / 4` [INFO] [stderr] ... [INFO] [stderr] 155 | impl_threefish!(Threefish512, 72, 8, U64, R_512, P_512); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | for s in 0..($rounds / 4 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=$rounds / 4` [INFO] [stderr] ... [INFO] [stderr] 156 | impl_threefish!(Threefish1024, 80, 16, U128, R_1024, P_1024); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "cb702aa6eb1e8d258228d0da7f2adb648cb2bffb47294afce769abb3fab36417"` [INFO] running `"docker" "rm" "-f" "cb702aa6eb1e8d258228d0da7f2adb648cb2bffb47294afce769abb3fab36417"` [INFO] [stdout] cb702aa6eb1e8d258228d0da7f2adb648cb2bffb47294afce769abb3fab36417