[INFO] crate threads_pool 0.1.7 is already in cache [INFO] extracting crate threads_pool 0.1.7 into work/ex/clippy-test-run/sources/stable/reg/threads_pool/0.1.7 [INFO] extracting crate threads_pool 0.1.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threads_pool/0.1.7 [INFO] validating manifest of threads_pool-0.1.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of threads_pool-0.1.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing threads_pool-0.1.7 [INFO] finished frobbing threads_pool-0.1.7 [INFO] frobbed toml for threads_pool-0.1.7 written to work/ex/clippy-test-run/sources/stable/reg/threads_pool/0.1.7/Cargo.toml [INFO] started frobbing threads_pool-0.1.7 [INFO] finished frobbing threads_pool-0.1.7 [INFO] frobbed toml for threads_pool-0.1.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threads_pool/0.1.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting threads_pool-0.1.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/threads_pool/0.1.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b8a783b1c5933f806ff73d1601f68395e3804fc262a7b5e5c5b33f3feb5f331 [INFO] running `"docker" "start" "-a" "7b8a783b1c5933f806ff73d1601f68395e3804fc262a7b5e5c5b33f3feb5f331"` [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking threads_pool v0.1.7 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scheduler.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | static THRESHOLD: usize = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scheduler.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | static THRESHOLD: usize = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/single_pool.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | / match &pool.auto_mode { [INFO] [stderr] 46 | | &true => pool.store.execute_automode(f), [INFO] [stderr] 47 | | &false => pool.store.execute(f), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 45 | match pool.auto_mode { [INFO] [stderr] 46 | true => pool.store.execute_automode(f), [INFO] [stderr] 47 | false => pool.store.execute(f), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`std::option::Option`) to itself [INFO] [stderr] --> src/single_pool.rs:178:16 [INFO] [stderr] | [INFO] [stderr] 178 | POOL = mem::transmute(pool); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/multi_pools.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn initialize(keys: HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 26 | pub fn initialize(keys: HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`std::option::Option`) to itself [INFO] [stderr] --> src/multi_pools.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | MULTI_POOL = mem::transmute(pool); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/multi_pools.rs:180:45 [INFO] [stderr] | [INFO] [stderr] 180 | pools.auto_adjust_period = Some(actual_period.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `actual_period` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/multi_pools.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / match auto_adjust { [INFO] [stderr] 229 | | true => { [INFO] [stderr] 230 | | let to_launch_handler = pool.auto_adjust_register.is_empty(); [INFO] [stderr] 231 | | [INFO] [stderr] ... | [INFO] [stderr] 247 | | }, [INFO] [stderr] 248 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 228 | if auto_adjust { [INFO] [stderr] 229 | let to_launch_handler = pool.auto_adjust_register.is_empty(); [INFO] [stderr] 230 | [INFO] [stderr] 231 | pool.auto_adjust_register.insert(key); [INFO] [stderr] 232 | [INFO] [stderr] 233 | if to_launch_handler { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scheduler.rs:127:16 [INFO] [stderr] | [INFO] [stderr] 127 | if self.workers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.workers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/single_pool.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | / match &pool.auto_mode { [INFO] [stderr] 46 | | &true => pool.store.execute_automode(f), [INFO] [stderr] 47 | | &false => pool.store.execute(f), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 45 | match pool.auto_mode { [INFO] [stderr] 46 | true => pool.store.execute_automode(f), [INFO] [stderr] 47 | false => pool.store.execute(f), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`std::option::Option`) to itself [INFO] [stderr] --> src/single_pool.rs:178:16 [INFO] [stderr] | [INFO] [stderr] 178 | POOL = mem::transmute(pool); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/multi_pools.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn initialize(keys: HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 26 | pub fn initialize(keys: HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`std::option::Option`) to itself [INFO] [stderr] --> src/multi_pools.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | MULTI_POOL = mem::transmute(pool); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/multi_pools.rs:180:45 [INFO] [stderr] | [INFO] [stderr] 180 | pools.auto_adjust_period = Some(actual_period.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `actual_period` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/multi_pools.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / match auto_adjust { [INFO] [stderr] 229 | | true => { [INFO] [stderr] 230 | | let to_launch_handler = pool.auto_adjust_register.is_empty(); [INFO] [stderr] 231 | | [INFO] [stderr] ... | [INFO] [stderr] 247 | | }, [INFO] [stderr] 248 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 228 | if auto_adjust { [INFO] [stderr] 229 | let to_launch_handler = pool.auto_adjust_register.is_empty(); [INFO] [stderr] 230 | [INFO] [stderr] 231 | pool.auto_adjust_register.insert(key); [INFO] [stderr] 232 | [INFO] [stderr] 233 | if to_launch_handler { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scheduler.rs:127:16 [INFO] [stderr] | [INFO] [stderr] 127 | if self.workers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.workers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.57s [INFO] running `"docker" "inspect" "7b8a783b1c5933f806ff73d1601f68395e3804fc262a7b5e5c5b33f3feb5f331"` [INFO] running `"docker" "rm" "-f" "7b8a783b1c5933f806ff73d1601f68395e3804fc262a7b5e5c5b33f3feb5f331"` [INFO] [stdout] 7b8a783b1c5933f806ff73d1601f68395e3804fc262a7b5e5c5b33f3feb5f331