[INFO] crate threading 0.1.2 is already in cache [INFO] extracting crate threading 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/threading/0.1.2 [INFO] extracting crate threading 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threading/0.1.2 [INFO] validating manifest of threading-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of threading-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing threading-0.1.2 [INFO] finished frobbing threading-0.1.2 [INFO] frobbed toml for threading-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/threading/0.1.2/Cargo.toml [INFO] started frobbing threading-0.1.2 [INFO] finished frobbing threading-0.1.2 [INFO] frobbed toml for threading-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threading/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting threading-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/threading/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4af4134f9f8a4967f1b7e3aee6fb5c88ab18e10cb7e30a10341efe15b72159f5 [INFO] running `"docker" "start" "-a" "4af4134f9f8a4967f1b7e3aee6fb5c88ab18e10cb7e30a10341efe15b72159f5"` [INFO] [stderr] Checking threading v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | min_num: min_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `min_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | max_num: max_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `max_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | min_num: min_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `min_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | max_num: max_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `max_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Pool` [INFO] [stderr] --> src/lib.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new() -> Pool { [INFO] [stderr] 56 | | let min_num = num_cpus::get(); [INFO] [stderr] 57 | | let max_num = min_num * 16; [INFO] [stderr] 58 | | [INFO] [stderr] ... | [INFO] [stderr] 74 | | pool [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | impl Default for Pool { [INFO] [stderr] 55 | fn default() -> Self { [INFO] [stderr] 56 | Self::new() [INFO] [stderr] 57 | } [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Pool` [INFO] [stderr] --> src/lib.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new() -> Pool { [INFO] [stderr] 56 | | let min_num = num_cpus::get(); [INFO] [stderr] 57 | | let max_num = min_num * 16; [INFO] [stderr] 58 | | [INFO] [stderr] ... | [INFO] [stderr] 74 | | pool [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | impl Default for Pool { [INFO] [stderr] 55 | fn default() -> Self { [INFO] [stderr] 56 | Self::new() [INFO] [stderr] 57 | } [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/lib.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | i * i; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/lib.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | i * i; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "4af4134f9f8a4967f1b7e3aee6fb5c88ab18e10cb7e30a10341efe15b72159f5"` [INFO] running `"docker" "rm" "-f" "4af4134f9f8a4967f1b7e3aee6fb5c88ab18e10cb7e30a10341efe15b72159f5"` [INFO] [stdout] 4af4134f9f8a4967f1b7e3aee6fb5c88ab18e10cb7e30a10341efe15b72159f5