[INFO] crate threadgroup 0.1.0 is already in cache [INFO] extracting crate threadgroup 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/threadgroup/0.1.0 [INFO] extracting crate threadgroup 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threadgroup/0.1.0 [INFO] validating manifest of threadgroup-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of threadgroup-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing threadgroup-0.1.0 [INFO] finished frobbing threadgroup-0.1.0 [INFO] frobbed toml for threadgroup-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/threadgroup/0.1.0/Cargo.toml [INFO] started frobbing threadgroup-0.1.0 [INFO] finished frobbing threadgroup-0.1.0 [INFO] frobbed toml for threadgroup-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/threadgroup/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting threadgroup-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/threadgroup/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c72a8cd678826f41d060c6be67a13f788741f2f3fd8fd0d0cbf7be22ccb2dda [INFO] running `"docker" "start" "-a" "7c72a8cd678826f41d060c6be67a13f788741f2f3fd8fd0d0cbf7be22ccb2dda"` [INFO] [stderr] Checking threadgroup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | ThreadGroup::{tx: tx, rx: rx, handles: vec![]} [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | ThreadGroup::{tx: tx, rx: rx, handles: vec![]} [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | ThreadGroup::{tx: tx, rx: rx, handles: vec![]} [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | ThreadGroup::{tx: tx, rx: rx, handles: vec![]} [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ThreadGroup` [INFO] [stderr] --> src/lib.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new() -> ThreadGroup { [INFO] [stderr] 87 | | let (tx, rx): (Sender, Receiver) = mpsc::channel(); [INFO] [stderr] 88 | | ThreadGroup::{tx: tx, rx: rx, handles: vec![]} [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | impl Default for ThreadGroup { [INFO] [stderr] 79 | fn default() -> Self { [INFO] [stderr] 80 | Self::new() [INFO] [stderr] 81 | } [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / match self.handles.is_empty() { [INFO] [stderr] 152 | | true => Err(JoinError::AllDone), [INFO] [stderr] 153 | | false => match self.rx.recv() { [INFO] [stderr] 154 | | Ok(id) => self.do_join(id), [INFO] [stderr] 155 | | Err(RecvError{}) => Err(JoinError::Disconnected) [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 151 | if self.handles.is_empty() { Err(JoinError::AllDone) } else { match self.rx.recv() { [INFO] [stderr] 152 | Ok(id) => self.do_join(id), [INFO] [stderr] 153 | Err(RecvError{}) => Err(JoinError::Disconnected) [INFO] [stderr] 154 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | / match self.handles.is_empty() { [INFO] [stderr] 178 | | true => Err(JoinError::AllDone), [INFO] [stderr] 179 | | false => match self.rx.recv_timeout(timeout) { [INFO] [stderr] 180 | | Ok(id) => self.do_join(id), [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 177 | if self.handles.is_empty() { Err(JoinError::AllDone) } else { match self.rx.recv_timeout(timeout) { [INFO] [stderr] 178 | Ok(id) => self.do_join(id), [INFO] [stderr] 179 | Err(RecvTimeoutError::Timeout) => Err(JoinError::Timeout), [INFO] [stderr] 180 | Err(RecvTimeoutError::Disconnected) => Err(JoinError::Disconnected) [INFO] [stderr] 181 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:226:53 [INFO] [stderr] | [INFO] [stderr] 226 | tg.spawn::<_,u32>(|| {sleep(Duration::new(0,1000000));1}); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:227:53 [INFO] [stderr] | [INFO] [stderr] 227 | tg.spawn::<_,u32>(|| {sleep(Duration::new(0,3000000));3}); [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:228:53 [INFO] [stderr] | [INFO] [stderr] 228 | tg.spawn::<_,u32>(|| {sleep(Duration::new(0,2000000));2}); [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:237:53 [INFO] [stderr] | [INFO] [stderr] 237 | tg.spawn::<_,u32>(|| {sleep(Duration::new(0,1500000));panic!()}); [INFO] [stderr] | ^^^^^^^ help: consider: `1_500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:238:53 [INFO] [stderr] | [INFO] [stderr] 238 | tg.spawn::<_,u32>(|| {sleep(Duration::new(0,1000000));1}); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:246:51 [INFO] [stderr] | [INFO] [stderr] 246 | tg.spawn::<_,u32>(|| {sleep(Duration::new(1000000,0));2}); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:247:53 [INFO] [stderr] | [INFO] [stderr] 247 | tg.spawn::<_,u32>(|| {sleep(Duration::new(0,1000000));1}); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ThreadGroup` [INFO] [stderr] --> src/lib.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new() -> ThreadGroup { [INFO] [stderr] 87 | | let (tx, rx): (Sender, Receiver) = mpsc::channel(); [INFO] [stderr] 88 | | ThreadGroup::{tx: tx, rx: rx, handles: vec![]} [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | impl Default for ThreadGroup { [INFO] [stderr] 79 | fn default() -> Self { [INFO] [stderr] 80 | Self::new() [INFO] [stderr] 81 | } [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / match self.handles.is_empty() { [INFO] [stderr] 152 | | true => Err(JoinError::AllDone), [INFO] [stderr] 153 | | false => match self.rx.recv() { [INFO] [stderr] 154 | | Ok(id) => self.do_join(id), [INFO] [stderr] 155 | | Err(RecvError{}) => Err(JoinError::Disconnected) [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 151 | if self.handles.is_empty() { Err(JoinError::AllDone) } else { match self.rx.recv() { [INFO] [stderr] 152 | Ok(id) => self.do_join(id), [INFO] [stderr] 153 | Err(RecvError{}) => Err(JoinError::Disconnected) [INFO] [stderr] 154 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | / match self.handles.is_empty() { [INFO] [stderr] 178 | | true => Err(JoinError::AllDone), [INFO] [stderr] 179 | | false => match self.rx.recv_timeout(timeout) { [INFO] [stderr] 180 | | Ok(id) => self.do_join(id), [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 177 | if self.handles.is_empty() { Err(JoinError::AllDone) } else { match self.rx.recv_timeout(timeout) { [INFO] [stderr] 178 | Ok(id) => self.do_join(id), [INFO] [stderr] 179 | Err(RecvTimeoutError::Timeout) => Err(JoinError::Timeout), [INFO] [stderr] 180 | Err(RecvTimeoutError::Disconnected) => Err(JoinError::Disconnected) [INFO] [stderr] 181 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "7c72a8cd678826f41d060c6be67a13f788741f2f3fd8fd0d0cbf7be22ccb2dda"` [INFO] running `"docker" "rm" "-f" "7c72a8cd678826f41d060c6be67a13f788741f2f3fd8fd0d0cbf7be22ccb2dda"` [INFO] [stdout] 7c72a8cd678826f41d060c6be67a13f788741f2f3fd8fd0d0cbf7be22ccb2dda