[INFO] crate thread_task_runner 0.1.0 is already in cache [INFO] extracting crate thread_task_runner 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/thread_task_runner/0.1.0 [INFO] extracting crate thread_task_runner 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thread_task_runner/0.1.0 [INFO] validating manifest of thread_task_runner-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thread_task_runner-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thread_task_runner-0.1.0 [INFO] finished frobbing thread_task_runner-0.1.0 [INFO] frobbed toml for thread_task_runner-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/thread_task_runner/0.1.0/Cargo.toml [INFO] started frobbing thread_task_runner-0.1.0 [INFO] finished frobbing thread_task_runner-0.1.0 [INFO] frobbed toml for thread_task_runner-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thread_task_runner/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thread_task_runner-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/thread_task_runner/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f8941708f1f4c245cb44dc2b855d3805f378f023180859cd6763a6e4c52e9fb [INFO] running `"docker" "start" "-a" "4f8941708f1f4c245cb44dc2b855d3805f378f023180859cd6763a6e4c52e9fb"` [INFO] [stderr] Checking thread_task_runner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task_runner.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | TaskChannel { sender: sender, receiver: receiver } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task_runner.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | TaskChannel { sender: sender, receiver: receiver } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task_runner.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | parameter: parameter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task_runner.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | TaskChannel { sender: sender, receiver: receiver } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task_runner.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | TaskChannel { sender: sender, receiver: receiver } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task_runner.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | parameter: parameter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task_runner.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return affected; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `affected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task_runner.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / match parameter.downcast() { [INFO] [stderr] 60 | | Ok(params) => { [INFO] [stderr] 61 | | (callback)(params); [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | Err(_) => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let Ok(params) = parameter.downcast() { [INFO] [stderr] 60 | (callback)(params); [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task_runner.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | / match *running_status { [INFO] [stderr] 106 | | RunningStatus::Stopping => { [INFO] [stderr] 107 | | *running_status = RunningStatus::Stopped; [INFO] [stderr] 108 | | break; [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | _ => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task_runner.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return affected; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `affected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let RunningStatus::Stopping = *running_status { [INFO] [stderr] 106 | *running_status = RunningStatus::Stopped; [INFO] [stderr] 107 | break; [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task_runner.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / match parameter.downcast() { [INFO] [stderr] 60 | | Ok(params) => { [INFO] [stderr] 61 | | (callback)(params); [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | Err(_) => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let Ok(params) = parameter.downcast() { [INFO] [stderr] 60 | (callback)(params); [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task_runner.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | / match *running_status { [INFO] [stderr] 106 | | RunningStatus::Stopping => { [INFO] [stderr] 107 | | *running_status = RunningStatus::Stopped; [INFO] [stderr] 108 | | break; [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | _ => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let RunningStatus::Stopping = *running_status { [INFO] [stderr] 106 | *running_status = RunningStatus::Stopped; [INFO] [stderr] 107 | break; [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "4f8941708f1f4c245cb44dc2b855d3805f378f023180859cd6763a6e4c52e9fb"` [INFO] running `"docker" "rm" "-f" "4f8941708f1f4c245cb44dc2b855d3805f378f023180859cd6763a6e4c52e9fb"` [INFO] [stdout] 4f8941708f1f4c245cb44dc2b855d3805f378f023180859cd6763a6e4c52e9fb