[INFO] crate thin-vec 0.1.0 is already in cache [INFO] extracting crate thin-vec 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/thin-vec/0.1.0 [INFO] extracting crate thin-vec 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thin-vec/0.1.0 [INFO] validating manifest of thin-vec-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thin-vec-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thin-vec-0.1.0 [INFO] finished frobbing thin-vec-0.1.0 [INFO] frobbed toml for thin-vec-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/thin-vec/0.1.0/Cargo.toml [INFO] started frobbing thin-vec-0.1.0 [INFO] finished frobbing thin-vec-0.1.0 [INFO] frobbed toml for thin-vec-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thin-vec/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thin-vec-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/thin-vec/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a9f67f637253ef8b0aa4be8c46f238554a5a1888ba2bc69d111d404fbd041579 [INFO] running `"docker" "start" "-a" "a9f67f637253ef8b0aa4be8c46f238554a5a1888ba2bc69d111d404fbd041579"` [INFO] [stderr] Checking thin-vec v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:659:17 [INFO] [stderr] | [INFO] [stderr] 659 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:661:17 [INFO] [stderr] | [INFO] [stderr] 661 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:659:17 [INFO] [stderr] | [INFO] [stderr] 659 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:661:17 [INFO] [stderr] | [INFO] [stderr] 661 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1570:26 [INFO] [stderr] | [INFO] [stderr] 1570 | if *x == 0xbadbeef { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0bad_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1576:63 [INFO] [stderr] | [INFO] [stderr] 1576 | let mut v = thin_vec![BadElem(1), BadElem(2), BadElem(0xbadbeef), BadElem(4)]; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0bad_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | ptr.offset(header_size as isize) as *mut T [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(header_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut Header`) [INFO] [stderr] --> src/lib.rs:162:22 [INFO] [stderr] | [INFO] [stderr] 162 | let header = heap::allocate( [INFO] [stderr] | ______________________^ [INFO] [stderr] 163 | | alloc_size::(cap), [INFO] [stderr] 164 | | alloc_align::(), [INFO] [stderr] 165 | | ) as *mut Header; [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:285:24 [INFO] [stderr] | [INFO] [stderr] 285 | ptr::write(self.data_raw().offset(old_len as isize), val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_raw().add(old_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:309:23 [INFO] [stderr] | [INFO] [stderr] 309 | ptr::copy(ptr.offset(idx as isize), ptr.offset(idx as isize + 1), old_len - idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:310:24 [INFO] [stderr] | [INFO] [stderr] 310 | ptr::write(ptr.offset(idx as isize), elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:323:33 [INFO] [stderr] | [INFO] [stderr] 323 | let val = ptr::read(self.data_raw().offset(idx as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_raw().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:324:53 [INFO] [stderr] | [INFO] [stderr] 324 | ptr::copy(ptr.offset(idx as isize + 1), ptr.offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:337:23 [INFO] [stderr] | [INFO] [stderr] 337 | ptr::swap(ptr.offset(idx as isize), ptr.offset(old_len as isize - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:361:16 [INFO] [stderr] | [INFO] [stderr] 361 | if self.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:583:27 [INFO] [stderr] | [INFO] [stderr] 583 | let p_r = p.offset(r as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `p.add(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:584:29 [INFO] [stderr] | [INFO] [stderr] 584 | let p_wm1 = p.offset((w - 1) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add((w - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:608:38 [INFO] [stderr] | [INFO] [stderr] 608 | ptr::copy_nonoverlapping(self.data_raw().offset(at as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_raw().add(at)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:654:17 [INFO] [stderr] | [INFO] [stderr] 654 | self.data_raw().offset(start as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_raw().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut Header`) [INFO] [stderr] --> src/lib.rs:681:23 [INFO] [stderr] | [INFO] [stderr] 681 | let ptr = heap::reallocate(self.ptr() as *mut u8, [INFO] [stderr] | _______________________^ [INFO] [stderr] 682 | | alloc_size::(old_cap), [INFO] [stderr] 683 | | alloc_size::(new_cap), [INFO] [stderr] 684 | | alloc_align::()) as *mut Header; [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:856:5 [INFO] [stderr] | [INFO] [stderr] 856 | fn ne(&self, other: &ThinVec) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:863:5 [INFO] [stderr] | [INFO] [stderr] 863 | fn ne(&self, other: &Vec) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:870:5 [INFO] [stderr] | [INFO] [stderr] 870 | fn ne(&self, other: &[B]) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:877:5 [INFO] [stderr] | [INFO] [stderr] 877 | fn ne(&self, other: &&'a [B]) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:886:13 [INFO] [stderr] | [INFO] [stderr] 886 | fn ne(&self, other: &[B; $N]) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 898 | / array_impls! { [INFO] [stderr] 899 | | 0 1 2 3 4 5 6 7 8 9 [INFO] [stderr] 900 | | 10 11 12 13 14 15 16 17 18 19 [INFO] [stderr] 901 | | 20 21 22 23 24 25 26 27 28 29 [INFO] [stderr] 902 | | 30 31 32 [INFO] [stderr] 903 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:893:13 [INFO] [stderr] | [INFO] [stderr] 893 | fn ne(&self, other: &&'a [B; $N]) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 898 | / array_impls! { [INFO] [stderr] 899 | | 0 1 2 3 4 5 6 7 8 9 [INFO] [stderr] 900 | | 10 11 12 13 14 15 16 17 18 19 [INFO] [stderr] 901 | | 20 21 22 23 24 25 26 27 28 29 [INFO] [stderr] 902 | | 30 31 32 [INFO] [stderr] 903 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:978:32 [INFO] [stderr] | [INFO] [stderr] 978 | Some(ptr::read(self.vec.data_raw().offset(old_start as isize))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.vec.data_raw().add(old_start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:1050:29 [INFO] [stderr] | [INFO] [stderr] 1050 | let start = vec.data_raw().offset(old_len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.data_raw().add(old_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:1051:27 [INFO] [stderr] | [INFO] [stderr] 1051 | let end = vec.data_raw().offset(self.end as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.data_raw().add(self.end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `thin-vec`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | ptr.offset(header_size as isize) as *mut T [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(header_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut Header`) [INFO] [stderr] --> src/lib.rs:162:22 [INFO] [stderr] | [INFO] [stderr] 162 | let header = heap::allocate( [INFO] [stderr] | ______________________^ [INFO] [stderr] 163 | | alloc_size::(cap), [INFO] [stderr] 164 | | alloc_align::(), [INFO] [stderr] 165 | | ) as *mut Header; [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:285:24 [INFO] [stderr] | [INFO] [stderr] 285 | ptr::write(self.data_raw().offset(old_len as isize), val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_raw().add(old_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:309:23 [INFO] [stderr] | [INFO] [stderr] 309 | ptr::copy(ptr.offset(idx as isize), ptr.offset(idx as isize + 1), old_len - idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:310:24 [INFO] [stderr] | [INFO] [stderr] 310 | ptr::write(ptr.offset(idx as isize), elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:323:33 [INFO] [stderr] | [INFO] [stderr] 323 | let val = ptr::read(self.data_raw().offset(idx as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_raw().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:324:53 [INFO] [stderr] | [INFO] [stderr] 324 | ptr::copy(ptr.offset(idx as isize + 1), ptr.offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:337:23 [INFO] [stderr] | [INFO] [stderr] 337 | ptr::swap(ptr.offset(idx as isize), ptr.offset(old_len as isize - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:361:16 [INFO] [stderr] | [INFO] [stderr] 361 | if self.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:583:27 [INFO] [stderr] | [INFO] [stderr] 583 | let p_r = p.offset(r as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `p.add(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:584:29 [INFO] [stderr] | [INFO] [stderr] 584 | let p_wm1 = p.offset((w - 1) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add((w - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:608:38 [INFO] [stderr] | [INFO] [stderr] 608 | ptr::copy_nonoverlapping(self.data_raw().offset(at as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_raw().add(at)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:654:17 [INFO] [stderr] | [INFO] [stderr] 654 | self.data_raw().offset(start as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_raw().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut Header`) [INFO] [stderr] --> src/lib.rs:681:23 [INFO] [stderr] | [INFO] [stderr] 681 | let ptr = heap::reallocate(self.ptr() as *mut u8, [INFO] [stderr] | _______________________^ [INFO] [stderr] 682 | | alloc_size::(old_cap), [INFO] [stderr] 683 | | alloc_size::(new_cap), [INFO] [stderr] 684 | | alloc_align::()) as *mut Header; [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:856:5 [INFO] [stderr] | [INFO] [stderr] 856 | fn ne(&self, other: &ThinVec) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:863:5 [INFO] [stderr] | [INFO] [stderr] 863 | fn ne(&self, other: &Vec) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:870:5 [INFO] [stderr] | [INFO] [stderr] 870 | fn ne(&self, other: &[B]) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:877:5 [INFO] [stderr] | [INFO] [stderr] 877 | fn ne(&self, other: &&'a [B]) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:886:13 [INFO] [stderr] | [INFO] [stderr] 886 | fn ne(&self, other: &[B; $N]) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 898 | / array_impls! { [INFO] [stderr] 899 | | 0 1 2 3 4 5 6 7 8 9 [INFO] [stderr] 900 | | 10 11 12 13 14 15 16 17 18 19 [INFO] [stderr] 901 | | 20 21 22 23 24 25 26 27 28 29 [INFO] [stderr] 902 | | 30 31 32 [INFO] [stderr] 903 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:893:13 [INFO] [stderr] | [INFO] [stderr] 893 | fn ne(&self, other: &&'a [B; $N]) -> bool { self[..] != other[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 898 | / array_impls! { [INFO] [stderr] 899 | | 0 1 2 3 4 5 6 7 8 9 [INFO] [stderr] 900 | | 10 11 12 13 14 15 16 17 18 19 [INFO] [stderr] 901 | | 20 21 22 23 24 25 26 27 28 29 [INFO] [stderr] 902 | | 30 31 32 [INFO] [stderr] 903 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:978:32 [INFO] [stderr] | [INFO] [stderr] 978 | Some(ptr::read(self.vec.data_raw().offset(old_start as isize))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.vec.data_raw().add(old_start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:1050:29 [INFO] [stderr] | [INFO] [stderr] 1050 | let start = vec.data_raw().offset(old_len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.data_raw().add(old_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:1051:27 [INFO] [stderr] | [INFO] [stderr] 1051 | let end = vec.data_raw().offset(self.end as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.data_raw().add(self.end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:1153:23 [INFO] [stderr] | [INFO] [stderr] 1153 | vec2.push(i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1153 | vec2.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:1368:25 [INFO] [stderr] | [INFO] [stderr] 1368 | assert!(&left[..left.len()] == &[1, 2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1368 | assert!(left[..left.len()] == [1, 2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:1376:25 [INFO] [stderr] | [INFO] [stderr] 1376 | assert!(&right[..right.len()] == &[3, 4, 5]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1376 | assert!(right[..right.len()] == [3, 4, 5]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:1597:9 [INFO] [stderr] | [INFO] [stderr] 1597 | &x[!0..]; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x;!0..;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:1604:9 [INFO] [stderr] | [INFO] [stderr] 1604 | &x[..6]; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `x;..6;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:1611:9 [INFO] [stderr] | [INFO] [stderr] 1611 | &x[!0..4]; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x;!0..4;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:1618:9 [INFO] [stderr] | [INFO] [stderr] 1618 | &x[1..6]; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x;1..6;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:1625:9 [INFO] [stderr] | [INFO] [stderr] 1625 | &x[3..2]; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x;3..2;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:1660:23 [INFO] [stderr] | [INFO] [stderr] 1660 | vec2.push(i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1660 | vec2.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:1692:23 [INFO] [stderr] | [INFO] [stderr] 1692 | vec2.push(i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1692 | vec2.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `thin-vec`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a9f67f637253ef8b0aa4be8c46f238554a5a1888ba2bc69d111d404fbd041579"` [INFO] running `"docker" "rm" "-f" "a9f67f637253ef8b0aa4be8c46f238554a5a1888ba2bc69d111d404fbd041579"` [INFO] [stdout] a9f67f637253ef8b0aa4be8c46f238554a5a1888ba2bc69d111d404fbd041579