[INFO] crate thin-slice 0.1.1 is already in cache [INFO] extracting crate thin-slice 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/thin-slice/0.1.1 [INFO] extracting crate thin-slice 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thin-slice/0.1.1 [INFO] validating manifest of thin-slice-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thin-slice-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thin-slice-0.1.1 [INFO] finished frobbing thin-slice-0.1.1 [INFO] frobbed toml for thin-slice-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/thin-slice/0.1.1/Cargo.toml [INFO] started frobbing thin-slice-0.1.1 [INFO] finished frobbing thin-slice-0.1.1 [INFO] frobbed toml for thin-slice-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thin-slice/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thin-slice-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/thin-slice/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db2fa153fe0f2f7b2b81d8e41aa6b123021c091269967c102fee8a16e099139b [INFO] running `"docker" "start" "-a" "db2fa153fe0f2f7b2b81d8e41aa6b123021c091269967c102fee8a16e099139b"` [INFO] [stderr] Checking thin-slice v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | const TAG_MASK: usize = 0xffff000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | const PTR_MASK: usize = 0x0000ffffffffffff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | const PTR_HIGH: usize = 0x0000800000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_8000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn into_raw(b: ThinBoxedSlice) -> *mut [T] { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:195:28 [INFO] [stderr] | [INFO] [stderr] 195 | Storage::from_data(self.data.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:351:23 [INFO] [stderr] | [INFO] [stderr] 351 | data: self.data.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:466:5 [INFO] [stderr] | [INFO] [stderr] 466 | / fn ne(&self, other: &ThinBoxedSlice) -> bool { [INFO] [stderr] 467 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 468 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | const TAG_MASK: usize = 0xffff000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | const PTR_MASK: usize = 0x0000ffffffffffff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | const PTR_HIGH: usize = 0x0000800000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_8000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:543:33 [INFO] [stderr] | [INFO] [stderr] 543 | assert_eq!(static_ref[123], 456000); [INFO] [stderr] | ^^^^^^ help: consider: `456_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn into_raw(b: ThinBoxedSlice) -> *mut [T] { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:195:28 [INFO] [stderr] | [INFO] [stderr] 195 | Storage::from_data(self.data.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:351:23 [INFO] [stderr] | [INFO] [stderr] 351 | data: self.data.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:466:5 [INFO] [stderr] | [INFO] [stderr] 466 | / fn ne(&self, other: &ThinBoxedSlice) -> bool { [INFO] [stderr] 467 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 468 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "db2fa153fe0f2f7b2b81d8e41aa6b123021c091269967c102fee8a16e099139b"` [INFO] running `"docker" "rm" "-f" "db2fa153fe0f2f7b2b81d8e41aa6b123021c091269967c102fee8a16e099139b"` [INFO] [stdout] db2fa153fe0f2f7b2b81d8e41aa6b123021c091269967c102fee8a16e099139b