[INFO] crate thieves-cant 1.0.1 is already in cache [INFO] extracting crate thieves-cant 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/thieves-cant/1.0.1 [INFO] extracting crate thieves-cant 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thieves-cant/1.0.1 [INFO] validating manifest of thieves-cant-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thieves-cant-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thieves-cant-1.0.1 [INFO] finished frobbing thieves-cant-1.0.1 [INFO] frobbed toml for thieves-cant-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/thieves-cant/1.0.1/Cargo.toml [INFO] started frobbing thieves-cant-1.0.1 [INFO] finished frobbing thieves-cant-1.0.1 [INFO] frobbed toml for thieves-cant-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thieves-cant/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thieves-cant-1.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/thieves-cant/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b70d92a3cabb7facb79f2674d17e4e7dc11c4551feb8d37502e9cb94d245c91 [INFO] running `"docker" "start" "-a" "6b70d92a3cabb7facb79f2674d17e4e7dc11c4551feb8d37502e9cb94d245c91"` [INFO] [stderr] Checking thieves-cant v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/deck.rs:25:48 [INFO] [stderr] | [INFO] [stderr] 25 | let mut cards: Vec = (1..55).map(|value| Card::from(value)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Card::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/deck.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | self.cards[first_joker_idx..second_joker_idx + 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `first_joker_idx..=second_joker_idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/deck.rs:367:23 [INFO] [stderr] | [INFO] [stderr] 367 | let display = match self { [INFO] [stderr] | _______________________^ [INFO] [stderr] 368 | | &CardValue::JokerA => "Joker A".to_owned(), [INFO] [stderr] 369 | | &CardValue::JokerB => "Joker B".to_owned(), [INFO] [stderr] 370 | | _ => format!("{:?}", self), [INFO] [stderr] 371 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 367 | let display = match *self { [INFO] [stderr] 368 | CardValue::JokerA => "Joker A".to_owned(), [INFO] [stderr] 369 | CardValue::JokerB => "Joker B".to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pontifex.rs:78:8 [INFO] [stderr] | [INFO] [stderr] 78 | if string.len() > 0 && string.len() % 5 != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/deck.rs:25:48 [INFO] [stderr] | [INFO] [stderr] 25 | let mut cards: Vec = (1..55).map(|value| Card::from(value)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Card::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/deck.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | self.cards[first_joker_idx..second_joker_idx + 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `first_joker_idx..=second_joker_idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/deck.rs:367:23 [INFO] [stderr] | [INFO] [stderr] 367 | let display = match self { [INFO] [stderr] | _______________________^ [INFO] [stderr] 368 | | &CardValue::JokerA => "Joker A".to_owned(), [INFO] [stderr] 369 | | &CardValue::JokerB => "Joker B".to_owned(), [INFO] [stderr] 370 | | _ => format!("{:?}", self), [INFO] [stderr] 371 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 367 | let display = match *self { [INFO] [stderr] 368 | CardValue::JokerA => "Joker A".to_owned(), [INFO] [stderr] 369 | CardValue::JokerB => "Joker B".to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pontifex.rs:78:8 [INFO] [stderr] | [INFO] [stderr] 78 | if string.len() > 0 && string.len() % 5 != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.64s [INFO] running `"docker" "inspect" "6b70d92a3cabb7facb79f2674d17e4e7dc11c4551feb8d37502e9cb94d245c91"` [INFO] running `"docker" "rm" "-f" "6b70d92a3cabb7facb79f2674d17e4e7dc11c4551feb8d37502e9cb94d245c91"` [INFO] [stdout] 6b70d92a3cabb7facb79f2674d17e4e7dc11c4551feb8d37502e9cb94d245c91