[INFO] crate thex 0.1.0 is already in cache
[INFO] extracting crate thex 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/thex/0.1.0
[INFO] extracting crate thex 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thex/0.1.0
[INFO] validating manifest of thex-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of thex-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing thex-0.1.0
[INFO] finished frobbing thex-0.1.0
[INFO] frobbed toml for thex-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/thex/0.1.0/Cargo.toml
[INFO] started frobbing thex-0.1.0
[INFO] finished frobbing thex-0.1.0
[INFO] frobbed toml for thex-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thex/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting thex-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/thex/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d97efb10d58d7d51df3b2558ded38735193fa856eda751d0afe9ab5d7b2693dd
[INFO] running `"docker" "start" "-a" "d97efb10d58d7d51df3b2558ded38735193fa856eda751d0afe9ab5d7b2693dd"`
[INFO] [stderr]     Checking parking_lot_core v0.2.14
[INFO] [stderr]     Checking parking_lot v0.5.5
[INFO] [stderr]     Checking thex v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         return Shared {
[INFO] [stderr] 142 | |             value: t_ref,
[INFO] [stderr] 143 | |             _guard: write.downgrade(),
[INFO] [stderr] 144 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 141 |         Shared {
[INFO] [stderr] 142 |             value: t_ref,
[INFO] [stderr] 143 |             _guard: write.downgrade(),
[INFO] [stderr] 144 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         return Shared {
[INFO] [stderr] 142 | |             value: t_ref,
[INFO] [stderr] 143 | |             _guard: write.downgrade(),
[INFO] [stderr] 144 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 141 |         Shared {
[INFO] [stderr] 142 |             value: t_ref,
[INFO] [stderr] 143 |             _guard: write.downgrade(),
[INFO] [stderr] 144 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `locks`.
[INFO] [stderr]   --> src/lib.rs:33:18
[INFO] [stderr]    |
[INFO] [stderr] 33 |         for i in 0..N_LOCKS {
[INFO] [stderr]    |                  ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 33 |         for <item> in locks.iter_mut().take(N_LOCKS) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 | /             match *read {
[INFO] [stderr] 128 | |                 State::Shared => {
[INFO] [stderr] 129 | |                     return Shared {
[INFO] [stderr] 130 | |                         value: t_ref,
[INFO] [stderr] ...   |
[INFO] [stderr] 134 | |                 _ => (),
[INFO] [stderr] 135 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 127 |             if let State::Shared = *read {
[INFO] [stderr] 128 |     return Shared {
[INFO] [stderr] 129 |         value: t_ref,
[INFO] [stderr] 130 |         _guard: read,
[INFO] [stderr] 131 |     }
[INFO] [stderr] 132 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/lib.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 | /         loop {
[INFO] [stderr] 157 | |             let t_ref = self.cell.get() as *mut T;
[INFO] [stderr] 158 | |             let lock = lock_nr(t_ref);
[INFO] [stderr] 159 | |             {
[INFO] [stderr] ...   |
[INFO] [stderr] 188 | |             };
[INFO] [stderr] 189 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:162:17
[INFO] [stderr]     |
[INFO] [stderr] 162 | /                 match *read {
[INFO] [stderr] 163 | |                     State::ThreadExclusive(ref thread_id) => {
[INFO] [stderr] 164 | |                         if thread_id == &thread::current().id() {
[INFO] [stderr] 165 | |                             exclusive = true;
[INFO] [stderr] ...   |
[INFO] [stderr] 168 | |                     _ => (),
[INFO] [stderr] 169 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 162 |                 if let State::ThreadExclusive(ref thread_id) = *read {
[INFO] [stderr] 163 |     if thread_id == &thread::current().id() {
[INFO] [stderr] 164 |         exclusive = true;
[INFO] [stderr] 165 |     }
[INFO] [stderr] 166 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `thex`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: the loop variable `i` is only used to index `locks`.
[INFO] [stderr]   --> src/lib.rs:33:18
[INFO] [stderr]    |
[INFO] [stderr] 33 |         for i in 0..N_LOCKS {
[INFO] [stderr]    |                  ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 33 |         for <item> in locks.iter_mut().take(N_LOCKS) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 | /             match *read {
[INFO] [stderr] 128 | |                 State::Shared => {
[INFO] [stderr] 129 | |                     return Shared {
[INFO] [stderr] 130 | |                         value: t_ref,
[INFO] [stderr] ...   |
[INFO] [stderr] 134 | |                 _ => (),
[INFO] [stderr] 135 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 127 |             if let State::Shared = *read {
[INFO] [stderr] 128 |     return Shared {
[INFO] [stderr] 129 |         value: t_ref,
[INFO] [stderr] 130 |         _guard: read,
[INFO] [stderr] 131 |     }
[INFO] [stderr] 132 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/lib.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 | /         loop {
[INFO] [stderr] 157 | |             let t_ref = self.cell.get() as *mut T;
[INFO] [stderr] 158 | |             let lock = lock_nr(t_ref);
[INFO] [stderr] 159 | |             {
[INFO] [stderr] ...   |
[INFO] [stderr] 188 | |             };
[INFO] [stderr] 189 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:162:17
[INFO] [stderr]     |
[INFO] [stderr] 162 | /                 match *read {
[INFO] [stderr] 163 | |                     State::ThreadExclusive(ref thread_id) => {
[INFO] [stderr] 164 | |                         if thread_id == &thread::current().id() {
[INFO] [stderr] 165 | |                             exclusive = true;
[INFO] [stderr] ...   |
[INFO] [stderr] 168 | |                     _ => (),
[INFO] [stderr] 169 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 162 |                 if let State::ThreadExclusive(ref thread_id) = *read {
[INFO] [stderr] 163 |     if thread_id == &thread::current().id() {
[INFO] [stderr] 164 |         exclusive = true;
[INFO] [stderr] 165 |     }
[INFO] [stderr] 166 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `thex`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "d97efb10d58d7d51df3b2558ded38735193fa856eda751d0afe9ab5d7b2693dd"`
[INFO] running `"docker" "rm" "-f" "d97efb10d58d7d51df3b2558ded38735193fa856eda751d0afe9ab5d7b2693dd"`
[INFO] [stdout] d97efb10d58d7d51df3b2558ded38735193fa856eda751d0afe9ab5d7b2693dd