[INFO] crate theca 1.0.0 is already in cache
[INFO] extracting crate theca 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/theca/1.0.0
[INFO] extracting crate theca 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/theca/1.0.0
[INFO] validating manifest of theca-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of theca-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing theca-1.0.0
[INFO] finished frobbing theca-1.0.0
[INFO] frobbed toml for theca-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/theca/1.0.0/Cargo.toml
[INFO] started frobbing theca-1.0.0
[INFO] finished frobbing theca-1.0.0
[INFO] frobbed toml for theca-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/theca/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting theca-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/theca/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0c1d375f171fd70b03a9b1b6d22c7dbd3e3ff80dc8fbb2ab77eb2c72fcb6c235
[INFO] running `"docker" "start" "-a" "0c1d375f171fd70b03a9b1b6d22c7dbd3e3ff80dc8fbb2ab77eb2c72fcb6c235"`
[INFO] [stderr]     Checking docopt v0.6.86
[INFO] [stderr]     Checking theca v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/theca/errors.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/theca/lineformat.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             colsep: colsep,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `colsep`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/theca/lib.rs:296:13
[INFO] [stderr]     |
[INFO] [stderr] 296 |             encrypted: encrypted,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encrypted`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/theca/lib.rs:534:13
[INFO] [stderr]     |
[INFO] [stderr] 534 |             title: title,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/theca/lib.rs:536:13
[INFO] [stderr]     |
[INFO] [stderr] 536 |             body: body,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/theca/errors.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/theca/lineformat.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             colsep: colsep,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `colsep`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/theca/lib.rs:296:13
[INFO] [stderr]     |
[INFO] [stderr] 296 |             encrypted: encrypted,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encrypted`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/theca/lib.rs:534:13
[INFO] [stderr]     |
[INFO] [stderr] 534 |             title: title,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/theca/lib.rs:536:13
[INFO] [stderr]     |
[INFO] [stderr] 536 |             body: body,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/theca/utils.rs:17:21
[INFO] [stderr]    |
[INFO] [stderr] 17 | use std::env::{var, home_dir};
[INFO] [stderr]    |                     ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/theca/utils.rs:362:15
[INFO] [stderr]     |
[INFO] [stderr] 362 |         match home_dir() {
[INFO] [stderr]     |               ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/theca/utils.rs:17:21
[INFO] [stderr]    |
[INFO] [stderr] 17 | use std::env::{var, home_dir};
[INFO] [stderr]    |                     ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/theca/utils.rs:362:15
[INFO] [stderr]     |
[INFO] [stderr] 362 |         match home_dir() {
[INFO] [stderr]     |               ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/theca/utils.rs:223:31
[INFO] [stderr]     |
[INFO] [stderr] 223 |         if yes.iter().any(|n| &n[..] == input) {
[INFO] [stderr]     |                               ------^^^^^^^^^
[INFO] [stderr]     |                               |
[INFO] [stderr]     |                               help: use the left value directly: `n[..]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/theca/utils.rs:226:37
[INFO] [stderr]     |
[INFO] [stderr] 226 |         } else if no.iter().any(|n| &n[..] == input) {
[INFO] [stderr]     |                                     ------^^^^^^^^^
[INFO] [stderr]     |                                     |
[INFO] [stderr]     |                                     help: use the left value directly: `n[..]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/theca/lib.rs:368:62
[INFO] [stderr]     |
[INFO] [stderr] 368 |     pub fn save_to_file(&mut self, args: &Args, fingerprint: &u64) -> Result<()> {
[INFO] [stderr]     |                                                              ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/theca/lib.rs:387:12
[INFO] [stderr]     |
[INFO] [stderr] 387 |         if fingerprint > &0u64 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^-----
[INFO] [stderr]     |                          |
[INFO] [stderr]     |                          help: use the right value directly: `0u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/theca/lib.rs:466:25
[INFO] [stderr]     |
[INFO] [stderr] 466 |                  .map(|n| {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 467 | |                    trans_profile.add_note(&n.title,
[INFO] [stderr] 468 | |                                           &[n.body.clone()],
[INFO] [stderr] 469 | |                                           Some(n.status),
[INFO] [stderr] ...   |
[INFO] [stderr] 472 | |                                           false)
[INFO] [stderr] 473 | |                })
[INFO] [stderr]     | |________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/theca/lib.rs:834:80
[INFO] [stderr]     |
[INFO] [stderr] 834 | pub fn parse_cmds(profile: &mut Profile, args: &mut Args, profile_fingerprint: &u64) -> Result<()> {
[INFO] [stderr]     |                                                                                ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/theca/utils.rs:223:31
[INFO] [stderr]     |
[INFO] [stderr] 223 |         if yes.iter().any(|n| &n[..] == input) {
[INFO] [stderr]     |                               ------^^^^^^^^^
[INFO] [stderr]     |                               |
[INFO] [stderr]     |                               help: use the left value directly: `n[..]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/theca/utils.rs:226:37
[INFO] [stderr]     |
[INFO] [stderr] 226 |         } else if no.iter().any(|n| &n[..] == input) {
[INFO] [stderr]     |                                     ------^^^^^^^^^
[INFO] [stderr]     |                                     |
[INFO] [stderr]     |                                     help: use the left value directly: `n[..]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/theca/lib.rs:368:62
[INFO] [stderr]     |
[INFO] [stderr] 368 |     pub fn save_to_file(&mut self, args: &Args, fingerprint: &u64) -> Result<()> {
[INFO] [stderr]     |                                                              ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/theca/lib.rs:387:12
[INFO] [stderr]     |
[INFO] [stderr] 387 |         if fingerprint > &0u64 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^-----
[INFO] [stderr]     |                          |
[INFO] [stderr]     |                          help: use the right value directly: `0u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/theca/lib.rs:466:25
[INFO] [stderr]     |
[INFO] [stderr] 466 |                  .map(|n| {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 467 | |                    trans_profile.add_note(&n.title,
[INFO] [stderr] 468 | |                                           &[n.body.clone()],
[INFO] [stderr] 469 | |                                           Some(n.status),
[INFO] [stderr] ...   |
[INFO] [stderr] 472 | |                                           false)
[INFO] [stderr] 473 | |                })
[INFO] [stderr]     | |________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/theca/lib.rs:834:80
[INFO] [stderr]     |
[INFO] [stderr] 834 | pub fn parse_cmds(profile: &mut Profile, args: &mut Args, profile_fingerprint: &u64) -> Result<()> {
[INFO] [stderr]     |                                                                                ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.64s
[INFO] running `"docker" "inspect" "0c1d375f171fd70b03a9b1b6d22c7dbd3e3ff80dc8fbb2ab77eb2c72fcb6c235"`
[INFO] running `"docker" "rm" "-f" "0c1d375f171fd70b03a9b1b6d22c7dbd3e3ff80dc8fbb2ab77eb2c72fcb6c235"`
[INFO] [stdout] 0c1d375f171fd70b03a9b1b6d22c7dbd3e3ff80dc8fbb2ab77eb2c72fcb6c235