[INFO] crate theban_db 0.7.0 is already in cache [INFO] extracting crate theban_db 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/theban_db/0.7.0 [INFO] extracting crate theban_db 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/theban_db/0.7.0 [INFO] validating manifest of theban_db-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of theban_db-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing theban_db-0.7.0 [INFO] finished frobbing theban_db-0.7.0 [INFO] frobbed toml for theban_db-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/theban_db/0.7.0/Cargo.toml [INFO] started frobbing theban_db-0.7.0 [INFO] finished frobbing theban_db-0.7.0 [INFO] frobbed toml for theban_db-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/theban_db/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting theban_db-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/theban_db/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afaefa2262d2c4d584489e63dbeaa71310290025265760e23c970888dc9677b2 [INFO] running `"docker" "start" "-a" "afaefa2262d2c4d584489e63dbeaa71310290025265760e23c970888dc9677b2"` [INFO] [stderr] Checking theban_interval_tree v0.7.1 [INFO] [stderr] Checking theban_db v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | return DB { obj_map: obj_map, bit_map: bit_map }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `obj_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | return DB { obj_map: obj_map, bit_map: bit_map }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/content.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | return Object{data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/content.rs:44:39 [INFO] [stderr] | [INFO] [stderr] 44 | return Bitmap{entry_size: es, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iterator.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | return BitmapSliceIter{orig: orig, orig_rng: rng}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `orig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | return DB { obj_map: obj_map, bit_map: bit_map }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `obj_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | return DB { obj_map: obj_map, bit_map: bit_map }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/content.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | return Object{data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/content.rs:44:39 [INFO] [stderr] | [INFO] [stderr] 44 | return Bitmap{entry_size: es, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iterator.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | return BitmapSliceIter{orig: orig, orig_rng: rng}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `orig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return DB { obj_map: BTreeMap::new(), bit_map: BTreeMap::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DB { obj_map: BTreeMap::new(), bit_map: BTreeMap::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return DB { obj_map: obj_map, bit_map: bit_map }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DB { obj_map: obj_map, bit_map: bit_map }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return self.obj_map.get(table).map(|tree| tree.range(r.min, r.max)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.obj_map.get(table).map(|tree| tree.range(r.min, r.max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return self.bit_map.get(table).map(|tree| BitmapSliceIter::new(tree.range(r.min, r.max), r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bit_map.get(table).map(|tree| BitmapSliceIter::new(tree.range(r.min, r.max), r))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return self.obj_map.contains_key(table); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.obj_map.contains_key(table)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | / return db.query_bitmap(&tbl, rng) [INFO] [stderr] 173 | | .unwrap() [INFO] [stderr] 174 | | .map(|(r, data)| (r.clone(), data.to_bitmap()) ) [INFO] [stderr] 175 | | .collect::>(); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 172 | db.query_bitmap(&tbl, rng) [INFO] [stderr] 173 | .unwrap() [INFO] [stderr] 174 | .map(|(r, data)| (r.clone(), data.to_bitmap()) ) [INFO] [stderr] 175 | .collect::>() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/serialize/mod.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError>; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/serialize/mod.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | fn read<'a>(mut r: &mut Read) -> Result; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return Ok(strval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(strval)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(Range::new(min, max)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Range::new(min, max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok( data ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( data )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Ok( data ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( data )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return Ok( tree ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( tree )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return Ok( res ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( res )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | return Ok( DB::new_from_data(objects,bitmaps) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( DB::new_from_data(objects,bitmaps) )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return Ok(db); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(db)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | return Ok(db); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(db)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Bitmap{entry_size: self.entry_size, data: (*self.data).into()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bitmap{entry_size: self.entry_size, data: (*self.data).into()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return BitmapSlice{entry_size: b.entry_size, data: Cow::Owned(b.data.into())} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitmapSlice{entry_size: b.entry_size, data: Cow::Owned(b.data.into())}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return BitmapSlice{entry_size: b.entry_size, data: Cow::Borrowed(&b.data)} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitmapSlice{entry_size: b.entry_size, data: Cow::Borrowed(&b.data)}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return Object{data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Object{data: data}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return Bitmap{entry_size: es, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bitmap{entry_size: es, data: data}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return BitmapSlice{entry_size: self.entry_size, data: Cow::Borrowed(slice)} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitmapSlice{entry_size: self.entry_size, data: Cow::Borrowed(slice)}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Bitmap{entry_size: self.entry_size, data: slice.to_vec()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bitmap{entry_size: self.entry_size, data: slice.to_vec()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return (new_range, Bitmap::new(self.entry_size, combined)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(new_range, Bitmap::new(self.entry_size, combined))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db_iterator.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return BitmapSliceIter{orig: orig, orig_rng: rng}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitmapSliceIter{orig: orig, orig_rng: rng}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db_iterator.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.orig_rng; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.orig_rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db_iterator.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return DB { obj_map: BTreeMap::new(), bit_map: BTreeMap::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DB { obj_map: BTreeMap::new(), bit_map: BTreeMap::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return DB { obj_map: obj_map, bit_map: bit_map }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DB { obj_map: obj_map, bit_map: bit_map }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return self.obj_map.get(table).map(|tree| tree.range(r.min, r.max)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.obj_map.get(table).map(|tree| tree.range(r.min, r.max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return self.bit_map.get(table).map(|tree| BitmapSliceIter::new(tree.range(r.min, r.max), r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bit_map.get(table).map(|tree| BitmapSliceIter::new(tree.range(r.min, r.max), r))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return self.obj_map.contains_key(table); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.obj_map.contains_key(table)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/serialize/mod.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError>; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/serialize/mod.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | fn read<'a>(mut r: &mut Read) -> Result; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return Ok(strval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(strval)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(Range::new(min, max)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Range::new(min, max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok( data ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( data )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Ok( data ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( data )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return Ok( tree ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( tree )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return Ok( res ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( res )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | return Ok( DB::new_from_data(objects,bitmaps) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok( DB::new_from_data(objects,bitmaps) )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return Ok(db); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(db)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize/mod.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | return Ok(db); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(db)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Bitmap{entry_size: self.entry_size, data: (*self.data).into()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bitmap{entry_size: self.entry_size, data: (*self.data).into()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return BitmapSlice{entry_size: b.entry_size, data: Cow::Owned(b.data.into())} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitmapSlice{entry_size: b.entry_size, data: Cow::Owned(b.data.into())}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return BitmapSlice{entry_size: b.entry_size, data: Cow::Borrowed(&b.data)} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitmapSlice{entry_size: b.entry_size, data: Cow::Borrowed(&b.data)}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return Object{data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Object{data: data}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return Bitmap{entry_size: es, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bitmap{entry_size: es, data: data}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return BitmapSlice{entry_size: self.entry_size, data: Cow::Borrowed(slice)} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitmapSlice{entry_size: self.entry_size, data: Cow::Borrowed(slice)}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Bitmap{entry_size: self.entry_size, data: slice.to_vec()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bitmap{entry_size: self.entry_size, data: slice.to_vec()}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/content.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return (new_range, Bitmap::new(self.entry_size, combined)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(new_range, Bitmap::new(self.entry_size, combined))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db_iterator.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return BitmapSliceIter{orig: orig, orig_rng: rng}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitmapSliceIter{orig: orig, orig_rng: rng}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db_iterator.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.orig_rng; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.orig_rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db_iterator.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let mut tree = self.obj_map.get_mut(table).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(mut tree) = self.obj_map.get_mut(table) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:78:46 [INFO] [stderr] | [INFO] [stderr] 78 | self.bit_map.get_mut(table).map(|mut tree| { tree.delete(rng) }); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | let mut tree = self.bit_map.get_mut(table).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut tree = self.bit_map.get_mut(table).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `db::DB` [INFO] [stderr] --> src/db.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> DB { [INFO] [stderr] 22 | | return DB { obj_map: BTreeMap::new(), bit_map: BTreeMap::new() }; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:29:44 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn insert_object(&mut self, table: &String, r: Range, d: Object) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:35:39 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn query_object(&self, table: &String, r: Range) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:39:46 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn query_bitmap<'a>(&'a self, table: &String, r: Range) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn delete_object(&mut self, table: &String, r: Range) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:49:58 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn delete_intersecting_objects(&mut self, table: &String, r: Range) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let mut tree = self.obj_map.get_mut(table).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/db.rs:51:35 [INFO] [stderr] | [INFO] [stderr] 51 | iter.map(|(range, _)| range.clone()).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:61:38 [INFO] [stderr] | [INFO] [stderr] 61 | table: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(mut tree) = self.obj_map.get_mut(table) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:76:51 [INFO] [stderr] | [INFO] [stderr] 76 | fn delete_bitmaps_from_tree(&mut self, table: &String, bitmaps: &Vec<(Range, Bitmap)>) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/db.rs:76:69 [INFO] [stderr] | [INFO] [stderr] 76 | fn delete_bitmaps_from_tree(&mut self, table: &String, bitmaps: &Vec<(Range, Bitmap)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Range, Bitmap)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/db.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | self.bit_map.get_mut(table).map(|mut tree| { tree.delete(rng) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(mut tree) = self.bit_map.get_mut(table) { tree.delete(rng) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:82:44 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn insert_bitmap(&mut self, table: &String, r: Range, d: Bitmap) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:96:38 [INFO] [stderr] | [INFO] [stderr] 96 | table: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:107:47 [INFO] [stderr] | [INFO] [stderr] 107 | table: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:121:44 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn delete_bitmap(&mut self, table: &String,entry_size: u64, range_to_remove: Range) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | fn add_table(&mut self, table: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn has_table(& self, table: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/db.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | .map(|(r, _)| r.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/db.rs:163:26 [INFO] [stderr] | [INFO] [stderr] 163 | .map(|(r, _)| r.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:171:40 [INFO] [stderr] | [INFO] [stderr] 171 | fn query_bitmap_test(db: &mut DB, tbl: &String, rng: Range) -> Vec<(Range,Bitmap)>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/db.rs:174:38 [INFO] [stderr] | [INFO] [stderr] 174 | .map(|(r, data)| (r.clone(), data.to_bitmap()) ) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:78:46 [INFO] [stderr] | [INFO] [stderr] 78 | self.bit_map.get_mut(table).map(|mut tree| { tree.delete(rng) }); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | let mut tree = self.bit_map.get_mut(table).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/db.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut tree = self.bit_map.get_mut(table).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError>; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | fn read<'a>(mut r: &mut Read) -> Result; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/serialize/mod.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | fn write_vec<'a>(vec: &Vec, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | fn write_vec<'a>(vec: &Vec, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | fn parse_string<'a>(stream: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | fn parse_bindata<'a>(mut stream: &mut Read) -> Result, DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | fn parse_range<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serialize/mod.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | assert!(3*len < u32::MAX as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:116:14 [INFO] [stderr] | [INFO] [stderr] 116 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:139:14 [INFO] [stderr] | [INFO] [stderr] 139 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn serialize<'a>(&self) -> Result, DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:166:24 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn deserialize<'a>(buf: Vec) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/serialize/mod.rs:172:46 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn save_to_file<'a>(&self, filename: &String) -> Result<(), DBError> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:172:25 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn save_to_file<'a>(&self, filename: &String) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/serialize/mod.rs:179:40 [INFO] [stderr] | [INFO] [stderr] 179 | pub fn new_from_file<'a>(filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:179:26 [INFO] [stderr] | [INFO] [stderr] 179 | pub fn new_from_file<'a>(filename: &String) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/serialize/mod.rs:206:37 [INFO] [stderr] | [INFO] [stderr] 206 | .map(|(r, _)| r.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/serialize/mod.rs:210:36 [INFO] [stderr] | [INFO] [stderr] 210 | .map(|(r, _)| r.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/content.rs:26:71 [INFO] [stderr] | [INFO] [stderr] 26 | return BitmapSlice{entry_size: b.entry_size, data: Cow::Owned(b.data.into())} [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `b.data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/content.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new_from_borrowed<'db>(b: &'db Bitmap) -> BitmapSlice<'db>{ [INFO] [stderr] 30 | | return BitmapSlice{entry_size: b.entry_size, data: Cow::Borrowed(&b.data)} [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/content.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | let mut new_range = data_range.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `data_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/content.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 83 | let mut combined = Vec::with_capacity(combined_len); [INFO] [stderr] | -------------------------------- help: consider replace allocation with: `vec![0; combined_len]` [INFO] [stderr] 84 | combined.resize(combined_len, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `db::DB` [INFO] [stderr] --> src/db.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> DB { [INFO] [stderr] 22 | | return DB { obj_map: BTreeMap::new(), bit_map: BTreeMap::new() }; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:29:44 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn insert_object(&mut self, table: &String, r: Range, d: Object) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:35:39 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn query_object(&self, table: &String, r: Range) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:39:46 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn query_bitmap<'a>(&'a self, table: &String, r: Range) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn delete_object(&mut self, table: &String, r: Range) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:49:58 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn delete_intersecting_objects(&mut self, table: &String, r: Range) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/db.rs:51:35 [INFO] [stderr] | [INFO] [stderr] 51 | iter.map(|(range, _)| range.clone()).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:61:38 [INFO] [stderr] | [INFO] [stderr] 61 | table: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:76:51 [INFO] [stderr] | [INFO] [stderr] 76 | fn delete_bitmaps_from_tree(&mut self, table: &String, bitmaps: &Vec<(Range, Bitmap)>) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/db.rs:76:69 [INFO] [stderr] | [INFO] [stderr] 76 | fn delete_bitmaps_from_tree(&mut self, table: &String, bitmaps: &Vec<(Range, Bitmap)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Range, Bitmap)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/db.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | self.bit_map.get_mut(table).map(|mut tree| { tree.delete(rng) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(mut tree) = self.bit_map.get_mut(table) { tree.delete(rng) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:82:44 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn insert_bitmap(&mut self, table: &String, r: Range, d: Bitmap) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:96:38 [INFO] [stderr] | [INFO] [stderr] 96 | table: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:107:47 [INFO] [stderr] | [INFO] [stderr] 107 | table: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:121:44 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn delete_bitmap(&mut self, table: &String,entry_size: u64, range_to_remove: Range) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | fn add_table(&mut self, table: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/db.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn has_table(& self, table: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError>; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | fn read<'a>(mut r: &mut Read) -> Result; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/serialize/mod.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | fn write_vec<'a>(vec: &Vec, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | fn write_vec<'a>(vec: &Vec, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | fn parse_string<'a>(stream: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | fn parse_bindata<'a>(mut stream: &mut Read) -> Result, DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | fn parse_range<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serialize/mod.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | assert!(3*len < u32::MAX as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:116:14 [INFO] [stderr] | [INFO] [stderr] 116 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:139:14 [INFO] [stderr] | [INFO] [stderr] 139 | fn write<'a>(&self, mut w: &mut Write) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | fn read<'a>(mut r: &mut Read) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn serialize<'a>(&self) -> Result, DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:166:24 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn deserialize<'a>(buf: Vec) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/serialize/mod.rs:172:46 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn save_to_file<'a>(&self, filename: &String) -> Result<(), DBError> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:172:25 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn save_to_file<'a>(&self, filename: &String) -> Result<(), DBError> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/serialize/mod.rs:179:40 [INFO] [stderr] | [INFO] [stderr] 179 | pub fn new_from_file<'a>(filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/serialize/mod.rs:179:26 [INFO] [stderr] | [INFO] [stderr] 179 | pub fn new_from_file<'a>(filename: &String) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/content.rs:26:71 [INFO] [stderr] | [INFO] [stderr] 26 | return BitmapSlice{entry_size: b.entry_size, data: Cow::Owned(b.data.into())} [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `b.data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/content.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new_from_borrowed<'db>(b: &'db Bitmap) -> BitmapSlice<'db>{ [INFO] [stderr] 30 | | return BitmapSlice{entry_size: b.entry_size, data: Cow::Borrowed(&b.data)} [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/content.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | let mut new_range = data_range.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `data_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/content.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 83 | let mut combined = Vec::with_capacity(combined_len); [INFO] [stderr] | -------------------------------- help: consider replace allocation with: `vec![0; combined_len]` [INFO] [stderr] 84 | combined.resize(combined_len, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.90s [INFO] running `"docker" "inspect" "afaefa2262d2c4d584489e63dbeaa71310290025265760e23c970888dc9677b2"` [INFO] running `"docker" "rm" "-f" "afaefa2262d2c4d584489e63dbeaa71310290025265760e23c970888dc9677b2"` [INFO] [stdout] afaefa2262d2c4d584489e63dbeaa71310290025265760e23c970888dc9677b2