[INFO] crate tfe 0.1.2 is already in cache [INFO] extracting crate tfe 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/tfe/0.1.2 [INFO] extracting crate tfe 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tfe/0.1.2 [INFO] validating manifest of tfe-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tfe-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tfe-0.1.2 [INFO] finished frobbing tfe-0.1.2 [INFO] frobbed toml for tfe-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/tfe/0.1.2/Cargo.toml [INFO] started frobbing tfe-0.1.2 [INFO] finished frobbing tfe-0.1.2 [INFO] frobbed toml for tfe-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tfe/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tfe-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tfe/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 366843aa139a6d8ce463ef43831c8cc648a906f67a9536da4f57351b4589fde2 [INFO] running `"docker" "start" "-a" "366843aa139a6d8ce463ef43831c8cc648a906f67a9536da4f57351b4589fde2"` [INFO] [stderr] Checking tfe v0.1.2 (/opt/crater/workdir) [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lib.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/direction.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn without(dirs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Direction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/direction.rs:56:55 [INFO] [stderr] | [INFO] [stderr] 56 | filtered.retain(|dir| dirs.iter().all(|tried| &dir != &tried)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 56 | filtered.retain(|dir| dirs.iter().all(|tried| dir != tried)); [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/direction.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn sample_without(dirs: &Vec) -> Direction { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Direction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `row` [INFO] [stderr] --> src/game.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | (row >> 0) & 0xF, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `line`. [INFO] [stderr] --> src/game.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 0 .. 4 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for in &line { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line[0]` [INFO] [stderr] --> src/game.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | let result = (line[0] << 0) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / pub fn new() -> Self { [INFO] [stderr] 164 | | let mut game = Game { board: 0x0000_0000_0000_0000_u64 }; [INFO] [stderr] 165 | | [INFO] [stderr] 166 | | game.board |= Self::spawn_tile(game.board); [INFO] [stderr] ... | [INFO] [stderr] 169 | | game [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `MOVES.up[((transposed >> 0) & ROW_MASK) as usize]` [INFO] [stderr] --> src/game.rs:300:19 [INFO] [stderr] | [INFO] [stderr] 300 | result ^= MOVES.up[((transposed >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `transposed` [INFO] [stderr] --> src/game.rs:300:29 [INFO] [stderr] | [INFO] [stderr] 300 | result ^= MOVES.up[((transposed >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `MOVES.down[((transposed >> 0) & ROW_MASK) as usize]` [INFO] [stderr] --> src/game.rs:330:19 [INFO] [stderr] | [INFO] [stderr] 330 | result ^= MOVES.down[((transposed >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `transposed` [INFO] [stderr] --> src/game.rs:330:31 [INFO] [stderr] | [INFO] [stderr] 330 | result ^= MOVES.down[((transposed >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `MOVES.right[((board >> 0) & ROW_MASK) as usize]` [INFO] [stderr] --> src/game.rs:359:19 [INFO] [stderr] | [INFO] [stderr] 359 | result ^= MOVES.right[((board >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `board` [INFO] [stderr] --> src/game.rs:359:32 [INFO] [stderr] | [INFO] [stderr] 359 | result ^= MOVES.right[((board >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `MOVES.left[((board >> 0) & ROW_MASK) as usize]` [INFO] [stderr] --> src/game.rs:388:19 [INFO] [stderr] | [INFO] [stderr] 388 | result ^= MOVES.left[((board >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `board` [INFO] [stderr] --> src/game.rs:388:31 [INFO] [stderr] | [INFO] [stderr] 388 | result ^= MOVES.left[((board >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/game.rs:411:31 [INFO] [stderr] | [INFO] [stderr] 411 | for i in 0 .. 16 { if ((board >> (i * 4)) & 0xF) == 0 { empty += 1 } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((board >> (i * 4))).trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game.rs:417:44 [INFO] [stderr] | [INFO] [stderr] 417 | pub fn table_helper(board: u64, table: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `board` [INFO] [stderr] --> src/game.rs:418:16 [INFO] [stderr] | [INFO] [stderr] 418 | table[((board >> 0) & ROW_MASK) as usize] + [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tfe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lib.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/direction.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn without(dirs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Direction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/direction.rs:56:55 [INFO] [stderr] | [INFO] [stderr] 56 | filtered.retain(|dir| dirs.iter().all(|tried| &dir != &tried)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 56 | filtered.retain(|dir| dirs.iter().all(|tried| dir != tried)); [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/direction.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn sample_without(dirs: &Vec) -> Direction { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Direction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `row` [INFO] [stderr] --> src/game.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | (row >> 0) & 0xF, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `line`. [INFO] [stderr] --> src/game.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 0 .. 4 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for in &line { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line[0]` [INFO] [stderr] --> src/game.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | let result = (line[0] << 0) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / pub fn new() -> Self { [INFO] [stderr] 164 | | let mut game = Game { board: 0x0000_0000_0000_0000_u64 }; [INFO] [stderr] 165 | | [INFO] [stderr] 166 | | game.board |= Self::spawn_tile(game.board); [INFO] [stderr] ... | [INFO] [stderr] 169 | | game [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `MOVES.up[((transposed >> 0) & ROW_MASK) as usize]` [INFO] [stderr] --> src/game.rs:300:19 [INFO] [stderr] | [INFO] [stderr] 300 | result ^= MOVES.up[((transposed >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `transposed` [INFO] [stderr] --> src/game.rs:300:29 [INFO] [stderr] | [INFO] [stderr] 300 | result ^= MOVES.up[((transposed >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `MOVES.down[((transposed >> 0) & ROW_MASK) as usize]` [INFO] [stderr] --> src/game.rs:330:19 [INFO] [stderr] | [INFO] [stderr] 330 | result ^= MOVES.down[((transposed >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `transposed` [INFO] [stderr] --> src/game.rs:330:31 [INFO] [stderr] | [INFO] [stderr] 330 | result ^= MOVES.down[((transposed >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `MOVES.right[((board >> 0) & ROW_MASK) as usize]` [INFO] [stderr] --> src/game.rs:359:19 [INFO] [stderr] | [INFO] [stderr] 359 | result ^= MOVES.right[((board >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `board` [INFO] [stderr] --> src/game.rs:359:32 [INFO] [stderr] | [INFO] [stderr] 359 | result ^= MOVES.right[((board >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `MOVES.left[((board >> 0) & ROW_MASK) as usize]` [INFO] [stderr] --> src/game.rs:388:19 [INFO] [stderr] | [INFO] [stderr] 388 | result ^= MOVES.left[((board >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `board` [INFO] [stderr] --> src/game.rs:388:31 [INFO] [stderr] | [INFO] [stderr] 388 | result ^= MOVES.left[((board >> 0) & ROW_MASK) as usize] << 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/game.rs:411:31 [INFO] [stderr] | [INFO] [stderr] 411 | for i in 0 .. 16 { if ((board >> (i * 4)) & 0xF) == 0 { empty += 1 } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((board >> (i * 4))).trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game.rs:417:44 [INFO] [stderr] | [INFO] [stderr] 417 | pub fn table_helper(board: u64, table: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `board` [INFO] [stderr] --> src/game.rs:418:16 [INFO] [stderr] | [INFO] [stderr] 418 | table[((board >> 0) & ROW_MASK) as usize] + [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tfe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "366843aa139a6d8ce463ef43831c8cc648a906f67a9536da4f57351b4589fde2"` [INFO] running `"docker" "rm" "-f" "366843aa139a6d8ce463ef43831c8cc648a906f67a9536da4f57351b4589fde2"` [INFO] [stdout] 366843aa139a6d8ce463ef43831c8cc648a906f67a9536da4f57351b4589fde2