[INFO] crate textwidth 1.1.0 is already in cache [INFO] extracting crate textwidth 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/textwidth/1.1.0 [INFO] extracting crate textwidth 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/textwidth/1.1.0 [INFO] validating manifest of textwidth-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of textwidth-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing textwidth-1.1.0 [INFO] finished frobbing textwidth-1.1.0 [INFO] frobbed toml for textwidth-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/textwidth/1.1.0/Cargo.toml [INFO] started frobbing textwidth-1.1.0 [INFO] finished frobbing textwidth-1.1.0 [INFO] frobbed toml for textwidth-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/textwidth/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting textwidth-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/textwidth/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9973caf07edddbbccd9c1f9127c93056ea708203c4c65fa1421b0fdb904b8a35 [INFO] running `"docker" "start" "-a" "9973caf07edddbbccd9c1f9127c93056ea708203c4c65fa1421b0fdb904b8a35"` [INFO] [stderr] Checking x11 v2.18.1 [INFO] [stderr] Checking textwidth v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | fontset: fontset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fontset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | xfont: xfont, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `xfont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | fontset: fontset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fontset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | xfont: xfont, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `xfont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | / return Ok(Context { [INFO] [stderr] 53 | | data: Data::FontSet { [INFO] [stderr] 54 | | display: dpy, [INFO] [stderr] 55 | | fontset: fontset, [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Ok(Context { [INFO] [stderr] 53 | data: Data::FontSet { [INFO] [stderr] 54 | display: dpy, [INFO] [stderr] 55 | fontset: fontset, [INFO] [stderr] 56 | } [INFO] [stderr] 57 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | / return Ok(Context { [INFO] [stderr] 67 | | data: Data::XFont { [INFO] [stderr] 68 | | display: dpy, [INFO] [stderr] 69 | | xfont: xfont, [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Ok(Context { [INFO] [stderr] 67 | data: Data::XFont { [INFO] [stderr] 68 | display: dpy, [INFO] [stderr] 69 | xfont: xfont, [INFO] [stderr] 70 | } [INFO] [stderr] 71 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return r.width as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r.width as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | return xlib::XTextWidth(xfont, text.as_ptr(), text.as_bytes().len() as i32) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xlib::XTextWidth(xfont, text.as_ptr(), text.as_bytes().len() as i32) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:44:41 [INFO] [stderr] | [INFO] [stderr] 44 | mem::transmute(&missing_ptr), mem::transmute(&missing_len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&missing_ptr as *const *mut *mut i8 as *mut *mut *mut i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:44:71 [INFO] [stderr] | [INFO] [stderr] 44 | mem::transmute(&missing_ptr), mem::transmute(&missing_len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&missing_len as *const *mut i32 as *mut i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:110:24 [INFO] [stderr] | [INFO] [stderr] 110 | return r.width as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | / return Ok(Context { [INFO] [stderr] 53 | | data: Data::FontSet { [INFO] [stderr] 54 | | display: dpy, [INFO] [stderr] 55 | | fontset: fontset, [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Ok(Context { [INFO] [stderr] 53 | data: Data::FontSet { [INFO] [stderr] 54 | display: dpy, [INFO] [stderr] 55 | fontset: fontset, [INFO] [stderr] 56 | } [INFO] [stderr] 57 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | / return Ok(Context { [INFO] [stderr] 67 | | data: Data::XFont { [INFO] [stderr] 68 | | display: dpy, [INFO] [stderr] 69 | | xfont: xfont, [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Ok(Context { [INFO] [stderr] 67 | data: Data::XFont { [INFO] [stderr] 68 | display: dpy, [INFO] [stderr] 69 | xfont: xfont, [INFO] [stderr] 70 | } [INFO] [stderr] 71 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return r.width as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r.width as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | return xlib::XTextWidth(xfont, text.as_ptr(), text.as_bytes().len() as i32) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xlib::XTextWidth(xfont, text.as_ptr(), text.as_bytes().len() as i32) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:44:41 [INFO] [stderr] | [INFO] [stderr] 44 | mem::transmute(&missing_ptr), mem::transmute(&missing_len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&missing_ptr as *const *mut *mut i8 as *mut *mut *mut i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:44:71 [INFO] [stderr] | [INFO] [stderr] 44 | mem::transmute(&missing_ptr), mem::transmute(&missing_len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&missing_len as *const *mut i32 as *mut i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:110:24 [INFO] [stderr] | [INFO] [stderr] 110 | return r.width as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.61s [INFO] running `"docker" "inspect" "9973caf07edddbbccd9c1f9127c93056ea708203c4c65fa1421b0fdb904b8a35"` [INFO] running `"docker" "rm" "-f" "9973caf07edddbbccd9c1f9127c93056ea708203c4c65fa1421b0fdb904b8a35"` [INFO] [stdout] 9973caf07edddbbccd9c1f9127c93056ea708203c4c65fa1421b0fdb904b8a35