[INFO] crate texture 0.1.0 is already in cache [INFO] extracting crate texture 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/texture/0.1.0 [INFO] extracting crate texture 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/texture/0.1.0 [INFO] validating manifest of texture-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of texture-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing texture-0.1.0 [INFO] finished frobbing texture-0.1.0 [INFO] frobbed toml for texture-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/texture/0.1.0/Cargo.toml [INFO] started frobbing texture-0.1.0 [INFO] finished frobbing texture-0.1.0 [INFO] frobbed toml for texture-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/texture/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting texture-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/texture/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd96ef658e841a282568b422c8a0015a7ff48cdf4a167361002fca50c187981b [INFO] running `"docker" "start" "-a" "fd96ef658e841a282568b422c8a0015a7ff48cdf4a167361002fca50c187981b"` [INFO] [stderr] Compiling linenoise-rust v0.2.1 [INFO] [stderr] Checking texture v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/master.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/master.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | let result = self.current.borrow().do_action( [INFO] [stderr] | ______________________^ [INFO] [stderr] 226 | | &command.trim(), [INFO] [stderr] 227 | | &self.state, [INFO] [stderr] 228 | | &self.loader [INFO] [stderr] 229 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/master.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/master.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | let result = self.current.borrow().do_action( [INFO] [stderr] | ______________________^ [INFO] [stderr] 226 | | &command.trim(), [INFO] [stderr] 227 | | &self.state, [INFO] [stderr] 228 | | &self.loader [INFO] [stderr] 229 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `input` is never read [INFO] [stderr] --> src/master.rs:240:17 [INFO] [stderr] | [INFO] [stderr] 240 | let mut input = String::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state.rs:127:26 [INFO] [stderr] | [INFO] [stderr] 127 | Some(s) => { s.clone() }, [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state.rs:167:26 [INFO] [stderr] | [INFO] [stderr] 167 | Some(s) => { s.clone() }, [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `scenario::Loader` [INFO] [stderr] --> src/scenario.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Loader { [INFO] [stderr] 34 | | Loader { scenario: None } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/master.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | / match self.exec_game_command(&command.trim()) { [INFO] [stderr] 260 | | LOAD => { self.load_scenario(); continue }, [INFO] [stderr] 261 | | _ => {} [INFO] [stderr] 262 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let LOAD = self.exec_game_command(&command.trim()) { self.load_scenario(); continue }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/master.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | / match self.exec_current_scenario(&command.trim()) { [INFO] [stderr] 266 | | LOAD => { self.load_scenario(); }, [INFO] [stderr] 267 | | _ => {} [INFO] [stderr] 268 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let LOAD = self.exec_current_scenario(&command.trim()) { self.load_scenario(); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: value assigned to `input` is never read [INFO] [stderr] --> src/master.rs:240:17 [INFO] [stderr] | [INFO] [stderr] 240 | let mut input = String::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state.rs:127:26 [INFO] [stderr] | [INFO] [stderr] 127 | Some(s) => { s.clone() }, [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state.rs:167:26 [INFO] [stderr] | [INFO] [stderr] 167 | Some(s) => { s.clone() }, [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `scenario::Loader` [INFO] [stderr] --> src/scenario.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Loader { [INFO] [stderr] 34 | | Loader { scenario: None } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/master.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | / match self.exec_game_command(&command.trim()) { [INFO] [stderr] 260 | | LOAD => { self.load_scenario(); continue }, [INFO] [stderr] 261 | | _ => {} [INFO] [stderr] 262 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let LOAD = self.exec_game_command(&command.trim()) { self.load_scenario(); continue }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/master.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | / match self.exec_current_scenario(&command.trim()) { [INFO] [stderr] 266 | | LOAD => { self.load_scenario(); }, [INFO] [stderr] 267 | | _ => {} [INFO] [stderr] 268 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let LOAD = self.exec_current_scenario(&command.trim()) { self.load_scenario(); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/example.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loader` [INFO] [stderr] --> examples/example.rs:71:44 [INFO] [stderr] | [INFO] [stderr] 71 | fn load(&self, state: &Rc>, loader: &Rc>>) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider using `_loader` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loader` [INFO] [stderr] --> examples/example.rs:96:44 [INFO] [stderr] | [INFO] [stderr] 96 | fn load(&self, state: &Rc>, loader: &Rc>>) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider using `_loader` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loader` [INFO] [stderr] --> examples/example.rs:103:64 [INFO] [stderr] | [INFO] [stderr] 103 | fn do_action(&self, command: &str, state: &Rc>, loader: &Rc>>) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider using `_loader` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> examples/example.rs:113:23 [INFO] [stderr] | [INFO] [stderr] 113 | fn execute(&self, state: &Rc>, loader: &Rc>>) -> i32 { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loader` [INFO] [stderr] --> examples/example.rs:113:47 [INFO] [stderr] | [INFO] [stderr] 113 | fn execute(&self, state: &Rc>, loader: &Rc>>) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider using `_loader` instead [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/example.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | Some(s) => { s.clone() }, [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.15s [INFO] running `"docker" "inspect" "fd96ef658e841a282568b422c8a0015a7ff48cdf4a167361002fca50c187981b"` [INFO] running `"docker" "rm" "-f" "fd96ef658e841a282568b422c8a0015a7ff48cdf4a167361002fca50c187981b"` [INFO] [stdout] fd96ef658e841a282568b422c8a0015a7ff48cdf4a167361002fca50c187981b