[INFO] crate textstream 0.1.1 is already in cache [INFO] extracting crate textstream 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/textstream/0.1.1 [INFO] extracting crate textstream 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/textstream/0.1.1 [INFO] validating manifest of textstream-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of textstream-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing textstream-0.1.1 [INFO] finished frobbing textstream-0.1.1 [INFO] frobbed toml for textstream-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/textstream/0.1.1/Cargo.toml [INFO] started frobbing textstream-0.1.1 [INFO] finished frobbing textstream-0.1.1 [INFO] frobbed toml for textstream-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/textstream/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting textstream-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/textstream/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 605bb9f69acb93445865df1d59e2c57ed317d6ae817108a74327416fe8dd2915 [INFO] running `"docker" "start" "-a" "605bb9f69acb93445865df1d59e2c57ed317d6ae817108a74327416fe8dd2915"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking textstream v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | bufreader: bufreader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bufreader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | trap: trap, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `trap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | bufreader: bufreader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bufreader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | trap: trap, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `trap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | const ERR_INCOMPLETE_SEQ: &'static str = "incomplete sequence"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | const ERR_INCOMPLETE_SEQ: &'static str = "incomplete sequence"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | if self.textbuf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.textbuf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | / match memchr(b'\n', &buf[lastlen..].as_bytes()) { [INFO] [stderr] 253 | | Some(n) => { [INFO] [stderr] 254 | | if lastlen + n + 1 < newlen { [INFO] [stderr] 255 | | self.textbuf = buf[lastlen + n + 1..].to_string(); [INFO] [stderr] ... | [INFO] [stderr] 264 | | _ => {} [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 252 | if let Some(n) = memchr(b'\n', &buf[lastlen..].as_bytes()) { [INFO] [stderr] 253 | if lastlen + n + 1 < newlen { [INFO] [stderr] 254 | self.textbuf = buf[lastlen + n + 1..].to_string(); [INFO] [stderr] 255 | self.textbuf_completeseq = match result.as_ref() { [INFO] [stderr] 256 | Err(&Error::CodecError(ref s)) if s == ERR_INCOMPLETE_SEQ => true, [INFO] [stderr] 257 | _ => false [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | / match result { [INFO] [stderr] 267 | | Err(e) => { [INFO] [stderr] 268 | | match e { [INFO] [stderr] 269 | | Error::IOError(ref ioerr) if ioerr.kind() == ErrorKind::Interrupted => { [INFO] [stderr] ... | [INFO] [stderr] 279 | | _ => {} [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 266 | if let Err(e) = result { [INFO] [stderr] 267 | match e { [INFO] [stderr] 268 | Error::IOError(ref ioerr) if ioerr.kind() == ErrorKind::Interrupted => { [INFO] [stderr] 269 | lastlen = newlen; [INFO] [stderr] 270 | continue; [INFO] [stderr] 271 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:309:20 [INFO] [stderr] | [INFO] [stderr] 309 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:310:36 [INFO] [stderr] | [INFO] [stderr] 310 | if s.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:312:40 [INFO] [stderr] | [INFO] [stderr] 312 | if s.ends_with("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | if self.textbuf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.textbuf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | / match memchr(b'\n', &buf[lastlen..].as_bytes()) { [INFO] [stderr] 253 | | Some(n) => { [INFO] [stderr] 254 | | if lastlen + n + 1 < newlen { [INFO] [stderr] 255 | | self.textbuf = buf[lastlen + n + 1..].to_string(); [INFO] [stderr] ... | [INFO] [stderr] 264 | | _ => {} [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 252 | if let Some(n) = memchr(b'\n', &buf[lastlen..].as_bytes()) { [INFO] [stderr] 253 | if lastlen + n + 1 < newlen { [INFO] [stderr] 254 | self.textbuf = buf[lastlen + n + 1..].to_string(); [INFO] [stderr] 255 | self.textbuf_completeseq = match result.as_ref() { [INFO] [stderr] 256 | Err(&Error::CodecError(ref s)) if s == ERR_INCOMPLETE_SEQ => true, [INFO] [stderr] 257 | _ => false [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | / match result { [INFO] [stderr] 267 | | Err(e) => { [INFO] [stderr] 268 | | match e { [INFO] [stderr] 269 | | Error::IOError(ref ioerr) if ioerr.kind() == ErrorKind::Interrupted => { [INFO] [stderr] ... | [INFO] [stderr] 279 | | _ => {} [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 266 | if let Err(e) = result { [INFO] [stderr] 267 | match e { [INFO] [stderr] 268 | Error::IOError(ref ioerr) if ioerr.kind() == ErrorKind::Interrupted => { [INFO] [stderr] 269 | lastlen = newlen; [INFO] [stderr] 270 | continue; [INFO] [stderr] 271 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:309:20 [INFO] [stderr] | [INFO] [stderr] 309 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:310:36 [INFO] [stderr] | [INFO] [stderr] 310 | if s.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:312:40 [INFO] [stderr] | [INFO] [stderr] 312 | if s.ends_with("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:383:30 [INFO] [stderr] | [INFO] [stderr] 383 | v.extend_from_slice(&"abcd".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.79s [INFO] running `"docker" "inspect" "605bb9f69acb93445865df1d59e2c57ed317d6ae817108a74327416fe8dd2915"` [INFO] running `"docker" "rm" "-f" "605bb9f69acb93445865df1d59e2c57ed317d6ae817108a74327416fe8dd2915"` [INFO] [stdout] 605bb9f69acb93445865df1d59e2c57ed317d6ae817108a74327416fe8dd2915