[INFO] crate text-transliterate 0.1.0 is already in cache [INFO] extracting crate text-transliterate 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/text-transliterate/0.1.0 [INFO] extracting crate text-transliterate 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/text-transliterate/0.1.0 [INFO] validating manifest of text-transliterate-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of text-transliterate-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing text-transliterate-0.1.0 [INFO] finished frobbing text-transliterate-0.1.0 [INFO] frobbed toml for text-transliterate-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/text-transliterate/0.1.0/Cargo.toml [INFO] started frobbing text-transliterate-0.1.0 [INFO] finished frobbing text-transliterate-0.1.0 [INFO] frobbed toml for text-transliterate-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/text-transliterate/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting text-transliterate-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/text-transliterate/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a4edf83755203830346413c4c0b879e20103f3ffea938ee97fec8d8c0e174b1 [INFO] running `"docker" "start" "-a" "3a4edf83755203830346413c4c0b879e20103f3ffea938ee97fec8d8c0e174b1"` [INFO] [stderr] Checking text-transliterate v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transliterate_async.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | TextTransliterateAsync {sender: sender} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transliterate_async.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transliterate_async.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | TextTransliterateAsync {sender: sender} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transliterate_async.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | return cd != &err; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cd != &err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | return v != &err; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v != &err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | return Ok(Iconv { iconv: cd }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Iconv { iconv: cd })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | return Err(IconvError::OnCStringConversion(null_err)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IconvError::OnCStringConversion(null_err))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | return Ok(dst.len() - (*outbytes_left as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dst.len() - (*outbytes_left as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/locale_ffi.rs:11:53 [INFO] [stderr] | [INFO] [stderr] 11 | pub const _POSIX_C_SOURCE: ::std::os::raw::c_uint = 200809; [INFO] [stderr] | ^^^^^^ help: consider: `200_809` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/locale_ffi.rs:25:56 [INFO] [stderr] | [INFO] [stderr] 25 | pub const __STDC_ISO_10646__: ::std::os::raw::c_uint = 201605; [INFO] [stderr] | ^^^^^^ help: consider: `201_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/transliterate.rs:30:47 [INFO] [stderr] | [INFO] [stderr] 30 | if !old_locale.is_null() && old_locale != 0xffffffffffffffff as *mut __locale_struct { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iconv.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn is_iconv_t_valid(cd: &iconv_t) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `iconv_t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/iconv.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let err = ::std::mem::transmute::(-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `-1 as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iconv.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_iconv_valid(v: &size_t) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `size_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/iconv.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self { [INFO] [stderr] 90 | | &OnFindingConversion(ref e) => { [INFO] [stderr] 91 | | format!("C function `iconv_open` failed: {}", e) [INFO] [stderr] 92 | | } [INFO] [stderr] ... | [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | match *self { [INFO] [stderr] 90 | OnFindingConversion(ref e) => { [INFO] [stderr] 91 | format!("C function `iconv_open` failed: {}", e) [INFO] [stderr] 92 | } [INFO] [stderr] 93 | OnCStringConversion(ref e) => { [INFO] [stderr] 94 | format!("CString::new failed: {}", e) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/iconv.rs:174:30 [INFO] [stderr] | [INFO] [stderr] 174 | let unsafe_src = transmute::<&&[u8], *const (*const u8)>(&src); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&src as *const &[u8] as *const *const u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/iconv.rs:175:30 [INFO] [stderr] | [INFO] [stderr] 175 | let unsafe_dst = transmute::<&mut &mut [u8], *mut (*mut u8)>(&mut dst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dst as *mut &mut [u8] as *mut *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `transliterate::TextTransliterate` [INFO] [stderr] --> src/transliterate.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new() -> TextTransliterate { [INFO] [stderr] | _____^ [INFO] [stderr] 11 | | TextTransliterate {} [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/transliterate.rs:45:10 [INFO] [stderr] | [INFO] [stderr] 45 | if let Ok(_) = self.set_thread_locale(locale) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 46 | | [INFO] [stderr] 47 | | let iconv = Iconv::new("ascii//TRANSLIT//IGNORE", "utf-8"); [INFO] [stderr] 48 | | [INFO] [stderr] ... | [INFO] [stderr] 68 | | Err("Not possible to set the locale") [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________- help: try this: `if self.set_thread_locale(locale).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/transliterate.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if let Err(_) = result { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 55 | | return Err("Error in transliteration"); [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________________- help: try this: `if result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `transliterate_async::TextTransliterateAsync` [INFO] [stderr] --> src/transliterate_async.rs:25:2 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn new() -> TextTransliterateAsync { [INFO] [stderr] | _____^ [INFO] [stderr] 26 | | let sender = TextTransliterateAsync::generate_transliterator(); [INFO] [stderr] 27 | | [INFO] [stderr] 28 | | TextTransliterateAsync {sender: sender} [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for transliterate_async::TextTransliterateAsync { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/transliterate_async.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | let (sender, receiver): (Sender>, Receiver>) = mpsc::channel(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/transliterate_async.rs:75:10 [INFO] [stderr] | [INFO] [stderr] 75 | if let Err(_) = send_result { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 76 | | self.regenerate_transliterator(); [INFO] [stderr] 77 | | return self.transliterate(text, locale); [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________- help: try this: `if send_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | return cd != &err; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cd != &err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | return v != &err; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v != &err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | return Ok(Iconv { iconv: cd }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Iconv { iconv: cd })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | return Err(IconvError::OnCStringConversion(null_err)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IconvError::OnCStringConversion(null_err))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iconv.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | return Ok(dst.len() - (*outbytes_left as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dst.len() - (*outbytes_left as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/locale_ffi.rs:11:53 [INFO] [stderr] | [INFO] [stderr] 11 | pub const _POSIX_C_SOURCE: ::std::os::raw::c_uint = 200809; [INFO] [stderr] | ^^^^^^ help: consider: `200_809` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/locale_ffi.rs:25:56 [INFO] [stderr] | [INFO] [stderr] 25 | pub const __STDC_ISO_10646__: ::std::os::raw::c_uint = 201605; [INFO] [stderr] | ^^^^^^ help: consider: `201_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/transliterate.rs:30:47 [INFO] [stderr] | [INFO] [stderr] 30 | if !old_locale.is_null() && old_locale != 0xffffffffffffffff as *mut __locale_struct { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iconv.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn is_iconv_t_valid(cd: &iconv_t) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `iconv_t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/iconv.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let err = ::std::mem::transmute::(-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `-1 as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iconv.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_iconv_valid(v: &size_t) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `size_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/iconv.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self { [INFO] [stderr] 90 | | &OnFindingConversion(ref e) => { [INFO] [stderr] 91 | | format!("C function `iconv_open` failed: {}", e) [INFO] [stderr] 92 | | } [INFO] [stderr] ... | [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | match *self { [INFO] [stderr] 90 | OnFindingConversion(ref e) => { [INFO] [stderr] 91 | format!("C function `iconv_open` failed: {}", e) [INFO] [stderr] 92 | } [INFO] [stderr] 93 | OnCStringConversion(ref e) => { [INFO] [stderr] 94 | format!("CString::new failed: {}", e) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/iconv.rs:174:30 [INFO] [stderr] | [INFO] [stderr] 174 | let unsafe_src = transmute::<&&[u8], *const (*const u8)>(&src); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&src as *const &[u8] as *const *const u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/iconv.rs:175:30 [INFO] [stderr] | [INFO] [stderr] 175 | let unsafe_dst = transmute::<&mut &mut [u8], *mut (*mut u8)>(&mut dst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dst as *mut &mut [u8] as *mut *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_raw` doesn't need a mutable reference [INFO] [stderr] --> src/iconv.rs:276:33 [INFO] [stderr] | [INFO] [stderr] 276 | let res = iconv.convert_raw(&mut src, &mut outbuf).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_raw` doesn't need a mutable reference [INFO] [stderr] --> src/iconv.rs:281:34 [INFO] [stderr] | [INFO] [stderr] 281 | let res2 = iconv.convert_raw(&mut outbuf[0..res], &mut outbuf2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_raw` doesn't need a mutable reference [INFO] [stderr] --> src/iconv.rs:297:77 [INFO] [stderr] | [INFO] [stderr] 297 | if let Err(IconvError::InsufficientOutBuffer(_, _)) = iconv.convert_raw(&mut src, &mut outbuf) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert` doesn't need a mutable reference [INFO] [stderr] --> src/iconv.rs:314:29 [INFO] [stderr] | [INFO] [stderr] 314 | let res = iconv.convert(&mut src, &mut dst, 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/iconv.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert` doesn't need a mutable reference [INFO] [stderr] --> src/iconv.rs:323:31 [INFO] [stderr] | [INFO] [stderr] 323 | let _ = iconv_rev.convert(&mut dst, &mut dst2, 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/locale_ffi.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | / fn bindgen_test_layout_lconv() { [INFO] [stderr] 132 | | assert_eq!(::std::mem::size_of::() , 96usize , concat ! ( [INFO] [stderr] 133 | | "Size of: " , stringify ! ( lconv ) )); [INFO] [stderr] 134 | | assert_eq! (::std::mem::align_of::() , 8usize , concat ! ( [INFO] [stderr] ... | [INFO] [stderr] 255 | | stringify ! ( int_n_sign_posn ) )); [INFO] [stderr] 256 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:137:23 [INFO] [stderr] | [INFO] [stderr] 137 | & ( * ( 0 as * const lconv ) ) . decimal_point as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | & ( * ( 0 as * const lconv ) ) . thousands_sep as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | & ( * ( 0 as * const lconv ) ) . grouping as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | & ( * ( 0 as * const lconv ) ) . int_curr_symbol as * const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | & ( * ( 0 as * const lconv ) ) . currency_symbol as * const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:162:23 [INFO] [stderr] | [INFO] [stderr] 162 | & ( * ( 0 as * const lconv ) ) . mon_decimal_point as * const [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:167:23 [INFO] [stderr] | [INFO] [stderr] 167 | & ( * ( 0 as * const lconv ) ) . mon_thousands_sep as * const [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:172:23 [INFO] [stderr] | [INFO] [stderr] 172 | & ( * ( 0 as * const lconv ) ) . mon_grouping as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:177:23 [INFO] [stderr] | [INFO] [stderr] 177 | & ( * ( 0 as * const lconv ) ) . positive_sign as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:182:23 [INFO] [stderr] | [INFO] [stderr] 182 | & ( * ( 0 as * const lconv ) ) . negative_sign as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:187:23 [INFO] [stderr] | [INFO] [stderr] 187 | & ( * ( 0 as * const lconv ) ) . int_frac_digits as * const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:192:23 [INFO] [stderr] | [INFO] [stderr] 192 | & ( * ( 0 as * const lconv ) ) . frac_digits as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:197:23 [INFO] [stderr] | [INFO] [stderr] 197 | & ( * ( 0 as * const lconv ) ) . p_cs_precedes as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:202:23 [INFO] [stderr] | [INFO] [stderr] 202 | & ( * ( 0 as * const lconv ) ) . p_sep_by_space as * const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:207:23 [INFO] [stderr] | [INFO] [stderr] 207 | & ( * ( 0 as * const lconv ) ) . n_cs_precedes as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:212:23 [INFO] [stderr] | [INFO] [stderr] 212 | & ( * ( 0 as * const lconv ) ) . n_sep_by_space as * const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | & ( * ( 0 as * const lconv ) ) . p_sign_posn as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:222:23 [INFO] [stderr] | [INFO] [stderr] 222 | & ( * ( 0 as * const lconv ) ) . n_sign_posn as * const _ as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | & ( * ( 0 as * const lconv ) ) . int_p_cs_precedes as * const [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:232:23 [INFO] [stderr] | [INFO] [stderr] 232 | & ( * ( 0 as * const lconv ) ) . int_p_sep_by_space as * const [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:237:23 [INFO] [stderr] | [INFO] [stderr] 237 | & ( * ( 0 as * const lconv ) ) . int_n_cs_precedes as * const [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:242:23 [INFO] [stderr] | [INFO] [stderr] 242 | & ( * ( 0 as * const lconv ) ) . int_n_sep_by_space as * const [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:247:23 [INFO] [stderr] | [INFO] [stderr] 247 | & ( * ( 0 as * const lconv ) ) . int_p_sign_posn as * const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:252:23 [INFO] [stderr] | [INFO] [stderr] 252 | & ( * ( 0 as * const lconv ) ) . int_n_sign_posn as * const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:287:23 [INFO] [stderr] | [INFO] [stderr] 287 | & ( * ( 0 as * const __locale_struct ) ) . __locales as * [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:292:23 [INFO] [stderr] | [INFO] [stderr] 292 | & ( * ( 0 as * const __locale_struct ) ) . __ctype_b as * [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:297:23 [INFO] [stderr] | [INFO] [stderr] 297 | & ( * ( 0 as * const __locale_struct ) ) . __ctype_tolower as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:302:23 [INFO] [stderr] | [INFO] [stderr] 302 | & ( * ( 0 as * const __locale_struct ) ) . __ctype_toupper as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/locale_ffi.rs:307:23 [INFO] [stderr] | [INFO] [stderr] 307 | & ( * ( 0 as * const __locale_struct ) ) . __names as * const [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `transliterate::TextTransliterate` [INFO] [stderr] --> src/transliterate.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new() -> TextTransliterate { [INFO] [stderr] | _____^ [INFO] [stderr] 11 | | TextTransliterate {} [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/transliterate.rs:45:10 [INFO] [stderr] | [INFO] [stderr] 45 | if let Ok(_) = self.set_thread_locale(locale) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 46 | | [INFO] [stderr] 47 | | let iconv = Iconv::new("ascii//TRANSLIT//IGNORE", "utf-8"); [INFO] [stderr] 48 | | [INFO] [stderr] ... | [INFO] [stderr] 68 | | Err("Not possible to set the locale") [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________- help: try this: `if self.set_thread_locale(locale).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/transliterate.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if let Err(_) = result { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 55 | | return Err("Error in transliteration"); [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________________- help: try this: `if result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `transliterate_async::TextTransliterateAsync` [INFO] [stderr] --> src/transliterate_async.rs:25:2 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn new() -> TextTransliterateAsync { [INFO] [stderr] | _____^ [INFO] [stderr] 26 | | let sender = TextTransliterateAsync::generate_transliterator(); [INFO] [stderr] 27 | | [INFO] [stderr] 28 | | TextTransliterateAsync {sender: sender} [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for transliterate_async::TextTransliterateAsync { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/transliterate_async.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | let (sender, receiver): (Sender>, Receiver>) = mpsc::channel(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/transliterate_async.rs:75:10 [INFO] [stderr] | [INFO] [stderr] 75 | if let Err(_) = send_result { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 76 | | self.regenerate_transliterator(); [INFO] [stderr] 77 | | return self.transliterate(text, locale); [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________- help: try this: `if send_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.43s [INFO] running `"docker" "inspect" "3a4edf83755203830346413c4c0b879e20103f3ffea938ee97fec8d8c0e174b1"` [INFO] running `"docker" "rm" "-f" "3a4edf83755203830346413c4c0b879e20103f3ffea938ee97fec8d8c0e174b1"` [INFO] [stdout] 3a4edf83755203830346413c4c0b879e20103f3ffea938ee97fec8d8c0e174b1