[INFO] crate text-to-polly-ssml 0.3.3 is already in cache [INFO] extracting crate text-to-polly-ssml 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/text-to-polly-ssml/0.3.3 [INFO] extracting crate text-to-polly-ssml 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/text-to-polly-ssml/0.3.3 [INFO] validating manifest of text-to-polly-ssml-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of text-to-polly-ssml-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing text-to-polly-ssml-0.3.3 [INFO] finished frobbing text-to-polly-ssml-0.3.3 [INFO] frobbed toml for text-to-polly-ssml-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/text-to-polly-ssml/0.3.3/Cargo.toml [INFO] started frobbing text-to-polly-ssml-0.3.3 [INFO] finished frobbing text-to-polly-ssml-0.3.3 [INFO] frobbed toml for text-to-polly-ssml-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/text-to-polly-ssml/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting text-to-polly-ssml-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/text-to-polly-ssml/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05d10b14bbc045e8de82fbfcc960b20a12fdf45f9d234ec876141e75cbc653db [INFO] running `"docker" "start" "-a" "05d10b14bbc045e8de82fbfcc960b20a12fdf45f9d234ec876141e75cbc653db"` [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking quick-xml v0.13.2 [INFO] [stderr] Checking text-to-polly-ssml v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssml_constants/mod.rs:77:7 [INFO] [stderr] | [INFO] [stderr] 77 | is_seconds: is_seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_seconds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xml_writer.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssml_constants/mod.rs:77:7 [INFO] [stderr] | [INFO] [stderr] 77 | is_seconds: is_seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_seconds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xml_writer.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ssml_constants/mod.rs:108:7 [INFO] [stderr] | [INFO] [stderr] 108 | return Err(()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ssml_constants/mod.rs:108:7 [INFO] [stderr] | [INFO] [stderr] 108 | return Err(()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | if key.contains("|") { [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:48:38 [INFO] [stderr] | [INFO] [stderr] 48 | let mut as_split = key.split("|"); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / loop { [INFO] [stderr] 52 | | match as_split.next() { [INFO] [stderr] 53 | | Some(x) => { [INFO] [stderr] 54 | | let mut as_split_new = x.split("="); [INFO] [stderr] ... | [INFO] [stderr] 64 | | }; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(x) = as_split.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:54:46 [INFO] [stderr] | [INFO] [stderr] 54 | let mut as_split_new = x.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/parser.rs:149:38 [INFO] [stderr] | [INFO] [stderr] 149 | let _ = parsed.into_iter().inspect(|item| { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 150 | | if let Some(ref start_tag) = item.start_tag { [INFO] [stderr] 151 | | let as_tag = start_tag.tag_key.clone().parse::(); [INFO] [stderr] 152 | | if as_tag.is_err() { [INFO] [stderr] ... | [INFO] [stderr] 334 | | } [INFO] [stderr] 335 | | }).count(); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:163:35 [INFO] [stderr] | [INFO] [stderr] 163 | let attempted_parse = start_tag.params.get("strength").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["strength"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:170:35 [INFO] [stderr] | [INFO] [stderr] 170 | let attempted_parse = start_tag.params.get("time").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["time"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser.rs:183:11 [INFO] [stderr] | [INFO] [stderr] 183 | / let mut onlangfailure: Option = None; [INFO] [stderr] 184 | | if start_tag.params.contains_key("onlangfailure") { [INFO] [stderr] 185 | | onlangfailure = Some(start_tag.params.get("onlangfailure").unwrap().to_owned()); [INFO] [stderr] 186 | | } [INFO] [stderr] | |___________^ help: it is more idiomatic to write: `let onlangfailure = if start_tag.params.contains_key("onlangfailure") { Some(start_tag.params.get("onlangfailure").unwrap().to_owned()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:182:22 [INFO] [stderr] | [INFO] [stderr] 182 | let lang = start_tag.params.get("lang").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["lang"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:185:34 [INFO] [stderr] | [INFO] [stderr] 185 | onlangfailure = Some(start_tag.params.get("onlangfailure").unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["onlangfailure"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:193:22 [INFO] [stderr] | [INFO] [stderr] 193 | let name = start_tag.params.get("name").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["name"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:204:36 [INFO] [stderr] | [INFO] [stderr] 204 | let potential_alphabet = start_tag.params.get("alphabet").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["alphabet"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:210:20 [INFO] [stderr] | [INFO] [stderr] 210 | let ph = start_tag.params.get("ph").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["ph"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | volume = Some(start_tag.params.get("volume").unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["volume"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:222:38 [INFO] [stderr] | [INFO] [stderr] 222 | let potentially_parsed = start_tag.params.get("rate").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["rate"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:229:26 [INFO] [stderr] | [INFO] [stderr] 229 | pitch = Some(start_tag.params.get("pitch").unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["pitch"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:241:30 [INFO] [stderr] | [INFO] [stderr] 241 | let interpret_as = start_tag.params.get("interpret-as").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["interpret-as"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:248:23 [INFO] [stderr] | [INFO] [stderr] 248 | let alias = start_tag.params.get("alias").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["alias"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:255:36 [INFO] [stderr] | [INFO] [stderr] 255 | let potentially_parsed = start_tag.params.get("role").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["role"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:268:38 [INFO] [stderr] | [INFO] [stderr] 268 | let potentially_parsed = start_tag.params.get("name").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["name"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:274:26 [INFO] [stderr] | [INFO] [stderr] 274 | let factor = start_tag.params.get("vocal-tract-length").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["vocal-tract-length"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:277:38 [INFO] [stderr] | [INFO] [stderr] 277 | let potentially_parsed = start_tag.params.get("phonation").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["phonation"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &BreakStrength::NoStrength => write!(f, "none"), [INFO] [stderr] 25 | | &BreakStrength::XWeak => write!(f, "x-weak"), [INFO] [stderr] 26 | | &BreakStrength::Weak => write!(f, "weak"), [INFO] [stderr] ... | [INFO] [stderr] 29 | | &BreakStrength::XStrong => write!(f, "x-strong"), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | BreakStrength::NoStrength => write!(f, "none"), [INFO] [stderr] 25 | BreakStrength::XWeak => write!(f, "x-weak"), [INFO] [stderr] 26 | BreakStrength::Weak => write!(f, "weak"), [INFO] [stderr] 27 | BreakStrength::Medium => write!(f, "medium"), [INFO] [stderr] 28 | BreakStrength::Strong => write!(f, "strong"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ssml_constants/mod.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | } else if s.ends_with("s") && s != "s" { [INFO] [stderr] | ^^^ help: try using a char instead: `'s'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ssml_constants/mod.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | let mut as_split = s.split("s"); [INFO] [stderr] | ^^^ help: try using a char instead: `'s'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / match self { [INFO] [stderr] 124 | | &PhonemeAlphabet::Ipa => write!(f, "ipa"), [INFO] [stderr] 125 | | &PhonemeAlphabet::XSampa => write!(f, "x-sampa"), [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *self { [INFO] [stderr] 124 | PhonemeAlphabet::Ipa => write!(f, "ipa"), [INFO] [stderr] 125 | PhonemeAlphabet::XSampa => write!(f, "x-sampa"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / match self { [INFO] [stderr] 156 | | &ProsodyRate::XSlow => write!(f, "x-slow"), [INFO] [stderr] 157 | | &ProsodyRate::Slow => write!(f, "slow"), [INFO] [stderr] 158 | | &ProsodyRate::Medium => write!(f, "medium"), [INFO] [stderr] 159 | | &ProsodyRate::Fast => write!(f, "fast"), [INFO] [stderr] 160 | | &ProsodyRate::XFast => write!(f, "x-fast"), [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *self { [INFO] [stderr] 156 | ProsodyRate::XSlow => write!(f, "x-slow"), [INFO] [stderr] 157 | ProsodyRate::Slow => write!(f, "slow"), [INFO] [stderr] 158 | ProsodyRate::Medium => write!(f, "medium"), [INFO] [stderr] 159 | ProsodyRate::Fast => write!(f, "fast"), [INFO] [stderr] 160 | ProsodyRate::XFast => write!(f, "x-fast"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / match self { [INFO] [stderr] 192 | | &WordRole::Verb => write!(f, "amazon:VB"), [INFO] [stderr] 193 | | &WordRole::PastTense => write!(f, "amazon:VBD"), [INFO] [stderr] 194 | | &WordRole::PresentTense => write!(f, "amazon:SENSE_1"), [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 191 | match *self { [INFO] [stderr] 192 | WordRole::Verb => write!(f, "amazon:VB"), [INFO] [stderr] 193 | WordRole::PastTense => write!(f, "amazon:VBD"), [INFO] [stderr] 194 | WordRole::PresentTense => write!(f, "amazon:SENSE_1"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | / match self { [INFO] [stderr] 223 | | &AmazonEffect::Whispered => write!(f, "whispered"), [INFO] [stderr] 224 | | &AmazonEffect::Drc => write!(f, "drc"), [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | match *self { [INFO] [stderr] 223 | AmazonEffect::Whispered => write!(f, "whispered"), [INFO] [stderr] 224 | AmazonEffect::Drc => write!(f, "drc"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | / match self { [INFO] [stderr] 256 | | &BreathVolumes::Def => write!(f, "default"), [INFO] [stderr] 257 | | &BreathVolumes::XSoft => write!(f, "x-soft"), [INFO] [stderr] 258 | | &BreathVolumes::Soft => write!(f, "soft"), [INFO] [stderr] ... | [INFO] [stderr] 261 | | &BreathVolumes::XLoud => write!(f, "x-loud"), [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 255 | match *self { [INFO] [stderr] 256 | BreathVolumes::Def => write!(f, "default"), [INFO] [stderr] 257 | BreathVolumes::XSoft => write!(f, "x-soft"), [INFO] [stderr] 258 | BreathVolumes::Soft => write!(f, "soft"), [INFO] [stderr] 259 | BreathVolumes::Medium => write!(f, "medium"), [INFO] [stderr] 260 | BreathVolumes::Loud => write!(f, "loud"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | / match self { [INFO] [stderr] 297 | | &BreathDuration::Def => write!(f, "default"), [INFO] [stderr] 298 | | &BreathDuration::XShort => write!(f, "x-short"), [INFO] [stderr] 299 | | &BreathDuration::Short => write!(f, "short"), [INFO] [stderr] ... | [INFO] [stderr] 302 | | &BreathDuration::XLong => write!(f, "x-long"), [INFO] [stderr] 303 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 296 | match *self { [INFO] [stderr] 297 | BreathDuration::Def => write!(f, "default"), [INFO] [stderr] 298 | BreathDuration::XShort => write!(f, "x-short"), [INFO] [stderr] 299 | BreathDuration::Short => write!(f, "short"), [INFO] [stderr] 300 | BreathDuration::Medium => write!(f, "medium"), [INFO] [stderr] 301 | BreathDuration::Long => write!(f, "long"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:337:5 [INFO] [stderr] | [INFO] [stderr] 337 | / match self { [INFO] [stderr] 338 | | &AutoBreathFrequency::Def => write!(f, "default"), [INFO] [stderr] 339 | | &AutoBreathFrequency::XLow => write!(f, "x-low"), [INFO] [stderr] 340 | | &AutoBreathFrequency::Low => write!(f, "low"), [INFO] [stderr] ... | [INFO] [stderr] 343 | | &AutoBreathFrequency::XHigh => write!(f, "x-high"), [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 337 | match *self { [INFO] [stderr] 338 | AutoBreathFrequency::Def => write!(f, "default"), [INFO] [stderr] 339 | AutoBreathFrequency::XLow => write!(f, "x-low"), [INFO] [stderr] 340 | AutoBreathFrequency::Low => write!(f, "low"), [INFO] [stderr] 341 | AutoBreathFrequency::Medium => write!(f, "medium"), [INFO] [stderr] 342 | AutoBreathFrequency::High => write!(f, "high"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | / match self { [INFO] [stderr] 374 | | &PhonationVolume::Soft => write!(f, "soft") [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 373 | match *self { [INFO] [stderr] 374 | PhonationVolume::Soft => write!(f, "soft") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/xml_writer.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | elem.push_attribute(("xml:lang", &*lang.unwrap_or("en-US".to_owned()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "en-US".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/xml_writer.rs:91:59 [INFO] [stderr] | [INFO] [stderr] 91 | elem.push_attribute(("onlangfailure", &*onlangfailure.unwrap_or("processorchoice".to_owned()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "processorchoice".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/xml_writer.rs:239:59 [INFO] [stderr] | [INFO] [stderr] 239 | elem.push_attribute(("onlangfailure", &*onlangfailure.unwrap_or("processorchoice".to_owned()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "processorchoice".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/xml_writer.rs:832:50 [INFO] [stderr] | [INFO] [stderr] 832 | elem.push_attribute(("vocal-tract-length", &*format!("{}", factor))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `factor.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | if key.contains("|") { [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:48:38 [INFO] [stderr] | [INFO] [stderr] 48 | let mut as_split = key.split("|"); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / loop { [INFO] [stderr] 52 | | match as_split.next() { [INFO] [stderr] 53 | | Some(x) => { [INFO] [stderr] 54 | | let mut as_split_new = x.split("="); [INFO] [stderr] ... | [INFO] [stderr] 64 | | }; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(x) = as_split.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:54:46 [INFO] [stderr] | [INFO] [stderr] 54 | let mut as_split_new = x.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/parser.rs:149:38 [INFO] [stderr] | [INFO] [stderr] 149 | let _ = parsed.into_iter().inspect(|item| { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 150 | | if let Some(ref start_tag) = item.start_tag { [INFO] [stderr] 151 | | let as_tag = start_tag.tag_key.clone().parse::(); [INFO] [stderr] 152 | | if as_tag.is_err() { [INFO] [stderr] ... | [INFO] [stderr] 334 | | } [INFO] [stderr] 335 | | }).count(); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:163:35 [INFO] [stderr] | [INFO] [stderr] 163 | let attempted_parse = start_tag.params.get("strength").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["strength"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:170:35 [INFO] [stderr] | [INFO] [stderr] 170 | let attempted_parse = start_tag.params.get("time").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["time"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser.rs:183:11 [INFO] [stderr] | [INFO] [stderr] 183 | / let mut onlangfailure: Option = None; [INFO] [stderr] 184 | | if start_tag.params.contains_key("onlangfailure") { [INFO] [stderr] 185 | | onlangfailure = Some(start_tag.params.get("onlangfailure").unwrap().to_owned()); [INFO] [stderr] 186 | | } [INFO] [stderr] | |___________^ help: it is more idiomatic to write: `let onlangfailure = if start_tag.params.contains_key("onlangfailure") { Some(start_tag.params.get("onlangfailure").unwrap().to_owned()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:182:22 [INFO] [stderr] | [INFO] [stderr] 182 | let lang = start_tag.params.get("lang").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["lang"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:185:34 [INFO] [stderr] | [INFO] [stderr] 185 | onlangfailure = Some(start_tag.params.get("onlangfailure").unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["onlangfailure"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:193:22 [INFO] [stderr] | [INFO] [stderr] 193 | let name = start_tag.params.get("name").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["name"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:204:36 [INFO] [stderr] | [INFO] [stderr] 204 | let potential_alphabet = start_tag.params.get("alphabet").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["alphabet"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:210:20 [INFO] [stderr] | [INFO] [stderr] 210 | let ph = start_tag.params.get("ph").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["ph"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | volume = Some(start_tag.params.get("volume").unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["volume"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:222:38 [INFO] [stderr] | [INFO] [stderr] 222 | let potentially_parsed = start_tag.params.get("rate").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["rate"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:229:26 [INFO] [stderr] | [INFO] [stderr] 229 | pitch = Some(start_tag.params.get("pitch").unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["pitch"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:241:30 [INFO] [stderr] | [INFO] [stderr] 241 | let interpret_as = start_tag.params.get("interpret-as").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["interpret-as"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:248:23 [INFO] [stderr] | [INFO] [stderr] 248 | let alias = start_tag.params.get("alias").unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["alias"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:255:36 [INFO] [stderr] | [INFO] [stderr] 255 | let potentially_parsed = start_tag.params.get("role").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["role"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:268:38 [INFO] [stderr] | [INFO] [stderr] 268 | let potentially_parsed = start_tag.params.get("name").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["name"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:274:26 [INFO] [stderr] | [INFO] [stderr] 274 | let factor = start_tag.params.get("vocal-tract-length").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["vocal-tract-length"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:277:38 [INFO] [stderr] | [INFO] [stderr] 277 | let potentially_parsed = start_tag.params.get("phonation").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&start_tag.params["phonation"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &BreakStrength::NoStrength => write!(f, "none"), [INFO] [stderr] 25 | | &BreakStrength::XWeak => write!(f, "x-weak"), [INFO] [stderr] 26 | | &BreakStrength::Weak => write!(f, "weak"), [INFO] [stderr] ... | [INFO] [stderr] 29 | | &BreakStrength::XStrong => write!(f, "x-strong"), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | BreakStrength::NoStrength => write!(f, "none"), [INFO] [stderr] 25 | BreakStrength::XWeak => write!(f, "x-weak"), [INFO] [stderr] 26 | BreakStrength::Weak => write!(f, "weak"), [INFO] [stderr] 27 | BreakStrength::Medium => write!(f, "medium"), [INFO] [stderr] 28 | BreakStrength::Strong => write!(f, "strong"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ssml_constants/mod.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | } else if s.ends_with("s") && s != "s" { [INFO] [stderr] | ^^^ help: try using a char instead: `'s'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ssml_constants/mod.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | let mut as_split = s.split("s"); [INFO] [stderr] | ^^^ help: try using a char instead: `'s'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / match self { [INFO] [stderr] 124 | | &PhonemeAlphabet::Ipa => write!(f, "ipa"), [INFO] [stderr] 125 | | &PhonemeAlphabet::XSampa => write!(f, "x-sampa"), [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *self { [INFO] [stderr] 124 | PhonemeAlphabet::Ipa => write!(f, "ipa"), [INFO] [stderr] 125 | PhonemeAlphabet::XSampa => write!(f, "x-sampa"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / match self { [INFO] [stderr] 156 | | &ProsodyRate::XSlow => write!(f, "x-slow"), [INFO] [stderr] 157 | | &ProsodyRate::Slow => write!(f, "slow"), [INFO] [stderr] 158 | | &ProsodyRate::Medium => write!(f, "medium"), [INFO] [stderr] 159 | | &ProsodyRate::Fast => write!(f, "fast"), [INFO] [stderr] 160 | | &ProsodyRate::XFast => write!(f, "x-fast"), [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *self { [INFO] [stderr] 156 | ProsodyRate::XSlow => write!(f, "x-slow"), [INFO] [stderr] 157 | ProsodyRate::Slow => write!(f, "slow"), [INFO] [stderr] 158 | ProsodyRate::Medium => write!(f, "medium"), [INFO] [stderr] 159 | ProsodyRate::Fast => write!(f, "fast"), [INFO] [stderr] 160 | ProsodyRate::XFast => write!(f, "x-fast"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / match self { [INFO] [stderr] 192 | | &WordRole::Verb => write!(f, "amazon:VB"), [INFO] [stderr] 193 | | &WordRole::PastTense => write!(f, "amazon:VBD"), [INFO] [stderr] 194 | | &WordRole::PresentTense => write!(f, "amazon:SENSE_1"), [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 191 | match *self { [INFO] [stderr] 192 | WordRole::Verb => write!(f, "amazon:VB"), [INFO] [stderr] 193 | WordRole::PastTense => write!(f, "amazon:VBD"), [INFO] [stderr] 194 | WordRole::PresentTense => write!(f, "amazon:SENSE_1"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | / match self { [INFO] [stderr] 223 | | &AmazonEffect::Whispered => write!(f, "whispered"), [INFO] [stderr] 224 | | &AmazonEffect::Drc => write!(f, "drc"), [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | match *self { [INFO] [stderr] 223 | AmazonEffect::Whispered => write!(f, "whispered"), [INFO] [stderr] 224 | AmazonEffect::Drc => write!(f, "drc"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | / match self { [INFO] [stderr] 256 | | &BreathVolumes::Def => write!(f, "default"), [INFO] [stderr] 257 | | &BreathVolumes::XSoft => write!(f, "x-soft"), [INFO] [stderr] 258 | | &BreathVolumes::Soft => write!(f, "soft"), [INFO] [stderr] ... | [INFO] [stderr] 261 | | &BreathVolumes::XLoud => write!(f, "x-loud"), [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 255 | match *self { [INFO] [stderr] 256 | BreathVolumes::Def => write!(f, "default"), [INFO] [stderr] 257 | BreathVolumes::XSoft => write!(f, "x-soft"), [INFO] [stderr] 258 | BreathVolumes::Soft => write!(f, "soft"), [INFO] [stderr] 259 | BreathVolumes::Medium => write!(f, "medium"), [INFO] [stderr] 260 | BreathVolumes::Loud => write!(f, "loud"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | / match self { [INFO] [stderr] 297 | | &BreathDuration::Def => write!(f, "default"), [INFO] [stderr] 298 | | &BreathDuration::XShort => write!(f, "x-short"), [INFO] [stderr] 299 | | &BreathDuration::Short => write!(f, "short"), [INFO] [stderr] ... | [INFO] [stderr] 302 | | &BreathDuration::XLong => write!(f, "x-long"), [INFO] [stderr] 303 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 296 | match *self { [INFO] [stderr] 297 | BreathDuration::Def => write!(f, "default"), [INFO] [stderr] 298 | BreathDuration::XShort => write!(f, "x-short"), [INFO] [stderr] 299 | BreathDuration::Short => write!(f, "short"), [INFO] [stderr] 300 | BreathDuration::Medium => write!(f, "medium"), [INFO] [stderr] 301 | BreathDuration::Long => write!(f, "long"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:337:5 [INFO] [stderr] | [INFO] [stderr] 337 | / match self { [INFO] [stderr] 338 | | &AutoBreathFrequency::Def => write!(f, "default"), [INFO] [stderr] 339 | | &AutoBreathFrequency::XLow => write!(f, "x-low"), [INFO] [stderr] 340 | | &AutoBreathFrequency::Low => write!(f, "low"), [INFO] [stderr] ... | [INFO] [stderr] 343 | | &AutoBreathFrequency::XHigh => write!(f, "x-high"), [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 337 | match *self { [INFO] [stderr] 338 | AutoBreathFrequency::Def => write!(f, "default"), [INFO] [stderr] 339 | AutoBreathFrequency::XLow => write!(f, "x-low"), [INFO] [stderr] 340 | AutoBreathFrequency::Low => write!(f, "low"), [INFO] [stderr] 341 | AutoBreathFrequency::Medium => write!(f, "medium"), [INFO] [stderr] 342 | AutoBreathFrequency::High => write!(f, "high"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ssml_constants/mod.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | / match self { [INFO] [stderr] 374 | | &PhonationVolume::Soft => write!(f, "soft") [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 373 | match *self { [INFO] [stderr] 374 | PhonationVolume::Soft => write!(f, "soft") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/xml_writer.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | elem.push_attribute(("xml:lang", &*lang.unwrap_or("en-US".to_owned()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "en-US".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/xml_writer.rs:91:59 [INFO] [stderr] | [INFO] [stderr] 91 | elem.push_attribute(("onlangfailure", &*onlangfailure.unwrap_or("processorchoice".to_owned()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "processorchoice".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/xml_writer.rs:239:59 [INFO] [stderr] | [INFO] [stderr] 239 | elem.push_attribute(("onlangfailure", &*onlangfailure.unwrap_or("processorchoice".to_owned()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "processorchoice".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/xml_writer.rs:832:50 [INFO] [stderr] | [INFO] [stderr] 832 | elem.push_attribute(("vocal-tract-length", &*format!("{}", factor))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `factor.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.92s [INFO] running `"docker" "inspect" "05d10b14bbc045e8de82fbfcc960b20a12fdf45f9d234ec876141e75cbc653db"` [INFO] running `"docker" "rm" "-f" "05d10b14bbc045e8de82fbfcc960b20a12fdf45f9d234ec876141e75cbc653db"` [INFO] [stdout] 05d10b14bbc045e8de82fbfcc960b20a12fdf45f9d234ec876141e75cbc653db