[INFO] crate text-minimap 0.1.0 is already in cache [INFO] extracting crate text-minimap 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/text-minimap/0.1.0 [INFO] extracting crate text-minimap 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/text-minimap/0.1.0 [INFO] validating manifest of text-minimap-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of text-minimap-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing text-minimap-0.1.0 [INFO] finished frobbing text-minimap-0.1.0 [INFO] frobbed toml for text-minimap-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/text-minimap/0.1.0/Cargo.toml [INFO] started frobbing text-minimap-0.1.0 [INFO] finished frobbing text-minimap-0.1.0 [INFO] frobbed toml for text-minimap-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/text-minimap/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting text-minimap-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/text-minimap/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4097f54979eb3b0a54daf2e9c015d1d55d5cbafec9ac00a9746923639ceb0af9 [INFO] running `"docker" "start" "-a" "4097f54979eb3b0a54daf2e9c015d1d55d5cbafec9ac00a9746923639ceb0af9"` [INFO] [stderr] Checking text-minimap v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> lib/mod.rs:167:58 [INFO] [stderr] | [INFO] [stderr] 167 | debug_assert_eq!(ch, byte_to_braillechar((bin2 * 16 + bin1))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> lib/mod.rs:167:58 [INFO] [stderr] | [INFO] [stderr] 167 | debug_assert_eq!(ch, byte_to_braillechar((bin2 * 16 + bin1))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> lib/mod.rs:167:58 [INFO] [stderr] | [INFO] [stderr] 167 | debug_assert_eq!(ch, byte_to_braillechar((bin2 * 16 + bin1))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> lib/mod.rs:167:58 [INFO] [stderr] | [INFO] [stderr] 167 | debug_assert_eq!(ch, byte_to_braillechar((bin2 * 16 + bin1))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> lib/mod.rs:52:14 [INFO] [stderr] | [INFO] [stderr] 52 | let nb = nb as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(nb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((nb >> 0) & 0x7)` [INFO] [stderr] --> lib/mod.rs:54:11 [INFO] [stderr] | [INFO] [stderr] 54 | ub |= ((nb >> 0) & 0x7) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `nb` [INFO] [stderr] --> lib/mod.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | ub |= ((nb >> 0) & 0x7) << 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bin2 * 16` [INFO] [stderr] --> lib/mod.rs:70:33 [INFO] [stderr] | [INFO] [stderr] 70 | byte_to_braillechar(bin2 * 16 + 0), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> lib/mod.rs:52:14 [INFO] [stderr] | [INFO] [stderr] 52 | let nb = nb as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(nb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((nb >> 0) & 0x7)` [INFO] [stderr] --> lib/mod.rs:54:11 [INFO] [stderr] | [INFO] [stderr] 54 | ub |= ((nb >> 0) & 0x7) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `nb` [INFO] [stderr] --> lib/mod.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | ub |= ((nb >> 0) & 0x7) << 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bin2 * 16` [INFO] [stderr] --> lib/mod.rs:70:33 [INFO] [stderr] | [INFO] [stderr] 70 | byte_to_braillechar(bin2 * 16 + 0), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Settings` [INFO] [stderr] --> lib/mod.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | / pub fn new() -> Self { [INFO] [stderr] 271 | | Settings { [INFO] [stderr] 272 | | xscale: 1, [INFO] [stderr] 273 | | yscale: 1, [INFO] [stderr] 274 | | } [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Settings` [INFO] [stderr] --> lib/mod.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | / pub fn new() -> Self { [INFO] [stderr] 271 | | Settings { [INFO] [stderr] 272 | | xscale: 1, [INFO] [stderr] 273 | | yscale: 1, [INFO] [stderr] 274 | | } [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.93s [INFO] running `"docker" "inspect" "4097f54979eb3b0a54daf2e9c015d1d55d5cbafec9ac00a9746923639ceb0af9"` [INFO] running `"docker" "rm" "-f" "4097f54979eb3b0a54daf2e9c015d1d55d5cbafec9ac00a9746923639ceb0af9"` [INFO] [stdout] 4097f54979eb3b0a54daf2e9c015d1d55d5cbafec9ac00a9746923639ceb0af9