[INFO] crate testclourse 0.1.0 is already in cache [INFO] extracting crate testclourse 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/testclourse/0.1.0 [INFO] extracting crate testclourse 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/testclourse/0.1.0 [INFO] validating manifest of testclourse-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of testclourse-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing testclourse-0.1.0 [INFO] finished frobbing testclourse-0.1.0 [INFO] frobbed toml for testclourse-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/testclourse/0.1.0/Cargo.toml [INFO] started frobbing testclourse-0.1.0 [INFO] finished frobbing testclourse-0.1.0 [INFO] frobbed toml for testclourse-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/testclourse/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting testclourse-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/testclourse/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbd4433a1df48f27a15d8c161190e63fce274dfde67129ba9915ae4ec5ccfbcc [INFO] running `"docker" "start" "-a" "fbd4433a1df48f27a15d8c161190e63fce274dfde67129ba9915ae4ec5ccfbcc"` [INFO] [stderr] Checking testclourse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | let v = (self.caculation)(arg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 66 | | if random_number == 3 { [INFO] [stderr] 67 | | println!("Take a break today! Remember to stay hydrated!"); [INFO] [stderr] 68 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | } else if random_number == 3 { [INFO] [stderr] 66 | println!("Take a break today! Remember to stay hydrated!"); [INFO] [stderr] 67 | } else { [INFO] [stderr] 68 | println!( [INFO] [stderr] 69 | "Today, run for {} minutes!", [INFO] [stderr] 70 | expensive_result.value(intensity) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | let v = (self.caculation)(arg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 66 | | if random_number == 3 { [INFO] [stderr] 67 | | println!("Take a break today! Remember to stay hydrated!"); [INFO] [stderr] 68 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | } else if random_number == 3 { [INFO] [stderr] 66 | println!("Take a break today! Remember to stay hydrated!"); [INFO] [stderr] 67 | } else { [INFO] [stderr] 68 | println!( [INFO] [stderr] 69 | "Today, run for {} minutes!", [INFO] [stderr] 70 | expensive_result.value(intensity) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.22s [INFO] running `"docker" "inspect" "fbd4433a1df48f27a15d8c161190e63fce274dfde67129ba9915ae4ec5ccfbcc"` [INFO] running `"docker" "rm" "-f" "fbd4433a1df48f27a15d8c161190e63fce274dfde67129ba9915ae4ec5ccfbcc"` [INFO] [stdout] fbd4433a1df48f27a15d8c161190e63fce274dfde67129ba9915ae4ec5ccfbcc