[INFO] crate test-assets 0.2.0 is already in cache
[INFO] extracting crate test-assets 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/test-assets/0.2.0
[INFO] extracting crate test-assets 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/test-assets/0.2.0
[INFO] validating manifest of test-assets-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of test-assets-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing test-assets-0.2.0
[INFO] finished frobbing test-assets-0.2.0
[INFO] frobbed toml for test-assets-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/test-assets/0.2.0/Cargo.toml
[INFO] started frobbing test-assets-0.2.0
[INFO] finished frobbing test-assets-0.2.0
[INFO] frobbed toml for test-assets-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/test-assets/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting test-assets-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/test-assets/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 612b60dd6d132ee325de91e41fffc74db612f1592e2a5065ede43f8243885983
[INFO] running `"docker" "start" "-a" "612b60dd6d132ee325de91e41fffc74db612f1592e2a5065ede43f8243885983"`
[INFO] [stderr]    Compiling curl-sys v0.4.16
[INFO] [stderr]     Checking sha2 v0.1.2
[INFO] [stderr]     Checking curl v0.4.19
[INFO] [stderr]     Checking test-assets v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]   --> src/hash_list.rs:42:4
[INFO] [stderr]    |
[INFO] [stderr] 42 |             name_to_hash_map : name_to_hash_map,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_to_hash_map`
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:8:24
[INFO] [stderr]    |
[INFO] [stderr] 8  | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]    |                        ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/hash_list.rs:42:4
[INFO] [stderr]    |
[INFO] [stderr] 42 |             name_to_hash_map : name_to_hash_map,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_to_hash_map`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]   --> src/hash_list.rs:25:3
[INFO] [stderr]    |
[INFO] [stderr] 25 |         return Ok(try!(HashList::from_reader(&mut brdr)));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(try!(HashList::from_reader(&mut brdr)))`
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:8:24
[INFO] [stderr]    |
[INFO] [stderr] 8  | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]    |                        ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]   --> src/hash_list.rs:41:3
[INFO] [stderr]    |
[INFO] [stderr] 41 |           return Ok(HashList {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 42 | |             name_to_hash_map : name_to_hash_map,
[INFO] [stderr] 43 | |         });
[INFO] [stderr]    | |___________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 41 |         Ok(HashList {
[INFO] [stderr] 42 |             name_to_hash_map : name_to_hash_map,
[INFO] [stderr] 43 |         })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]   --> src/hash_list.rs:61:3
[INFO] [stderr]    |
[INFO] [stderr] 61 |           return HashList {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 62 | |             name_to_hash_map : HashMap::new(),
[INFO] [stderr] 63 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 61 |         HashList {
[INFO] [stderr] 62 |             name_to_hash_map : HashMap::new(),
[INFO] [stderr] 63 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:83:3
[INFO] [stderr]    |
[INFO] [stderr] 83 |         return res;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:106:3
[INFO] [stderr]     |
[INFO] [stderr] 106 |         return Ok(res);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:116:3
[INFO] [stderr]     |
[INFO] [stderr] 116 |         return res;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:170:2
[INFO] [stderr]     |
[INFO] [stderr] 170 |     return Ok(DownloadOutcome::WithHash(Sha256Hash::from_digest(&mut hasher)));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DownloadOutcome::WithHash(Sha256Hash::from_digest(&mut hasher)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hash_list.rs:25:3
[INFO] [stderr]    |
[INFO] [stderr] 25 |         return Ok(try!(HashList::from_reader(&mut brdr)));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(try!(HashList::from_reader(&mut brdr)))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hash_list.rs:41:3
[INFO] [stderr]    |
[INFO] [stderr] 41 |           return Ok(HashList {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 42 | |             name_to_hash_map : name_to_hash_map,
[INFO] [stderr] 43 | |         });
[INFO] [stderr]    | |___________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 41 |         Ok(HashList {
[INFO] [stderr] 42 |             name_to_hash_map : name_to_hash_map,
[INFO] [stderr] 43 |         })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hash_list.rs:61:3
[INFO] [stderr]    |
[INFO] [stderr] 61 |           return HashList {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 62 | |             name_to_hash_map : HashMap::new(),
[INFO] [stderr] 63 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 61 |         HashList {
[INFO] [stderr] 62 |             name_to_hash_map : HashMap::new(),
[INFO] [stderr] 63 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:83:3
[INFO] [stderr]    |
[INFO] [stderr] 83 |         return res;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:106:3
[INFO] [stderr]     |
[INFO] [stderr] 106 |         return Ok(res);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:116:3
[INFO] [stderr]     |
[INFO] [stderr] 116 |         return res;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:170:2
[INFO] [stderr]     |
[INFO] [stderr] 170 |     return Ok(DownloadOutcome::WithHash(Sha256Hash::from_digest(&mut hasher)));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DownloadOutcome::WithHash(Sha256Hash::from_digest(&mut hasher)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 8 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `test-assets`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/hash_list.rs:32:24
[INFO] [stderr]    |
[INFO] [stderr] 32 |             if line.starts_with("#") {
[INFO] [stderr]    |                                 ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/hash_list.rs:35:29
[INFO] [stderr]    |
[INFO] [stderr] 35 |             let mut spi = line.split(" ");
[INFO] [stderr]    |                                      ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/hash_list.rs:55:4
[INFO] [stderr]    |
[INFO] [stderr] 55 |             try!(bwrtr.write(format!("{} {}\n", hash.to_hex(), name).as_bytes()));
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:113:24
[INFO] [stderr]     |
[INFO] [stderr] 113 |             res.push(from_digit(*v as u32 >> 4, 16).unwrap());
[INFO] [stderr]     |                                 ^^^^^^^^^ help: try: `u32::from(*v)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:114:24
[INFO] [stderr]     |
[INFO] [stderr] 114 |             res.push(from_digit(*v as u32 & 15, 16).unwrap());
[INFO] [stderr]     |                                 ^^^^^^^^^ help: try: `u32::from(*v)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:203:3
[INFO] [stderr]     |
[INFO] [stderr] 203 |           match &outcome {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 204 | |             &DownloadFailed(code) => return Err(TaError::DownloadFailed(code)),
[INFO] [stderr] 205 | |             &WithHash(ref hash) => hash_list.add_entry(&tfile.filename, hash),
[INFO] [stderr] 206 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 203 |         match outcome {
[INFO] [stderr] 204 |             DownloadFailed(code) => return Err(TaError::DownloadFailed(code)),
[INFO] [stderr] 205 |             WithHash(ref hash) => hash_list.add_entry(&tfile.filename, hash),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:209:4
[INFO] [stderr]     |
[INFO] [stderr] 209 |               match &outcome {
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 210 | |                 &DownloadFailed(code) => println!("Download failed with code {}", code),
[INFO] [stderr] 211 | |                 &WithHash(ref found_hash) => {
[INFO] [stderr] 212 | |                     if found_hash == &tfile_hash {
[INFO] [stderr] ...   |
[INFO] [stderr] 218 | |                  },
[INFO] [stderr] 219 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 209 |             match outcome {
[INFO] [stderr] 210 |                 DownloadFailed(code) => println!("Download failed with code {}", code),
[INFO] [stderr] 211 |                 WithHash(ref found_hash) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `test-assets`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "612b60dd6d132ee325de91e41fffc74db612f1592e2a5065ede43f8243885983"`
[INFO] running `"docker" "rm" "-f" "612b60dd6d132ee325de91e41fffc74db612f1592e2a5065ede43f8243885983"`
[INFO] [stdout] 612b60dd6d132ee325de91e41fffc74db612f1592e2a5065ede43f8243885983