[INFO] crate test-assembler 0.1.5 is already in cache [INFO] extracting crate test-assembler 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/test-assembler/0.1.5 [INFO] extracting crate test-assembler 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/test-assembler/0.1.5 [INFO] validating manifest of test-assembler-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of test-assembler-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing test-assembler-0.1.5 [INFO] finished frobbing test-assembler-0.1.5 [INFO] frobbed toml for test-assembler-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/test-assembler/0.1.5/Cargo.toml [INFO] started frobbing test-assembler-0.1.5 [INFO] finished frobbing test-assembler-0.1.5 [INFO] frobbed toml for test-assembler-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/test-assembler/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting test-assembler-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/test-assembler/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca5262347cf211a35bcaa7442789ae8d951963f2f3f415985e1b2529f15cab05 [INFO] running `"docker" "start" "-a" "ca5262347cf211a35bcaa7442789ae8d951963f2f3f415985e1b2529f15cab05"` [INFO] [stderr] Checking test-assembler v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:465:13 [INFO] [stderr] | [INFO] [stderr] 465 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:634:17 [INFO] [stderr] | [INFO] [stderr] 634 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:465:13 [INFO] [stderr] | [INFO] [stderr] 465 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:634:17 [INFO] [stderr] | [INFO] [stderr] 634 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:912:15 [INFO] [stderr] | [INFO] [stderr] 912 | let val = 0x12345678; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:919:15 [INFO] [stderr] | [INFO] [stderr] 919 | let val = 0x12345678; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1024:22 [INFO] [stderr] | [INFO] [stderr] 1024 | assert_eq!(s.D32(0xABCD1234).L32(0xABCD1234).B32(0xABCD1234) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xABCD_1234` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1024:38 [INFO] [stderr] | [INFO] [stderr] 1024 | assert_eq!(s.D32(0xABCD1234).L32(0xABCD1234).B32(0xABCD1234) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xABCD_1234` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1024:54 [INFO] [stderr] | [INFO] [stderr] 1024 | assert_eq!(s.D32(0xABCD1234).L32(0xABCD1234).B32(0xABCD1234) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xABCD_1234` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1034:22 [INFO] [stderr] | [INFO] [stderr] 1034 | assert_eq!(s.D64(0x12345678ABCDEFFF) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_ABCD_EFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1035:21 [INFO] [stderr] | [INFO] [stderr] 1035 | .L64(0x12345678ABCDEFFF) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_ABCD_EFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1036:21 [INFO] [stderr] | [INFO] [stderr] 1036 | .B64(0x12345678ABCDEFFF) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_ABCD_EFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1064:31 [INFO] [stderr] | [INFO] [stderr] 1064 | let l = Label::from_const(0xABCD1234); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xABCD_1234` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1075:31 [INFO] [stderr] | [INFO] [stderr] 1075 | let l = Label::from_const(0xABCD12345678F00D); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xABCD_1234_5678_F00D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1135:43 [INFO] [stderr] | [INFO] [stderr] 1135 | self.B8(0x12).B16(0x3456).B32(0x7890abcd) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7890_abcd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self { [INFO] [stderr] 115 | | &BindingValue::Constant(v) => write!(f, "Constant({})", v), [INFO] [stderr] 116 | | &BindingValue::From(ref b, v) => write!(f, "From({:?}, {})", b, v), [INFO] [stderr] 117 | | &BindingValue::Unconstrained => write!(f, "Unconstrained"), [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *self { [INFO] [stderr] 115 | BindingValue::Constant(v) => write!(f, "Constant({})", v), [INFO] [stderr] 116 | BindingValue::From(ref b, v) => write!(f, "From({:?}, {})", b, v), [INFO] [stderr] 117 | BindingValue::Unconstrained => write!(f, "Unconstrained"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match self.value.borrow().deref() { [INFO] [stderr] 145 | | &BindingValue::From(ref b, offset) => { [INFO] [stderr] 146 | | let (base, base_offset) = b.get_base_and_offset(); [INFO] [stderr] 147 | | (base, base_offset + offset) [INFO] [stderr] ... | [INFO] [stderr] 150 | | _ => (self.clone(), 0), [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *self.value.borrow().deref() { [INFO] [stderr] 145 | BindingValue::From(ref b, offset) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:313:5 [INFO] [stderr] | [INFO] [stderr] 313 | / fn deref<'a>(&'a self) -> &'a RealLabel { [INFO] [stderr] 314 | | let &Label(ref inner) = self; [INFO] [stderr] 315 | | inner.deref() [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Section` [INFO] [stderr] --> src/lib.rs:458:5 [INFO] [stderr] | [INFO] [stderr] 458 | / pub fn new() -> Section { [INFO] [stderr] 459 | | Section::with_endian(DEFAULT_ENDIAN) [INFO] [stderr] 460 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 456 | impl Default for Section { [INFO] [stderr] 457 | fn default() -> Self { [INFO] [stderr] 458 | Self::new() [INFO] [stderr] 459 | } [INFO] [stderr] 460 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:493:43 [INFO] [stderr] | [INFO] [stderr] 493 | let references : Vec = section.references.iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | r.offset = r.offset + current; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r.offset += current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self { [INFO] [stderr] 115 | | &BindingValue::Constant(v) => write!(f, "Constant({})", v), [INFO] [stderr] 116 | | &BindingValue::From(ref b, v) => write!(f, "From({:?}, {})", b, v), [INFO] [stderr] 117 | | &BindingValue::Unconstrained => write!(f, "Unconstrained"), [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *self { [INFO] [stderr] 115 | BindingValue::Constant(v) => write!(f, "Constant({})", v), [INFO] [stderr] 116 | BindingValue::From(ref b, v) => write!(f, "From({:?}, {})", b, v), [INFO] [stderr] 117 | BindingValue::Unconstrained => write!(f, "Unconstrained"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match self.value.borrow().deref() { [INFO] [stderr] 145 | | &BindingValue::From(ref b, offset) => { [INFO] [stderr] 146 | | let (base, base_offset) = b.get_base_and_offset(); [INFO] [stderr] 147 | | (base, base_offset + offset) [INFO] [stderr] ... | [INFO] [stderr] 150 | | _ => (self.clone(), 0), [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *self.value.borrow().deref() { [INFO] [stderr] 145 | BindingValue::From(ref b, offset) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:313:5 [INFO] [stderr] | [INFO] [stderr] 313 | / fn deref<'a>(&'a self) -> &'a RealLabel { [INFO] [stderr] 314 | | let &Label(ref inner) = self; [INFO] [stderr] 315 | | inner.deref() [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Section` [INFO] [stderr] --> src/lib.rs:458:5 [INFO] [stderr] | [INFO] [stderr] 458 | / pub fn new() -> Section { [INFO] [stderr] 459 | | Section::with_endian(DEFAULT_ENDIAN) [INFO] [stderr] 460 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 456 | impl Default for Section { [INFO] [stderr] 457 | fn default() -> Self { [INFO] [stderr] 458 | Self::new() [INFO] [stderr] 459 | } [INFO] [stderr] 460 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:493:43 [INFO] [stderr] | [INFO] [stderr] 493 | let references : Vec = section.references.iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | r.offset = r.offset + current; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r.offset += current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.59s [INFO] running `"docker" "inspect" "ca5262347cf211a35bcaa7442789ae8d951963f2f3f415985e1b2529f15cab05"` [INFO] running `"docker" "rm" "-f" "ca5262347cf211a35bcaa7442789ae8d951963f2f3f415985e1b2529f15cab05"` [INFO] [stdout] ca5262347cf211a35bcaa7442789ae8d951963f2f3f415985e1b2529f15cab05