[INFO] crate tessel 0.3.1 is already in cache
[INFO] extracting crate tessel 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/tessel/0.3.1
[INFO] extracting crate tessel 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tessel/0.3.1
[INFO] validating manifest of tessel-0.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tessel-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tessel-0.3.1
[INFO] finished frobbing tessel-0.3.1
[INFO] frobbed toml for tessel-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/tessel/0.3.1/Cargo.toml
[INFO] started frobbing tessel-0.3.1
[INFO] finished frobbing tessel-0.3.1
[INFO] frobbed toml for tessel-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tessel/0.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tessel-0.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tessel/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6dffef937127eee36d513342d0b9f90d71edcf5b3998289e49214169b3c8d59d
[INFO] running `"docker" "start" "-a" "6dffef937127eee36d513342d0b9f90d71edcf5b3998289e49214169b3c8d59d"`
[INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other binary targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a binary target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/src/main.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autobins = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `hello-rust`,
[INFO] [stderr] please set bin.path in Cargo.toml
[INFO] [stderr]     Checking atomic-option v0.1.2
[INFO] [stderr]     Checking unix_socket v0.5.0
[INFO] [stderr]     Checking tessel v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             socket: socket
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:125:13
[INFO] [stderr]     |
[INFO] [stderr] 125 |             available: available,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 |             index: index,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:186:13
[INFO] [stderr]     |
[INFO] [stderr] 186 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:219:13
[INFO] [stderr]     |
[INFO] [stderr] 219 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:254:49
[INFO] [stderr]     |
[INFO] [stderr] 254 |         sock.write_command(Command::EnableI2c { baud: baud }).unwrap();
[INFO] [stderr]     |                                                 ^^^^^^^^^^ help: replace it with: `baud`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:347:13
[INFO] [stderr]     |
[INFO] [stderr] 347 |             file: file,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             socket: socket
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:125:13
[INFO] [stderr]     |
[INFO] [stderr] 125 |             available: available,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 |             index: index,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:186:13
[INFO] [stderr]     |
[INFO] [stderr] 186 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:219:13
[INFO] [stderr]     |
[INFO] [stderr] 219 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:254:49
[INFO] [stderr]     |
[INFO] [stderr] 254 |         sock.write_command(Command::EnableI2c { baud: baud }).unwrap();
[INFO] [stderr]     |                                                 ^^^^^^^^^^ help: replace it with: `baud`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:347:13
[INFO] [stderr]     |
[INFO] [stderr] 347 |             file: file,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 | const PORT_A_UDS_PATH: &'static str = "/var/run/tessel/port_a";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 | const PORT_B_UDS_PATH: &'static str = "/var/run/tessel/port_b";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:245:13
[INFO] [stderr]     |
[INFO] [stderr] 245 |             return u8::min_value();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `u8::min_value()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:248:13
[INFO] [stderr]     |
[INFO] [stderr] 248 |             return low as u8;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low as u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:295:9
[INFO] [stderr]     |
[INFO] [stderr] 295 |         return sock.read_exact(read_buf);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sock.read_exact(read_buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:310:9
[INFO] [stderr]     |
[INFO] [stderr] 310 |         return sock.read_exact(read_buf);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sock.read_exact(read_buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 | const PORT_A_UDS_PATH: &'static str = "/var/run/tessel/port_a";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 | const PORT_B_UDS_PATH: &'static str = "/var/run/tessel/port_b";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:245:13
[INFO] [stderr]     |
[INFO] [stderr] 245 |             return u8::min_value();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `u8::min_value()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:248:13
[INFO] [stderr]     |
[INFO] [stderr] 248 |             return low as u8;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low as u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:295:9
[INFO] [stderr]     |
[INFO] [stderr] 295 |         return sock.read_exact(read_buf);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sock.read_exact(read_buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:310:9
[INFO] [stderr]     |
[INFO] [stderr] 310 |         return sock.read_exact(read_buf);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sock.read_exact(read_buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Tessel`
[INFO] [stderr]   --> src/lib.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     pub fn new() -> Tessel {
[INFO] [stderr] 61 | |         // Create models for the four LEDs.
[INFO] [stderr] 62 | |         let red_led = LED::new("red", "error");
[INFO] [stderr] 63 | |         let amber_led = LED::new("amber", "wlan");
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |         }
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 45 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/lib.rs:150:15
[INFO] [stderr]     |
[INFO] [stderr] 150 |     fn select<'b>(&self, socket: Arc<Mutex<PortSocket>>) -> Self::Output {
[INFO] [stderr]     |               ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/lib.rs:160:15
[INFO] [stderr]     |
[INFO] [stderr] 160 |     fn select<'b>(&self, socket: Arc<Mutex<PortSocket>>) -> Self::Output {
[INFO] [stderr]     |               ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/lib.rs:170:15
[INFO] [stderr]     |
[INFO] [stderr] 170 |     fn select<'b>(&self, socket: Arc<Mutex<PortSocket>>) -> Self::Output {
[INFO] [stderr]     |               ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:232:37
[INFO] [stderr]     |
[INFO] [stderr] 232 |         let mut intermediate: f64 = MCU_MAX_SPEED as f64 / frequency as f64;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(MCU_MAX_SPEED)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:232:60
[INFO] [stderr]     |
[INFO] [stderr] 232 |         let mut intermediate: f64 = MCU_MAX_SPEED as f64 / frequency as f64;
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^ help: try: `f64::from(frequency)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:233:9
[INFO] [stderr]     |
[INFO] [stderr] 233 |         intermediate = intermediate - MCU_MAX_SPEED as f64 * MCU_MAX_SCL_RISE_TIME_NS;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intermediate -= MCU_MAX_SPEED as f64 * MCU_MAX_SCL_RISE_TIME_NS`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:233:39
[INFO] [stderr]     |
[INFO] [stderr] 233 |         intermediate = intermediate - MCU_MAX_SPEED as f64 * MCU_MAX_SCL_RISE_TIME_NS;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(MCU_MAX_SPEED)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:235:39
[INFO] [stderr]     |
[INFO] [stderr] 235 |         intermediate = intermediate / MCU_MAGIC_DIV_FACTOR_FOR_I2C_BAUD as f64 -
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(MCU_MAGIC_DIV_FACTOR_FOR_I2C_BAUD)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:236:24
[INFO] [stderr]     |
[INFO] [stderr] 236 |                        MCU_MAGIC_SUBTRACT_FACTOR_FOR_I2C_BAUD as f64;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(MCU_MAGIC_SUBTRACT_FACTOR_FOR_I2C_BAUD)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:239:36
[INFO] [stderr]     |
[INFO] [stderr] 239 |         let low = intermediate.min(u8::max_value() as f64);
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(u8::max_value())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:243:27
[INFO] [stderr]     |
[INFO] [stderr] 243 |         if (low as i64) < u8::min_value() as i64 {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u8::min_value())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:392:28
[INFO] [stderr]     |
[INFO] [stderr] 392 |           let string_value = match new_value {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 393 | |             true => b'1',
[INFO] [stderr] 394 | |             false => b'0',
[INFO] [stderr] 395 | |         };
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if new_value { b'1' } else { b'0' }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Tessel`
[INFO] [stderr]   --> src/lib.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     pub fn new() -> Tessel {
[INFO] [stderr] 61 | |         // Create models for the four LEDs.
[INFO] [stderr] 62 | |         let red_led = LED::new("red", "error");
[INFO] [stderr] 63 | |         let amber_led = LED::new("amber", "wlan");
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |         }
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 45 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/lib.rs:150:15
[INFO] [stderr]     |
[INFO] [stderr] 150 |     fn select<'b>(&self, socket: Arc<Mutex<PortSocket>>) -> Self::Output {
[INFO] [stderr]     |               ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/lib.rs:160:15
[INFO] [stderr]     |
[INFO] [stderr] 160 |     fn select<'b>(&self, socket: Arc<Mutex<PortSocket>>) -> Self::Output {
[INFO] [stderr]     |               ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/lib.rs:170:15
[INFO] [stderr]     |
[INFO] [stderr] 170 |     fn select<'b>(&self, socket: Arc<Mutex<PortSocket>>) -> Self::Output {
[INFO] [stderr]     |               ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:232:37
[INFO] [stderr]     |
[INFO] [stderr] 232 |         let mut intermediate: f64 = MCU_MAX_SPEED as f64 / frequency as f64;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(MCU_MAX_SPEED)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:232:60
[INFO] [stderr]     |
[INFO] [stderr] 232 |         let mut intermediate: f64 = MCU_MAX_SPEED as f64 / frequency as f64;
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^ help: try: `f64::from(frequency)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:233:9
[INFO] [stderr]     |
[INFO] [stderr] 233 |         intermediate = intermediate - MCU_MAX_SPEED as f64 * MCU_MAX_SCL_RISE_TIME_NS;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intermediate -= MCU_MAX_SPEED as f64 * MCU_MAX_SCL_RISE_TIME_NS`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:233:39
[INFO] [stderr]     |
[INFO] [stderr] 233 |         intermediate = intermediate - MCU_MAX_SPEED as f64 * MCU_MAX_SCL_RISE_TIME_NS;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(MCU_MAX_SPEED)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:235:39
[INFO] [stderr]     |
[INFO] [stderr] 235 |         intermediate = intermediate / MCU_MAGIC_DIV_FACTOR_FOR_I2C_BAUD as f64 -
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(MCU_MAGIC_DIV_FACTOR_FOR_I2C_BAUD)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:236:24
[INFO] [stderr]     |
[INFO] [stderr] 236 |                        MCU_MAGIC_SUBTRACT_FACTOR_FOR_I2C_BAUD as f64;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(MCU_MAGIC_SUBTRACT_FACTOR_FOR_I2C_BAUD)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:239:36
[INFO] [stderr]     |
[INFO] [stderr] 239 |         let low = intermediate.min(u8::max_value() as f64);
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(u8::max_value())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:243:27
[INFO] [stderr]     |
[INFO] [stderr] 243 |         if (low as i64) < u8::min_value() as i64 {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u8::min_value())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:392:28
[INFO] [stderr]     |
[INFO] [stderr] 392 |           let string_value = match new_value {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 393 | |             true => b'1',
[INFO] [stderr] 394 | |             false => b'0',
[INFO] [stderr] 395 | |         };
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if new_value { b'1' } else { b'0' }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] error[E0463]: can't find crate for `alloc_system`
[INFO] [stderr]  --> src/main.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | extern crate alloc_system;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] For more information about this error, try `rustc --explain E0463`.
[INFO] [stderr] error: Could not compile `tessel`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error[E0463]: can't find crate for `alloc_system`
[INFO] [stderr]  --> src/main.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | extern crate alloc_system;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] For more information about this error, try `rustc --explain E0463`.
[INFO] [stderr] error: Could not compile `tessel`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "6dffef937127eee36d513342d0b9f90d71edcf5b3998289e49214169b3c8d59d"`
[INFO] running `"docker" "rm" "-f" "6dffef937127eee36d513342d0b9f90d71edcf5b3998289e49214169b3c8d59d"`
[INFO] [stdout] 6dffef937127eee36d513342d0b9f90d71edcf5b3998289e49214169b3c8d59d