[INFO] crate tess2-sys 0.0.1 is already in cache [INFO] extracting crate tess2-sys 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/tess2-sys/0.0.1 [INFO] extracting crate tess2-sys 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tess2-sys/0.0.1 [INFO] validating manifest of tess2-sys-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tess2-sys-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tess2-sys-0.0.1 [INFO] finished frobbing tess2-sys-0.0.1 [INFO] frobbed toml for tess2-sys-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/tess2-sys/0.0.1/Cargo.toml [INFO] started frobbing tess2-sys-0.0.1 [INFO] finished frobbing tess2-sys-0.0.1 [INFO] frobbed toml for tess2-sys-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tess2-sys/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tess2-sys-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tess2-sys/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f98778ef22e0273f1c623d43ad8e9b16cbf2eb0a9ed6a629a7b498fcf718cdf1 [INFO] running `"docker" "start" "-a" "f98778ef22e0273f1c623d43ad8e9b16cbf2eb0a9ed6a629a7b498fcf718cdf1"` [INFO] [stderr] Compiling tess2-sys v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::Config': gcc::Config has been renamed to gcc::Build [INFO] [stderr] --> build.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | gcc::Config::new().include("native/include/") [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | gcc::Config::new().include("native/include/") [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: native/src/geom.c: In function 'tesedgeIntersect': [INFO] [stderr] warning: native/src/geom.c:218:43: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: if( ! VertLeq( o1, d1 )) { Swap( o1, d1 ); } [INFO] [stderr] warning: ^ [INFO] [stderr] warning: native/src/geom.c:219:43: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: if( ! VertLeq( o2, d2 )) { Swap( o2, d2 ); } [INFO] [stderr] warning: ^ [INFO] [stderr] warning: native/src/geom.c:220:43: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: if( ! VertLeq( o1, o2 )) { Swap( o1, o2 ); Swap( d1, d2 ); } [INFO] [stderr] warning: ^ [INFO] [stderr] warning: native/src/geom.c:220:59: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: if( ! VertLeq( o1, o2 )) { Swap( o1, o2 ); Swap( d1, d2 ); } [INFO] [stderr] warning: ^ [INFO] [stderr] warning: native/src/geom.c:241:44: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: if( ! TransLeq( o1, d1 )) { Swap( o1, d1 ); } [INFO] [stderr] warning: ^ [INFO] [stderr] warning: native/src/geom.c:242:44: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: if( ! TransLeq( o2, d2 )) { Swap( o2, d2 ); } [INFO] [stderr] warning: ^ [INFO] [stderr] warning: native/src/geom.c:243:44: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: if( ! TransLeq( o1, o2 )) { Swap( o1, o2 ); Swap( d1, d2 ); } [INFO] [stderr] warning: ^ [INFO] [stderr] warning: native/src/geom.c:243:60: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: if( ! TransLeq( o1, o2 )) { Swap( o1, o2 ); Swap( d1, d2 ); } [INFO] [stderr] warning: ^ [INFO] [stderr] warning: native/src/priorityq.c: In function 'pqInit': [INFO] [stderr] warning: native/src/priorityq.c:385:17: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: Swap( i, j ); [INFO] [stderr] warning: ^ [INFO] [stderr] warning: native/src/priorityq.c:387:16: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: Swap( i, j ); /* Undo last swap */ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:159:80 [INFO] [stderr] | [INFO] [stderr] 159 | println!("Elems:{:?}",std::slice::from_raw_parts(tessGetElements(tess),((tessGetElementCount(tess) as usize)*nvp))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bpv` [INFO] [stderr] --> src/lib.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | let bpv = 2 * std::mem::size_of::(); [INFO] [stderr] | ^^^ help: consider using `_bpv` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | let mut data = [ [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | let mut tess = tessNewTess(0 as *mut _); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | let a = tessNewTess(0 as *mut _); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:145:36 [INFO] [stderr] | [INFO] [stderr] 145 | let mut tess = tessNewTess(0 as *mut _); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/lib.rs:155:135 [INFO] [stderr] | [INFO] [stderr] 155 | println!("STATUS:{:?}", tessTesselate(tess,TessWindingRule::TESS_WINDING_POSITIVE,TessElementType::TESS_POLYGONS,nvp as i32,2,0 as *const _)); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.82s [INFO] running `"docker" "inspect" "f98778ef22e0273f1c623d43ad8e9b16cbf2eb0a9ed6a629a7b498fcf718cdf1"` [INFO] running `"docker" "rm" "-f" "f98778ef22e0273f1c623d43ad8e9b16cbf2eb0a9ed6a629a7b498fcf718cdf1"` [INFO] [stdout] f98778ef22e0273f1c623d43ad8e9b16cbf2eb0a9ed6a629a7b498fcf718cdf1