[INFO] crate terminfo 0.6.1 is already in cache [INFO] extracting crate terminfo 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/terminfo/0.6.1 [INFO] extracting crate terminfo 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/terminfo/0.6.1 [INFO] validating manifest of terminfo-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of terminfo-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing terminfo-0.6.1 [INFO] finished frobbing terminfo-0.6.1 [INFO] frobbed toml for terminfo-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/terminfo/0.6.1/Cargo.toml [INFO] started frobbing terminfo-0.6.1 [INFO] finished frobbing terminfo-0.6.1 [INFO] frobbed toml for terminfo-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/terminfo/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting terminfo-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/terminfo/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdc31b81b1f868d33c033388302923af27cf733ad4881390f1e85bd21ab91202 [INFO] running `"docker" "start" "-a" "fdc31b81b1f868d33c033388302923af27cf733ad4881390f1e85bd21ab91202"` [INFO] [stderr] Compiling terminfo v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | const NONE: u8 = 0b000000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | const PRINT: u8 = 0b000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | const SPACE: u8 = 0b000010; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | const CONTROL: u8 = 0b000100; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | const PIPE: u8 = 0b001000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | const COMMA: u8 = 0b010000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | const EOL: u8 = 0b100000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | const NONE: u8 = 0b000000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | const PRINT: u8 = 0b000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | const SPACE: u8 = 0b000010; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | const CONTROL: u8 = 0b000100; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | const PIPE: u8 = 0b001000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | const COMMA: u8 = 0b010000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/util.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | const EOL: u8 = 0b100000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | key: 732231254413039614, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `732_231_254_413_039_614` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:122:10 [INFO] [stderr] | [INFO] [stderr] 122 | key: 732231254413039614, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `732_231_254_413_039_614` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:176:10 [INFO] [stderr] | [INFO] [stderr] 176 | key: 13158248357090472036, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `13_158_248_357_090_472_036` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:230:10 [INFO] [stderr] | [INFO] [stderr] 230 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:734:10 [INFO] [stderr] | [INFO] [stderr] 734 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:1238:10 [INFO] [stderr] | [INFO] [stderr] 1238 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:1730:10 [INFO] [stderr] | [INFO] [stderr] 1730 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:2199:10 [INFO] [stderr] | [INFO] [stderr] 2199 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | key: 732231254413039614, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `732_231_254_413_039_614` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:122:10 [INFO] [stderr] | [INFO] [stderr] 122 | key: 732231254413039614, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `732_231_254_413_039_614` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:176:10 [INFO] [stderr] | [INFO] [stderr] 176 | key: 13158248357090472036, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `13_158_248_357_090_472_036` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:230:10 [INFO] [stderr] | [INFO] [stderr] 230 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:734:10 [INFO] [stderr] | [INFO] [stderr] 734 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:1238:10 [INFO] [stderr] | [INFO] [stderr] 1238 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:1730:10 [INFO] [stderr] | [INFO] [stderr] 1730 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/terminfo-3dce37407a742777/out/names.rs:2199:10 [INFO] [stderr] | [INFO] [stderr] 2199 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/database.rs:170:28 [INFO] [stderr] | [INFO] [stderr] 170 | if let Some(mut home) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/database.rs:170:28 [INFO] [stderr] | [INFO] [stderr] 170 | if let Some(mut home) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser/util.rs:127:11 [INFO] [stderr] | [INFO] [stderr] 127 | let d = (ch as i32).wrapping_sub(b'0' as i32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser/util.rs:127:36 [INFO] [stderr] | [INFO] [stderr] 127 | let d = (ch as i32).wrapping_sub(b'0' as i32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser/compiled.rs:210:43 [INFO] [stderr] | [INFO] [stderr] 210 | map_opt!(le_i16, |n| if n >= -2 { Some(n as i32) } else { None })) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | Parameter::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 69 | from!(number u8); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | Parameter::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 70 | from!(number i8); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | Parameter::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 71 | from!(number u16); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | Parameter::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 72 | from!(number i16); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/expand.rs:173:2 [INFO] [stderr] | [INFO] [stderr] 173 | fn expand(&self, output: W, parameters: &[Parameter], context: &mut Context) -> error::Result<()> { [INFO] [stderr] | _____^ [INFO] [stderr] 174 | | let mut output = BufWriter::new(output); [INFO] [stderr] 175 | | let mut input = self; [INFO] [stderr] 176 | | let mut params: [Parameter; 9] = Default::default(); [INFO] [stderr] ... | [INFO] [stderr] 539 | | Ok(()) [INFO] [stderr] 540 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:269:35 [INFO] [stderr] | [INFO] [stderr] 269 | stack.push(Parameter::Number(ch as i32)); [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/capability.rs:70:16 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn to_vec(self) -> error::Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/capability.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Value::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 109 | from!(number u8); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/capability.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Value::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 110 | from!(number i8); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/capability.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Value::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 111 | from!(number u16); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/capability.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Value::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 112 | from!(number i16); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser/util.rs:127:11 [INFO] [stderr] | [INFO] [stderr] 127 | let d = (ch as i32).wrapping_sub(b'0' as i32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser/util.rs:127:36 [INFO] [stderr] | [INFO] [stderr] 127 | let d = (ch as i32).wrapping_sub(b'0' as i32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser/compiled.rs:210:43 [INFO] [stderr] | [INFO] [stderr] 210 | map_opt!(le_i16, |n| if n >= -2 { Some(n as i32) } else { None })) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | Parameter::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 69 | from!(number u8); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | Parameter::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 70 | from!(number i8); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | Parameter::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 71 | from!(number u16); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | Parameter::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 72 | from!(number i16); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/expand.rs:173:2 [INFO] [stderr] | [INFO] [stderr] 173 | fn expand(&self, output: W, parameters: &[Parameter], context: &mut Context) -> error::Result<()> { [INFO] [stderr] | _____^ [INFO] [stderr] 174 | | let mut output = BufWriter::new(output); [INFO] [stderr] 175 | | let mut input = self; [INFO] [stderr] 176 | | let mut params: [Parameter; 9] = Default::default(); [INFO] [stderr] ... | [INFO] [stderr] 539 | | Ok(()) [INFO] [stderr] 540 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/expand.rs:269:35 [INFO] [stderr] | [INFO] [stderr] 269 | stack.push(Parameter::Number(ch as i32)); [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/capability.rs:70:16 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn to_vec(self) -> error::Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/capability.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Value::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 109 | from!(number u8); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/capability.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Value::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 110 | from!(number i8); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/capability.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Value::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 111 | from!(number u16); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/capability.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Value::Number(value as i32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 112 | from!(number i16); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/capability.rs:275:4 [INFO] [stderr] | [INFO] [stderr] 275 | pub fn parameters(mut self, $($name: $ty),*) -> Self { [INFO] [stderr] | _____________^ [INFO] [stderr] 276 | | let mut index = 0; [INFO] [stderr] 277 | | [INFO] [stderr] 278 | | $({ [INFO] [stderr] ... | [INFO] [stderr] 283 | | self [INFO] [stderr] 284 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 883 | / define!(string SetAttributes => "set_attributes"; [INFO] [stderr] 884 | | standout: bool, [INFO] [stderr] 885 | | underline: bool, [INFO] [stderr] 886 | | reverse: bool, [INFO] [stderr] ... | [INFO] [stderr] 891 | | protected: bool, [INFO] [stderr] 892 | | alt_charset: bool); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/database.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | let name = names::ALIASES.get(name).map(|s| *s).unwrap_or(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `names::ALIASES.get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/database.rs:134:2 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn new() -> Builder { [INFO] [stderr] | _____^ [INFO] [stderr] 135 | | Builder::default() [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/database.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | search.push(home.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `home` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/database.rs:277:14 [INFO] [stderr] | [INFO] [stderr] 277 | let name = names::ALIASES.get(name).map(|s| *s).unwrap_or(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `names::ALIASES.get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/capability.rs:275:4 [INFO] [stderr] | [INFO] [stderr] 275 | pub fn parameters(mut self, $($name: $ty),*) -> Self { [INFO] [stderr] | _____________^ [INFO] [stderr] 276 | | let mut index = 0; [INFO] [stderr] 277 | | [INFO] [stderr] 278 | | $({ [INFO] [stderr] ... | [INFO] [stderr] 283 | | self [INFO] [stderr] 284 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 883 | / define!(string SetAttributes => "set_attributes"; [INFO] [stderr] 884 | | standout: bool, [INFO] [stderr] 885 | | underline: bool, [INFO] [stderr] 886 | | reverse: bool, [INFO] [stderr] ... | [INFO] [stderr] 891 | | protected: bool, [INFO] [stderr] 892 | | alt_charset: bool); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/database.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | let name = names::ALIASES.get(name).map(|s| *s).unwrap_or(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `names::ALIASES.get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/database.rs:134:2 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn new() -> Builder { [INFO] [stderr] | _____^ [INFO] [stderr] 135 | | Builder::default() [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/database.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | search.push(home.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `home` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/database.rs:277:14 [INFO] [stderr] | [INFO] [stderr] 277 | let name = names::ALIASES.get(name).map(|s| *s).unwrap_or(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `names::ALIASES.get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.54s [INFO] running `"docker" "inspect" "fdc31b81b1f868d33c033388302923af27cf733ad4881390f1e85bd21ab91202"` [INFO] running `"docker" "rm" "-f" "fdc31b81b1f868d33c033388302923af27cf733ad4881390f1e85bd21ab91202"` [INFO] [stdout] fdc31b81b1f868d33c033388302923af27cf733ad4881390f1e85bd21ab91202