[INFO] crate terminal_thrift 0.3.2 is already in cache [INFO] extracting crate terminal_thrift 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/terminal_thrift/0.3.2 [INFO] extracting crate terminal_thrift 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/terminal_thrift/0.3.2 [INFO] validating manifest of terminal_thrift-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of terminal_thrift-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing terminal_thrift-0.3.2 [INFO] finished frobbing terminal_thrift-0.3.2 [INFO] frobbed toml for terminal_thrift-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/terminal_thrift/0.3.2/Cargo.toml [INFO] started frobbing terminal_thrift-0.3.2 [INFO] finished frobbing terminal_thrift-0.3.2 [INFO] frobbed toml for terminal_thrift-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/terminal_thrift/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting terminal_thrift-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/terminal_thrift/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d08f6ffffeae6218d9bebc6691463f35ea4723692ba92b56da88749382a8fd6f [INFO] running `"docker" "start" "-a" "d08f6ffffeae6218d9bebc6691463f35ea4723692ba92b56da88749382a8fd6f"` [INFO] [stderr] Checking terminal_thrift v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/simple_server.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | processor: processor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/simple_server.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | transport_server: transport_server [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/threaded.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | processor: processor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/simple_server.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | processor: processor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/simple_server.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | transport_server: transport_server [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/threaded.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | processor: processor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Protocol` [INFO] [stderr] --> src/server/threaded.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | use protocol::{Protocol, ProtocolFactory}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/server/threaded.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for _ in (0..threads) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:55:55 [INFO] [stderr] | [INFO] [stderr] 55 | assert_eq!(protocol.read_i32(transport).unwrap(), 0x27d03949); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x27d0_3949` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:56:56 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(protocol.read_i32(transport).unwrap(), -0x1a270175); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1a27_0175` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:66:55 [INFO] [stderr] | [INFO] [stderr] 66 | assert_eq!(protocol.read_i64(transport).unwrap(), 0x27d03949e5d8fe8b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x27d0_3949_e5d8_fe8b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:67:56 [INFO] [stderr] | [INFO] [stderr] 67 | assert_eq!(protocol.read_i64(transport).unwrap(), -0x58d17d152ed7f41e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x58d1_7d15_2ed7_f41e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:77:58 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(protocol.read_double(transport).unwrap(), 3247.342234); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3_247.342_234` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:78:59 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(protocol.read_double(transport).unwrap(), -0.78843886); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.788_438_86` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:113:34 [INFO] [stderr] | [INFO] [stderr] 113 | (protocol::Type::String, 0x0000010f) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_010f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:123:34 [INFO] [stderr] | [INFO] [stderr] 123 | (protocol::Type::String, 0x0000010f) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_010f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:133:55 [INFO] [stderr] | [INFO] [stderr] 133 | (protocol::Type::String, protocol::Type::I32, 0x0000010f) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_010f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:161:58 [INFO] [stderr] | [INFO] [stderr] 161 | ("foo".to_string(), protocol::MessageType::Call, 0x0002471e) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_471e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Protocol` [INFO] [stderr] --> src/server/threaded.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | use protocol::{Protocol, ProtocolFactory}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/server/threaded.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for _ in (0..threads) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `mock::*` [INFO] [stderr] --> src/test/prim.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use mock::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/test/prim.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | { test_i8_encode, (0..100), Byte, i8 }, [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/test/prim.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | { test_i16_encode, (0..100), I16, i16 }, [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/test/prim.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | { test_i32_encode, (0..100), I32, i32 }, [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/test/prim.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | { test_i64_encode, (0..100), I64, i64 }, [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `mock::*` [INFO] [stderr] --> src/test/strukt.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use mock::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mock::*` [INFO] [stderr] --> src/test/enom.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use mock::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:128:44 [INFO] [stderr] | [INFO] [stderr] 128 | fn write_byte(&mut self, mut transport: &mut T, value: i8) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:132:43 [INFO] [stderr] | [INFO] [stderr] 132 | fn write_i16(&mut self, mut transport: &mut T, value: i16) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:136:43 [INFO] [stderr] | [INFO] [stderr] 136 | fn write_i32(&mut self, mut transport: &mut T, value: i32) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:140:43 [INFO] [stderr] | [INFO] [stderr] 140 | fn write_i64(&mut self, mut transport: &mut T, value: i64) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:144:46 [INFO] [stderr] | [INFO] [stderr] 144 | fn write_double(&mut self, mut transport: &mut T, value: f64) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/virt.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | fn encode<'p, 't, P1, T1>(&self, mut protocol: &'p mut P1, mut transport: &'t mut T1) -> Result<()> [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `VirtualProxy` [INFO] [stderr] --> src/proxy.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | type VirtualProxy = for<'e> Proxy>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | let version = ((BINARY_PROTOCOL_VERSION_1 as i32) << 16) | message_type as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(BINARY_PROTOCOL_VERSION_1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | Ok(try!(transport.write_i8(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | Ok(try!(transport.write_i16::(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:137:12 [INFO] [stderr] | [INFO] [stderr] 137 | Ok(try!(transport.write_i32::(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:141:12 [INFO] [stderr] | [INFO] [stderr] 141 | Ok(try!(transport.write_i64::(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:145:12 [INFO] [stderr] | [INFO] [stderr] 145 | Ok(try!(transport.write_f64::(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:158:12 [INFO] [stderr] | [INFO] [stderr] 158 | Ok(try!(transport.write_all(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/protocol/mod.rs:259:72 [INFO] [stderr] | [INFO] [stderr] 259 | fn write_string(&mut self, transport: &mut T, value: &String) -> Result<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/proxy.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(try!(::protocol::helpers::send(&mut protocol, &mut transport, operation, mtype, &message, id))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/virt.rs:77:58 [INFO] [stderr] | [INFO] [stderr] 77 | fn virt_write_string(&mut self, transport: T, value: &String) -> Result<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `::protocol::helpers::send` doesn't need a mutable reference [INFO] [stderr] --> src/codegen.rs:182:94 [INFO] [stderr] | [INFO] [stderr] 182 | MNAME, $crate::protocol::MessageType::Call, &mut args, 0)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/compiletest.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / service! { [INFO] [stderr] 34 | | trait_name = SharedService, [INFO] [stderr] 35 | | processor_name = SharedServiceProcessor, [INFO] [stderr] 36 | | client_name = SharedServiceClient, [INFO] [stderr] ... | [INFO] [stderr] 42 | | fields = [shared: S,] [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::protocol::helpers::send` doesn't need a mutable reference [INFO] [stderr] --> src/codegen.rs:182:94 [INFO] [stderr] | [INFO] [stderr] 182 | MNAME, $crate::protocol::MessageType::Call, &mut args, 0)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/compiletest.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / service! { [INFO] [stderr] 46 | | trait_name = ChildService, [INFO] [stderr] 47 | | processor_name = ChildServiceProcessor, [INFO] [stderr] 48 | | client_name = ChildServiceClient, [INFO] [stderr] ... | [INFO] [stderr] 59 | | fields = [shared: S, child: C,] [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::protocol::helpers::send` doesn't need a mutable reference [INFO] [stderr] --> src/codegen.rs:182:94 [INFO] [stderr] | [INFO] [stderr] 182 | MNAME, $crate::protocol::MessageType::Call, &mut args, 0)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/compiletest.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / service! { [INFO] [stderr] 46 | | trait_name = ChildService, [INFO] [stderr] 47 | | processor_name = ChildServiceProcessor, [INFO] [stderr] 48 | | client_name = ChildServiceClient, [INFO] [stderr] ... | [INFO] [stderr] 59 | | fields = [shared: S, child: C,] [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::protocol::helpers::send` doesn't need a mutable reference [INFO] [stderr] --> src/codegen.rs:182:94 [INFO] [stderr] | [INFO] [stderr] 182 | MNAME, $crate::protocol::MessageType::Call, &mut args, 0)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/compiletest.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / service! { [INFO] [stderr] 71 | | trait_name = ServiceWithException, [INFO] [stderr] 72 | | processor_name = ServiceWithExceptionProcessor, [INFO] [stderr] 73 | | client_name = ServiceWithExceptionClient, [INFO] [stderr] ... | [INFO] [stderr] 79 | | fields = [this: S,] [INFO] [stderr] 80 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/mock/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::Read as IoRead; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/mock/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::Write as IoWrite; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:128:44 [INFO] [stderr] | [INFO] [stderr] 128 | fn write_byte(&mut self, mut transport: &mut T, value: i8) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:132:43 [INFO] [stderr] | [INFO] [stderr] 132 | fn write_i16(&mut self, mut transport: &mut T, value: i16) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:136:43 [INFO] [stderr] | [INFO] [stderr] 136 | fn write_i32(&mut self, mut transport: &mut T, value: i32) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:140:43 [INFO] [stderr] | [INFO] [stderr] 140 | fn write_i64(&mut self, mut transport: &mut T, value: i64) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:144:46 [INFO] [stderr] | [INFO] [stderr] 144 | fn write_double(&mut self, mut transport: &mut T, value: f64) -> Result<()> { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/virt.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | fn encode<'p, 't, P1, T1>(&self, mut protocol: &'p mut P1, mut transport: &'t mut T1) -> Result<()> [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `VirtualProxy` [INFO] [stderr] --> src/proxy.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | type VirtualProxy = for<'e> Proxy>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | let version = ((BINARY_PROTOCOL_VERSION_1 as i32) << 16) | message_type as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(BINARY_PROTOCOL_VERSION_1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | Ok(try!(transport.write_i8(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | Ok(try!(transport.write_i16::(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:137:12 [INFO] [stderr] | [INFO] [stderr] 137 | Ok(try!(transport.write_i32::(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:141:12 [INFO] [stderr] | [INFO] [stderr] 141 | Ok(try!(transport.write_i64::(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:145:12 [INFO] [stderr] | [INFO] [stderr] 145 | Ok(try!(transport.write_f64::(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/protocol/binary_protocol/mod.rs:158:12 [INFO] [stderr] | [INFO] [stderr] 158 | Ok(try!(transport.write_all(value))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(protocol.read_double(transport).unwrap(), 3247.342234); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(protocol.read_double(transport).unwrap(), 3247.342234); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(protocol.read_double(transport).unwrap(), -0.78843886); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/protocol/binary_protocol/test/mod.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(protocol.read_double(transport).unwrap(), -0.78843886); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/protocol/mod.rs:259:72 [INFO] [stderr] | [INFO] [stderr] 259 | fn write_string(&mut self, transport: &mut T, value: &String) -> Result<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/proxy.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(try!(::protocol::helpers::send(&mut protocol, &mut transport, operation, mtype, &message, id))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/virt.rs:77:58 [INFO] [stderr] | [INFO] [stderr] 77 | fn virt_write_string(&mut self, transport: T, value: &String) -> Result<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `::protocol::helpers::send` doesn't need a mutable reference [INFO] [stderr] --> src/codegen.rs:182:94 [INFO] [stderr] | [INFO] [stderr] 182 | MNAME, $crate::protocol::MessageType::Call, &mut args, 0)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/compiletest.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / service! { [INFO] [stderr] 34 | | trait_name = SharedService, [INFO] [stderr] 35 | | processor_name = SharedServiceProcessor, [INFO] [stderr] 36 | | client_name = SharedServiceClient, [INFO] [stderr] ... | [INFO] [stderr] 42 | | fields = [shared: S,] [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::protocol::helpers::send` doesn't need a mutable reference [INFO] [stderr] --> src/codegen.rs:182:94 [INFO] [stderr] | [INFO] [stderr] 182 | MNAME, $crate::protocol::MessageType::Call, &mut args, 0)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/compiletest.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / service! { [INFO] [stderr] 46 | | trait_name = ChildService, [INFO] [stderr] 47 | | processor_name = ChildServiceProcessor, [INFO] [stderr] 48 | | client_name = ChildServiceClient, [INFO] [stderr] ... | [INFO] [stderr] 59 | | fields = [shared: S, child: C,] [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::protocol::helpers::send` doesn't need a mutable reference [INFO] [stderr] --> src/codegen.rs:182:94 [INFO] [stderr] | [INFO] [stderr] 182 | MNAME, $crate::protocol::MessageType::Call, &mut args, 0)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/compiletest.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / service! { [INFO] [stderr] 46 | | trait_name = ChildService, [INFO] [stderr] 47 | | processor_name = ChildServiceProcessor, [INFO] [stderr] 48 | | client_name = ChildServiceClient, [INFO] [stderr] ... | [INFO] [stderr] 59 | | fields = [shared: S, child: C,] [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::protocol::helpers::send` doesn't need a mutable reference [INFO] [stderr] --> src/codegen.rs:182:94 [INFO] [stderr] | [INFO] [stderr] 182 | MNAME, $crate::protocol::MessageType::Call, &mut args, 0)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/compiletest.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / service! { [INFO] [stderr] 71 | | trait_name = ServiceWithException, [INFO] [stderr] 72 | | processor_name = ServiceWithExceptionProcessor, [INFO] [stderr] 73 | | client_name = ServiceWithExceptionClient, [INFO] [stderr] ... | [INFO] [stderr] 79 | | fields = [this: S,] [INFO] [stderr] 80 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mock/mod.rs:227:12 [INFO] [stderr] | [INFO] [stderr] 227 | if self.log.len() != 0 { self.log.pop(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.log.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/test/enom.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | for op in vec![Operation::Add, Operation::Sub, Operation::Clear] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Operation::Add, Operation::Sub, Operation::Clear]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `terminal_thrift`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d08f6ffffeae6218d9bebc6691463f35ea4723692ba92b56da88749382a8fd6f"` [INFO] running `"docker" "rm" "-f" "d08f6ffffeae6218d9bebc6691463f35ea4723692ba92b56da88749382a8fd6f"` [INFO] [stdout] d08f6ffffeae6218d9bebc6691463f35ea4723692ba92b56da88749382a8fd6f