[INFO] crate termfest 0.1.3 is already in cache [INFO] extracting crate termfest 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/termfest/0.1.3 [INFO] extracting crate termfest 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/termfest/0.1.3 [INFO] validating manifest of termfest-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of termfest-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing termfest-0.1.3 [INFO] finished frobbing termfest-0.1.3 [INFO] frobbed toml for termfest-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/termfest/0.1.3/Cargo.toml [INFO] started frobbing termfest-0.1.3 [INFO] finished frobbing termfest-0.1.3 [INFO] frobbed toml for termfest-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/termfest/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting termfest-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/termfest/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb4d10b08cf63344423252070a9e6efc12fae4505b0e333fb923aa09cf76da54 [INFO] running `"docker" "start" "-a" "eb4d10b08cf63344423252070a9e6efc12fae4505b0e333fb923aa09cf76da54"` [INFO] [stderr] Checking signal-notify v0.1.3 [INFO] [stderr] Compiling num-derive v0.1.44 [INFO] [stderr] Checking termfest v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | ch: ch, [INFO] [stderr] | ^^^^^^ help: replace it with: `ch` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:179:57 [INFO] [stderr] | [INFO] [stderr] 179 | commands.push(Command::MoveCursor { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:179:63 [INFO] [stderr] | [INFO] [stderr] 179 | commands.push(Command::MoveCursor { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terminal.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(Terminal { terminfo: terminfo }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | orig_tios: orig_tios, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `orig_tios` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | terminal: terminal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | screen: screen, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `screen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | ch: ch, [INFO] [stderr] | ^^^^^^ help: replace it with: `ch` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:179:57 [INFO] [stderr] | [INFO] [stderr] 179 | commands.push(Command::MoveCursor { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/screen.rs:179:63 [INFO] [stderr] | [INFO] [stderr] 179 | commands.push(Command::MoveCursor { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terminal.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(Terminal { terminfo: terminfo }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | orig_tios: orig_tios, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `orig_tios` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | terminal: terminal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | screen: screen, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `screen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return UTF8_CHAR_WIDTH[b as usize] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTF8_CHAR_WIDTH[b as usize] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | const BOLD = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | const DIM = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:56:27 [INFO] [stderr] | [INFO] [stderr] 56 | const UNDERLINE = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | const BLINK = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | const REVERSE = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return UTF8_CHAR_WIDTH[b as usize] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTF8_CHAR_WIDTH[b as usize] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | const BOLD = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | const DIM = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:56:27 [INFO] [stderr] | [INFO] [stderr] 56 | const UNDERLINE = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | const BLINK = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attr.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | const REVERSE = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/terminal.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | w.write(&[0x1b])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | / loop { [INFO] [stderr] 308 | | if let Some((read_byte, ev)) = event::parse(&buf[from..], &*term) { [INFO] [stderr] 309 | | from += read_byte; [INFO] [stderr] 310 | | if tx.send(ev).is_err() { [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some((read_byte, ev)) = event::parse(&buf[from..], &*term) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `termfest`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/event.rs:124:10 [INFO] [stderr] | [INFO] [stderr] 124 | ("abc".as_bytes(), Some('a')), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/terminal.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | w.write(&[0x1b])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | / loop { [INFO] [stderr] 308 | | if let Some((read_byte, ev)) = event::parse(&buf[from..], &*term) { [INFO] [stderr] 309 | | from += read_byte; [INFO] [stderr] 310 | | if tx.send(ev).is_err() { [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some((read_byte, ev)) = event::parse(&buf[from..], &*term) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `termfest`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eb4d10b08cf63344423252070a9e6efc12fae4505b0e333fb923aa09cf76da54"` [INFO] running `"docker" "rm" "-f" "eb4d10b08cf63344423252070a9e6efc12fae4505b0e333fb923aa09cf76da54"` [INFO] [stdout] eb4d10b08cf63344423252070a9e6efc12fae4505b0e333fb923aa09cf76da54