[INFO] crate termage 1.1.1 is already in cache [INFO] extracting crate termage 1.1.1 into work/ex/clippy-test-run/sources/stable/reg/termage/1.1.1 [INFO] extracting crate termage 1.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/termage/1.1.1 [INFO] validating manifest of termage-1.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of termage-1.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing termage-1.1.1 [INFO] finished frobbing termage-1.1.1 [INFO] frobbed toml for termage-1.1.1 written to work/ex/clippy-test-run/sources/stable/reg/termage/1.1.1/Cargo.toml [INFO] started frobbing termage-1.1.1 [INFO] finished frobbing termage-1.1.1 [INFO] frobbed toml for termage-1.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/termage/1.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting termage-1.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/termage/1.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 139576059b9950bbdcc189e2148cc1b657c3cb50a5e47a0c9a0ff25e965f78ca [INFO] running `"docker" "start" "-a" "139576059b9950bbdcc189e2148cc1b657c3cb50a5e47a0c9a0ff25e965f78ca"` [INFO] [stderr] Checking terminal_size v0.1.8 [INFO] [stderr] Checking termage v1.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused import: `Frame` [INFO] [stderr] --> src/lib.rs:11:71 [INFO] [stderr] | [INFO] [stderr] 11 | use image::{GenericImage, Pixel, RgbImage, gif, Frames, ImageDecoder, Frame}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ImageBuffer` [INFO] [stderr] --> src/lib.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | use image::{ConvertBuffer, ImageBuffer}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Frame` [INFO] [stderr] --> src/lib.rs:11:71 [INFO] [stderr] | [INFO] [stderr] 11 | use image::{GenericImage, Pixel, RgbImage, gif, Frames, ImageDecoder, Frame}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ImageBuffer` [INFO] [stderr] --> src/lib.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | use image::{ConvertBuffer, ImageBuffer}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:177:10 [INFO] [stderr] | [INFO] [stderr] 177 | for (i, frame) in frames.enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | let mut f = File::open(filename).expect("File not found"); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut decoder = gif::Decoder::new(f); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | let mut img = get_image(image_filepath); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | let mut frames = get_gif(gif_filepath); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | *pixel = closest_pixel.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*closest_pixel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:89:33 [INFO] [stderr] | [INFO] [stderr] 89 | big_pixel_rgb[0] += rgb_values[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb_values[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | big_pixel_rgb[1] += rgb_values[1] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb_values[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:91:33 [INFO] [stderr] | [INFO] [stderr] 91 | big_pixel_rgb[2] += rgb_values[2] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb_values[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | let delay = frame.delay().to_integer() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(frame.delay().to_integer())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:177:10 [INFO] [stderr] | [INFO] [stderr] 177 | for (i, frame) in frames.enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | let mut f = File::open(filename).expect("File not found"); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut decoder = gif::Decoder::new(f); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | let mut img = get_image(image_filepath); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | let mut frames = get_gif(gif_filepath); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | *pixel = closest_pixel.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*closest_pixel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:89:33 [INFO] [stderr] | [INFO] [stderr] 89 | big_pixel_rgb[0] += rgb_values[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb_values[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | big_pixel_rgb[1] += rgb_values[1] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb_values[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:91:33 [INFO] [stderr] | [INFO] [stderr] 91 | big_pixel_rgb[2] += rgb_values[2] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(rgb_values[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | let delay = frame.delay().to_integer() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(frame.delay().to_integer())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::Pixel` [INFO] [stderr] --> src/bin/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use image::Pixel; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `terminal_graphics::Display` [INFO] [stderr] --> src/bin/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use terminal_graphics::Display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `terminal_graphics::Colour` [INFO] [stderr] --> src/bin/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use terminal_graphics::Colour; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/main.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | display_image(filepath, w as u32, h as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/main.rs:45:47 [INFO] [stderr] | [INFO] [stderr] 45 | display_image(filepath, w as u32, h as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/main.rs:48:39 [INFO] [stderr] | [INFO] [stderr] 48 | display_gif(filepath, w as u32, h as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/main.rs:48:49 [INFO] [stderr] | [INFO] [stderr] 48 | display_gif(filepath, w as u32, h as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::Pixel` [INFO] [stderr] --> src/bin/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use image::Pixel; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `terminal_graphics::Display` [INFO] [stderr] --> src/bin/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use terminal_graphics::Display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `terminal_graphics::Colour` [INFO] [stderr] --> src/bin/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use terminal_graphics::Colour; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/main.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | display_image(filepath, w as u32, h as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/main.rs:45:47 [INFO] [stderr] | [INFO] [stderr] 45 | display_image(filepath, w as u32, h as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/main.rs:48:39 [INFO] [stderr] | [INFO] [stderr] 48 | display_gif(filepath, w as u32, h as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/main.rs:48:49 [INFO] [stderr] | [INFO] [stderr] 48 | display_gif(filepath, w as u32, h as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.68s [INFO] running `"docker" "inspect" "139576059b9950bbdcc189e2148cc1b657c3cb50a5e47a0c9a0ff25e965f78ca"` [INFO] running `"docker" "rm" "-f" "139576059b9950bbdcc189e2148cc1b657c3cb50a5e47a0c9a0ff25e965f78ca"` [INFO] [stdout] 139576059b9950bbdcc189e2148cc1b657c3cb50a5e47a0c9a0ff25e965f78ca