[INFO] crate telium 0.1.2 is already in cache [INFO] extracting crate telium 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/telium/0.1.2 [INFO] extracting crate telium 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telium/0.1.2 [INFO] validating manifest of telium-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of telium-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing telium-0.1.2 [INFO] finished frobbing telium-0.1.2 [INFO] frobbed toml for telium-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/telium/0.1.2/Cargo.toml [INFO] started frobbing telium-0.1.2 [INFO] finished frobbing telium-0.1.2 [INFO] frobbed toml for telium-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telium/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting telium-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/telium/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b6929d1bd6736cf5c9087a0ab7db37e56aa87b46791f96751bb32739fe30a60 [INFO] running `"docker" "start" "-a" "0b6929d1bd6736cf5c9087a0ab7db37e56aa87b46791f96751bb32739fe30a60"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `main`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking nalgebra v0.5.1 [INFO] [stderr] Checking telium v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numeric/polynomial.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | Polynomial { coeffs: coeffs, domain: domain } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coeffs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numeric/polynomial.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | Polynomial { coeffs: coeffs, domain: domain } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `domain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/numeric/interpolate.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | let d = self[x]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numeric/polynomial.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | Polynomial { coeffs: coeffs, domain: domain } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coeffs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/numeric/polynomial.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | Polynomial { coeffs: coeffs, domain: domain } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `domain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/numeric/interpolate.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | let d = self[x]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Domain`, `Eval` [INFO] [stderr] --> src/numeric/interpolate.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | use numeric::function::{Domain, Eval}; [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `CheckedAdd` [INFO] [stderr] --> src/numeric/interpolate.rs:12:31 [INFO] [stderr] | [INFO] [stderr] 12 | use self::num::traits::{Zero, CheckedAdd}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/numeric/interpolate.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | B[i] = ((self[i+1] - self[i]) / h[i] - (self[i] - self[i-1]) / h[i-1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/numeric/calculus.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | fn integral(&mut self, c: f32) {} [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/numeric/polynomial.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | for (pow, val) in self.coeffs.iter().enumerate() { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/numeric/polynomial.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | for (pow, val) in self.coeffs.iter().enumerate() { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/numeric/interpolate.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | let (mut h, mut coeffs_mat) = gen_coeffs_matrix(range(0f32, self.len() as f32).collect()); // generates a Vec comparable to the index [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/numeric/polynomial.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | write!(f, "+ {}x^{} ", coeff, pow); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variable `B` should have a snake case name such as `b` [INFO] [stderr] --> src/numeric/interpolate.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let mut B: DVec = DVec::new_zeros(self.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the variable `offset` is used as a loop counter. Consider using `for (offset, item) in 1..(v.len() - 1).enumerate()` or similar iterators [INFO] [stderr] --> src/numeric/interpolate.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | for j in 1..(v.len() - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/numeric/interpolate.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | mat[(j, offset + 0)] = x_diff[j]; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Domain`, `Eval` [INFO] [stderr] --> src/numeric/interpolate.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | use numeric::function::{Domain, Eval}; [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `CheckedAdd` [INFO] [stderr] --> src/numeric/interpolate.rs:12:31 [INFO] [stderr] | [INFO] [stderr] 12 | use self::num::traits::{Zero, CheckedAdd}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/numeric/interpolate.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | B[i] = ((self[i+1] - self[i]) / h[i] - (self[i] - self[i-1]) / h[i-1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/numeric/calculus.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | fn integral(&mut self, c: f32) {} [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/numeric/polynomial.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | for (pow, val) in self.coeffs.iter().enumerate() { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/numeric/polynomial.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | for (pow, val) in self.coeffs.iter().enumerate() { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/numeric/interpolate.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | let (mut h, mut coeffs_mat) = gen_coeffs_matrix(range(0f32, self.len() as f32).collect()); // generates a Vec comparable to the index [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/numeric/polynomial.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | write!(f, "+ {}x^{} ", coeff, pow); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variable `B` should have a snake case name such as `b` [INFO] [stderr] --> src/numeric/interpolate.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let mut B: DVec = DVec::new_zeros(self.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the variable `offset` is used as a loop counter. Consider using `for (offset, item) in 1..(v.len() - 1).enumerate()` or similar iterators [INFO] [stderr] --> src/numeric/interpolate.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | for j in 1..(v.len() - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/numeric/interpolate.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | mat[(j, offset + 0)] = x_diff[j]; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::Complex` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use num::Complex; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::Complex` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use num::Complex; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.98s [INFO] running `"docker" "inspect" "0b6929d1bd6736cf5c9087a0ab7db37e56aa87b46791f96751bb32739fe30a60"` [INFO] running `"docker" "rm" "-f" "0b6929d1bd6736cf5c9087a0ab7db37e56aa87b46791f96751bb32739fe30a60"` [INFO] [stdout] 0b6929d1bd6736cf5c9087a0ab7db37e56aa87b46791f96751bb32739fe30a60