[INFO] crate telescreen 0.1.3 is already in cache [INFO] extracting crate telescreen 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/telescreen/0.1.3 [INFO] extracting crate telescreen 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telescreen/0.1.3 [INFO] validating manifest of telescreen-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of telescreen-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing telescreen-0.1.3 [INFO] finished frobbing telescreen-0.1.3 [INFO] frobbed toml for telescreen-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/telescreen/0.1.3/Cargo.toml [INFO] started frobbing telescreen-0.1.3 [INFO] finished frobbing telescreen-0.1.3 [INFO] frobbed toml for telescreen-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telescreen/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting telescreen-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/telescreen/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a90995417f9e40df24a8481d29946a45904bfc4ba44751cc4974e6bfa87ecff [INFO] running `"docker" "start" "-a" "6a90995417f9e40df24a8481d29946a45904bfc4ba44751cc4974e6bfa87ecff"` [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking slack_api v0.16.2 [INFO] [stderr] Checking tungstenite v0.2.4 [INFO] [stderr] Checking slack v0.17.1 [INFO] [stderr] Checking telescreen v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | Router { rules: rules } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telescreen_handler.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | router: router, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `router` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | Router { rules: rules } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telescreen_handler.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | router: router, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `router` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/router.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new(config_path_string: &String) -> Router { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/router.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match file.read_to_string(&mut yaml_string) { [INFO] [stderr] 32 | | Err(why) => panic!("Clould not read {}: {}", display, Error::description(&why)), [INFO] [stderr] 33 | | Ok(_) => { /* noop */ } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = file.read_to_string(&mut yaml_string) { panic!("Clould not read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/telescreen_handler.rs:111:59 [INFO] [stderr] | [INFO] [stderr] 111 | Some(ref name) => name.to_string() == user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/telescreen_handler.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match event { [INFO] [stderr] 124 | | Event::Message(event) => { [INFO] [stderr] 125 | | match *event { [INFO] [stderr] 126 | | Message::Standard(message) => { [INFO] [stderr] ... | [INFO] [stderr] 154 | | _ => { /* noop */ } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | if let Event::Message(event) = event { [INFO] [stderr] 124 | match *event { [INFO] [stderr] 125 | Message::Standard(message) => { [INFO] [stderr] 126 | let source_channel_id = match message.channel { [INFO] [stderr] 127 | None => { [INFO] [stderr] 128 | warn!("No channel: {:?}", message.channel); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/telescreen_handler.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | / match *event { [INFO] [stderr] 126 | | Message::Standard(message) => { [INFO] [stderr] 127 | | let source_channel_id = match message.channel { [INFO] [stderr] 128 | | None => { [INFO] [stderr] ... | [INFO] [stderr] 151 | | _ => { /* noop */ } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 125 | if let Message::Standard(message) = *event { [INFO] [stderr] 126 | let source_channel_id = match message.channel { [INFO] [stderr] 127 | None => { [INFO] [stderr] 128 | warn!("No channel: {:?}", message.channel); [INFO] [stderr] 129 | return; [INFO] [stderr] 130 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/router.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new(config_path_string: &String) -> Router { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/router.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match file.read_to_string(&mut yaml_string) { [INFO] [stderr] 32 | | Err(why) => panic!("Clould not read {}: {}", display, Error::description(&why)), [INFO] [stderr] 33 | | Ok(_) => { /* noop */ } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = file.read_to_string(&mut yaml_string) { panic!("Clould not read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/router.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | let ref first_rule = router.rules[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let first_rule = &router.rules[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/router.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | let ref second_rule = router.rules[1]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^------------------- help: try: `let second_rule = &router.rules[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/router.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let ref third_rule = router.rules[2]; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let third_rule = &router.rules[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/telescreen_handler.rs:111:59 [INFO] [stderr] | [INFO] [stderr] 111 | Some(ref name) => name.to_string() == user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/telescreen_handler.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match event { [INFO] [stderr] 124 | | Event::Message(event) => { [INFO] [stderr] 125 | | match *event { [INFO] [stderr] 126 | | Message::Standard(message) => { [INFO] [stderr] ... | [INFO] [stderr] 154 | | _ => { /* noop */ } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | if let Event::Message(event) = event { [INFO] [stderr] 124 | match *event { [INFO] [stderr] 125 | Message::Standard(message) => { [INFO] [stderr] 126 | let source_channel_id = match message.channel { [INFO] [stderr] 127 | None => { [INFO] [stderr] 128 | warn!("No channel: {:?}", message.channel); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/telescreen_handler.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | / match *event { [INFO] [stderr] 126 | | Message::Standard(message) => { [INFO] [stderr] 127 | | let source_channel_id = match message.channel { [INFO] [stderr] 128 | | None => { [INFO] [stderr] ... | [INFO] [stderr] 151 | | _ => { /* noop */ } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 125 | if let Message::Standard(message) = *event { [INFO] [stderr] 126 | let source_channel_id = match message.channel { [INFO] [stderr] 127 | None => { [INFO] [stderr] 128 | warn!("No channel: {:?}", message.channel); [INFO] [stderr] 129 | return; [INFO] [stderr] 130 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match env::var("SSL_CERT_FILE") { [INFO] [stderr] 22 | | Err(_) => env::set_var("SSL_CERT_FILE", "/etc/ssl/certs/ca-certificates.crt"), [INFO] [stderr] 23 | | Ok(_) => { /* noop */ } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = env::var("SSL_CERT_FILE") { env::set_var("SSL_CERT_FILE", "/etc/ssl/certs/ca-certificates.crt") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / match env::var("SSL_CERT_DIR") { [INFO] [stderr] 26 | | Err(_) => env::set_var("SSL_CERT_DIR", "/etc/ssl/certs"), [INFO] [stderr] 27 | | Ok(_) => { /* noop */ } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = env::var("SSL_CERT_DIR") { env::set_var("SSL_CERT_DIR", "/etc/ssl/certs") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | let router = Router::new(&String::from(config_path_string)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `config_path_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match env::var("SSL_CERT_FILE") { [INFO] [stderr] 22 | | Err(_) => env::set_var("SSL_CERT_FILE", "/etc/ssl/certs/ca-certificates.crt"), [INFO] [stderr] 23 | | Ok(_) => { /* noop */ } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = env::var("SSL_CERT_FILE") { env::set_var("SSL_CERT_FILE", "/etc/ssl/certs/ca-certificates.crt") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / match env::var("SSL_CERT_DIR") { [INFO] [stderr] 26 | | Err(_) => env::set_var("SSL_CERT_DIR", "/etc/ssl/certs"), [INFO] [stderr] 27 | | Ok(_) => { /* noop */ } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = env::var("SSL_CERT_DIR") { env::set_var("SSL_CERT_DIR", "/etc/ssl/certs") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | let router = Router::new(&String::from(config_path_string)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `config_path_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.74s [INFO] running `"docker" "inspect" "6a90995417f9e40df24a8481d29946a45904bfc4ba44751cc4974e6bfa87ecff"` [INFO] running `"docker" "rm" "-f" "6a90995417f9e40df24a8481d29946a45904bfc4ba44751cc4974e6bfa87ecff"` [INFO] [stdout] 6a90995417f9e40df24a8481d29946a45904bfc4ba44751cc4974e6bfa87ecff