[INFO] crate telereads 0.1.2 is already in cache [INFO] extracting crate telereads 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/telereads/0.1.2 [INFO] extracting crate telereads 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telereads/0.1.2 [INFO] validating manifest of telereads-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of telereads-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing telereads-0.1.2 [INFO] finished frobbing telereads-0.1.2 [INFO] frobbed toml for telereads-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/telereads/0.1.2/Cargo.toml [INFO] started frobbing telereads-0.1.2 [INFO] finished frobbing telereads-0.1.2 [INFO] frobbed toml for telereads-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telereads/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting telereads-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/telereads/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff0585a1e714db675212b6c3f13223fba7e26d79e8336d6e4032109ca38cb1d2 [INFO] running `"docker" "start" "-a" "ff0585a1e714db675212b6c3f13223fba7e26d79e8336d6e4032109ca38cb1d2"` [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking retry v0.4.0 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling markup5ever v0.7.5 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Checking html5ever v0.22.5 [INFO] [stderr] Checking ammonia v1.2.0 [INFO] [stderr] Checking telereads v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/telegram/models/query.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / InlineQueryResultArticle { [INFO] [stderr] 55 | | #[serde(rename = "type")] [INFO] [stderr] 56 | | _type: String, [INFO] [stderr] 57 | | id: String, [INFO] [stderr] ... | [INFO] [stderr] 73 | | thumb_height: Option, [INFO] [stderr] 74 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/telegram/models/query.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / InlineQueryResultArticle { [INFO] [stderr] 55 | | #[serde(rename = "type")] [INFO] [stderr] 56 | | _type: String, [INFO] [stderr] 57 | | id: String, [INFO] [stderr] ... | [INFO] [stderr] 73 | | thumb_height: Option, [INFO] [stderr] 74 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/telegram/telegram_bot.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | update.inline_query.map(|query| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 39 | || if !&query.query.is_empty() { [INFO] [stderr] 40 | || info!("Received query: \"{message}\"", message = &query.query); [INFO] [stderr] 41 | || } [INFO] [stderr] ... || [INFO] [stderr] 46 | || }; [INFO] [stderr] 47 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(query) = update.inline_query { ... }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/telegram/telegram_bot.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | / update.message.map(|message| { [INFO] [stderr] 50 | | match self.send_message(message.chat.id, "@TelereadsBot allows you to search for books on Goodreads and quickly send them to your chat partner.\n\nJust type @TelereadsBot in any chat, followed by a query (i.e. book title, ISBN, or author name), without pressing 'send'. You can choose any result from the pop-up window that will show up and send it by simply clicking on it.\n\nFor instance, try typing @TelereadsBot lord of the rings in this chat, and wait for the results to appear.") { [INFO] [stderr] 51 | | Ok(_) => info!("Message successfully sent."), [INFO] [stderr] 52 | | Err(e) => error!("Could not send message: {:#?}", e), [INFO] [stderr] 53 | | }; [INFO] [stderr] 54 | | }); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(message) = update.message { match self.send_message(message.chat.id, "@TelereadsBot allows you to search for books on Goodreads and quickly send them to your chat partner.\n\nJust type @TelereadsBot in any chat, followed by a query (i.e. book title, ISBN, or author name), without pressing 'send'. You can choose any result from the pop-up window that will show up and send it by simply clicking on it.\n\nFor instance, try typing @TelereadsBot lord of the rings in this chat, and wait for the results to appear.") { [INFO] [stderr] 50 | Ok(_) => info!("Message successfully sent."), [INFO] [stderr] 51 | Err(e) => error!("Could not send message: {:#?}", e), [INFO] [stderr] 52 | }; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/telegram/telegram_bot.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/telegram/models/query.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / InlineQueryResultArticle { [INFO] [stderr] 55 | | #[serde(rename = "type")] [INFO] [stderr] 56 | | _type: String, [INFO] [stderr] 57 | | id: String, [INFO] [stderr] ... | [INFO] [stderr] 73 | | thumb_height: Option, [INFO] [stderr] 74 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/telegram/models/query.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / InlineQueryResultArticle { [INFO] [stderr] 55 | | #[serde(rename = "type")] [INFO] [stderr] 56 | | _type: String, [INFO] [stderr] 57 | | id: String, [INFO] [stderr] ... | [INFO] [stderr] 73 | | thumb_height: Option, [INFO] [stderr] 74 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/telegram/telegram_bot.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | update.inline_query.map(|query| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 39 | || if !&query.query.is_empty() { [INFO] [stderr] 40 | || info!("Received query: \"{message}\"", message = &query.query); [INFO] [stderr] 41 | || } [INFO] [stderr] ... || [INFO] [stderr] 46 | || }; [INFO] [stderr] 47 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(query) = update.inline_query { ... }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/telegram/telegram_bot.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | / update.message.map(|message| { [INFO] [stderr] 50 | | match self.send_message(message.chat.id, "@TelereadsBot allows you to search for books on Goodreads and quickly send them to your chat partner.\n\nJust type @TelereadsBot in any chat, followed by a query (i.e. book title, ISBN, or author name), without pressing 'send'. You can choose any result from the pop-up window that will show up and send it by simply clicking on it.\n\nFor instance, try typing @TelereadsBot lord of the rings in this chat, and wait for the results to appear.") { [INFO] [stderr] 51 | | Ok(_) => info!("Message successfully sent."), [INFO] [stderr] 52 | | Err(e) => error!("Could not send message: {:#?}", e), [INFO] [stderr] 53 | | }; [INFO] [stderr] 54 | | }); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(message) = update.message { match self.send_message(message.chat.id, "@TelereadsBot allows you to search for books on Goodreads and quickly send them to your chat partner.\n\nJust type @TelereadsBot in any chat, followed by a query (i.e. book title, ISBN, or author name), without pressing 'send'. You can choose any result from the pop-up window that will show up and send it by simply clicking on it.\n\nFor instance, try typing @TelereadsBot lord of the rings in this chat, and wait for the results to appear.") { [INFO] [stderr] 50 | Ok(_) => info!("Message successfully sent."), [INFO] [stderr] 51 | Err(e) => error!("Could not send message: {:#?}", e), [INFO] [stderr] 52 | }; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/telegram/telegram_bot.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 41.35s [INFO] running `"docker" "inspect" "ff0585a1e714db675212b6c3f13223fba7e26d79e8336d6e4032109ca38cb1d2"` [INFO] running `"docker" "rm" "-f" "ff0585a1e714db675212b6c3f13223fba7e26d79e8336d6e4032109ca38cb1d2"` [INFO] [stdout] ff0585a1e714db675212b6c3f13223fba7e26d79e8336d6e4032109ca38cb1d2