[INFO] crate telemetry 0.1.1 is already in cache [INFO] extracting crate telemetry 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/telemetry/0.1.1 [INFO] extracting crate telemetry 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telemetry/0.1.1 [INFO] validating manifest of telemetry-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of telemetry-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing telemetry-0.1.1 [INFO] finished frobbing telemetry-0.1.1 [INFO] frobbed toml for telemetry-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/telemetry/0.1.1/Cargo.toml [INFO] started frobbing telemetry-0.1.1 [INFO] finished frobbing telemetry-0.1.1 [INFO] frobbed toml for telemetry-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telemetry/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting telemetry-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/telemetry/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac1e6ee250f82ce66c3207db43dcba385ecbff200cf13f4e5e8b4741cdbdecf0 [INFO] running `"docker" "start" "-a" "ac1e6ee250f82ce66c3207db43dcba385ecbff200cf13f4e5e8b4741cdbdecf0"` [INFO] [stderr] Checking vec_map v0.3.0 [INFO] [stderr] Checking telemetry v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/misc.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/misc.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/misc.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | buckets: buckets [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plain.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keyed.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | shape: shape [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | let named = NamedStorage { name: name, contents: storage }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:91:36 [INFO] [stderr] | [INFO] [stderr] 91 | let named = NamedStorage { name: name, contents: storage }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/misc.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/misc.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/misc.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | buckets: buckets [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plain.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keyed.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | shape: shape [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | let named = NamedStorage { name: name, contents: storage }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:91:36 [INFO] [stderr] | [INFO] [stderr] 91 | let named = NamedStorage { name: name, contents: storage }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/plain.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | json [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/plain.rs:308:20 [INFO] [stderr] | [INFO] [stderr] 308 | let json = Json::Array(self.values.iter().map(|&x| Json::I64(x as i64)).collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/plain.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | json [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/plain.rs:308:20 [INFO] [stderr] | [INFO] [stderr] 308 | let json = Json::Array(self.values.iter().map(|&x| Json::I64(x as i64)).collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/misc.rs:123:23 [INFO] [stderr] | [INFO] [stderr] 123 | let mut ptr = vec.as_mut_ptr().offset(len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vec`. [INFO] [stderr] --> src/misc.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | for i in 0 .. size { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 146 | for in vec.iter_mut().take(size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/task.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | let ref mut storage = self.plain.get_mut(&index).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------------- help: try: `let storage = &mut self.plain.get_mut(&index).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/task.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | let ref mut storage = self.keyed.get_mut(&index).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------------- help: try: `let storage = &mut self.keyed.get_mut(&index).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/task.rs:114:33 [INFO] [stderr] | [INFO] [stderr] 114 | for ref histogram in self.plain.values() { [INFO] [stderr] | ^^^^^^^^^^^^^ ------------------- help: try: `let histogram = &self.plain.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/task.rs:119:33 [INFO] [stderr] | [INFO] [stderr] 119 | for ref histogram in self.keyed.values() { [INFO] [stderr] | ^^^^^^^^^^^^^ ------------------- help: try: `let histogram = &self.keyed.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plain::Ignoring` [INFO] [stderr] --> src/plain.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn new() -> Ignoring { [INFO] [stderr] 105 | | Ignoring { [INFO] [stderr] 106 | | witness: PhantomData [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plain.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / match format { [INFO] [stderr] 157 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 158 | | Json::I64(if self.encountered { 1 } else { 0 }) [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *format { [INFO] [stderr] 157 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plain.rs:308:70 [INFO] [stderr] | [INFO] [stderr] 308 | let json = Json::Array(self.values.iter().map(|&x| Json::I64(x as i64)).collect()); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/misc.rs:123:23 [INFO] [stderr] | [INFO] [stderr] 123 | let mut ptr = vec.as_mut_ptr().offset(len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(len)` [INFO] [stderr] | [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plain.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | / match format { [INFO] [stderr] 351 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 352 | | Json::I64(self.value as i64) [INFO] [stderr] 353 | | } [INFO] [stderr] 354 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 350 | match *format { [INFO] [stderr] 351 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plain.rs:352:27 [INFO] [stderr] | [INFO] [stderr] 352 | Json::I64(self.value as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plain.rs:416:9 [INFO] [stderr] | [INFO] [stderr] 416 | / match format { [INFO] [stderr] 417 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 418 | | Json::Array(self.values.iter().map(|&x| Json::I64(x as i64)).collect()) [INFO] [stderr] 419 | | } [INFO] [stderr] 420 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] warning: the loop variable `i` is only used to index `vec`. [INFO] [stderr] --> src/misc.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | for i in 0 .. size { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 416 | match *format { [INFO] [stderr] 417 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 146 | for in vec.iter_mut().take(size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plain.rs:418:67 [INFO] [stderr] | [INFO] [stderr] 418 | Json::Array(self.values.iter().map(|&x| Json::I64(x as i64)).collect()) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/task.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | let ref mut storage = self.plain.get_mut(&index).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------------- help: try: `let storage = &mut self.plain.get_mut(&index).unwrap();` [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `keyed::KeyedIgnoring` [INFO] [stderr] --> src/keyed.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn new() -> KeyedIgnoring { [INFO] [stderr] 107 | | KeyedIgnoring { [INFO] [stderr] 108 | | witness: PhantomData [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/keyed.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / match format { [INFO] [stderr] 167 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 168 | | // Collect and sort the keys. [INFO] [stderr] 169 | | let mut keys : Vec<&String> = self.encountered.iter().collect(); [INFO] [stderr] ... | [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 166 | match *format { [INFO] [stderr] 167 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/task.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | let ref mut storage = self.keyed.get_mut(&index).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------------- help: try: `let storage = &mut self.keyed.get_mut(&index).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/task.rs:114:33 [INFO] [stderr] | [INFO] [stderr] 114 | for ref histogram in self.plain.values() { [INFO] [stderr] | ^^^^^^^^^^^^^ ------------------- help: try: `let histogram = &self.plain.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/task.rs:119:33 [INFO] [stderr] | [INFO] [stderr] 119 | for ref histogram in self.keyed.values() { [INFO] [stderr] | ^^^^^^^^^^^^^ ------------------- help: try: `let histogram = &self.keyed.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plain::Ignoring` [INFO] [stderr] --> src/plain.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn new() -> Ignoring { [INFO] [stderr] 105 | | Ignoring { [INFO] [stderr] 106 | | witness: PhantomData [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/keyed.rs:260:67 [INFO] [stderr] | [INFO] [stderr] 260 | let array = Json::Array(vec.iter().map(|&x| Json::I64(x as i64)).collect()); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plain.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / match format { [INFO] [stderr] 157 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 158 | | Json::I64(if self.encountered { 1 } else { 0 }) [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *format { [INFO] [stderr] 157 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keyed.rs:360:25 [INFO] [stderr] | [INFO] [stderr] 360 | let v = e.get().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*e.get()` [INFO] [stderr] | [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plain.rs:308:70 [INFO] [stderr] | [INFO] [stderr] 308 | let json = Json::Array(self.values.iter().map(|&x| Json::I64(x as i64)).collect()); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plain.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | / match format { [INFO] [stderr] 351 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 352 | | Json::I64(self.value as i64) [INFO] [stderr] 353 | | } [INFO] [stderr] 354 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 350 | match *format { [INFO] [stderr] 351 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plain.rs:352:27 [INFO] [stderr] | [INFO] [stderr] 352 | Json::I64(self.value as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/keyed.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | / match format { [INFO] [stderr] 370 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 371 | | // Sort keys, for easier testing/comparison. [INFO] [stderr] 372 | | let mut values : Vec<_> = self.values.iter().collect(); [INFO] [stderr] ... | [INFO] [stderr] 381 | | } [INFO] [stderr] 382 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 369 | match *format { [INFO] [stderr] 370 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/keyed.rs:378:57 [INFO] [stderr] | [INFO] [stderr] 378 | tree.insert(name.clone(), Json::I64(val.clone() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(val.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keyed.rs:378:57 [INFO] [stderr] | [INFO] [stderr] 378 | tree.insert(name.clone(), Json::I64(val.clone() as i64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plain.rs:416:9 [INFO] [stderr] | [INFO] [stderr] 416 | / match format { [INFO] [stderr] 417 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 418 | | Json::Array(self.values.iter().map(|&x| Json::I64(x as i64)).collect()) [INFO] [stderr] 419 | | } [INFO] [stderr] 420 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 416 | match *format { [INFO] [stderr] 417 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/keyed.rs:463:9 [INFO] [stderr] | [INFO] [stderr] 463 | / match format { [INFO] [stderr] 464 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 465 | | // Sort keys, for easier testing/comparison. [INFO] [stderr] 466 | | let mut values : Vec<_> = self.values.iter().collect(); [INFO] [stderr] ... | [INFO] [stderr] 476 | | } [INFO] [stderr] 477 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 463 | match *format { [INFO] [stderr] 464 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/keyed.rs:472:64 [INFO] [stderr] | [INFO] [stderr] 472 | let vec = array.iter().map(|&x| Json::I64(x.clone() as i64)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(x.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keyed.rs:472:64 [INFO] [stderr] | [INFO] [stderr] 472 | let vec = array.iter().map(|&x| Json::I64(x.clone() as i64)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plain.rs:418:67 [INFO] [stderr] | [INFO] [stderr] 418 | Json::Array(self.values.iter().map(|&x| Json::I64(x as i64)).collect()) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `keyed::KeyedIgnoring` [INFO] [stderr] --> src/keyed.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn new() -> KeyedIgnoring { [INFO] [stderr] 107 | | KeyedIgnoring { [INFO] [stderr] 108 | | witness: PhantomData [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/keyed.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / match format { [INFO] [stderr] 167 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 168 | | // Collect and sort the keys. [INFO] [stderr] 169 | | let mut keys : Vec<&String> = self.encountered.iter().collect(); [INFO] [stderr] ... | [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 166 | match *format { [INFO] [stderr] 167 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/keyed.rs:260:67 [INFO] [stderr] | [INFO] [stderr] 260 | let array = Json::Array(vec.iter().map(|&x| Json::I64(x as i64)).collect()); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keyed.rs:360:25 [INFO] [stderr] | [INFO] [stderr] 360 | let v = e.get().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*e.get()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/keyed.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | / match format { [INFO] [stderr] 370 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 371 | | // Sort keys, for easier testing/comparison. [INFO] [stderr] 372 | | let mut values : Vec<_> = self.values.iter().collect(); [INFO] [stderr] ... | [INFO] [stderr] 381 | | } [INFO] [stderr] 382 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 369 | match *format { [INFO] [stderr] 370 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/keyed.rs:378:57 [INFO] [stderr] | [INFO] [stderr] 378 | tree.insert(name.clone(), Json::I64(val.clone() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(val.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keyed.rs:378:57 [INFO] [stderr] | [INFO] [stderr] 378 | tree.insert(name.clone(), Json::I64(val.clone() as i64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/keyed.rs:463:9 [INFO] [stderr] | [INFO] [stderr] 463 | / match format { [INFO] [stderr] 464 | | &SerializationFormat::SimpleJson => { [INFO] [stderr] 465 | | // Sort keys, for easier testing/comparison. [INFO] [stderr] 466 | | let mut values : Vec<_> = self.values.iter().collect(); [INFO] [stderr] ... | [INFO] [stderr] 476 | | } [INFO] [stderr] 477 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 463 | match *format { [INFO] [stderr] 464 | SerializationFormat::SimpleJson => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/keyed.rs:472:64 [INFO] [stderr] | [INFO] [stderr] 472 | let vec = array.iter().map(|&x| Json::I64(x.clone() as i64)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(x.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keyed.rs:472:64 [INFO] [stderr] | [INFO] [stderr] 472 | let vec = array.iter().map(|&x| Json::I64(x.clone() as i64)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> examples/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | print!("{}\n", plain); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> examples/main.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | print!("{}\n", Json::Object(storage.clone()).pretty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Case` [INFO] [stderr] --> tests/lib.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | / enum TestEnum { [INFO] [stderr] 80 | | Case1, [INFO] [stderr] 81 | | Case2, [INFO] [stderr] 82 | | Case3(String) [INFO] [stderr] 83 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/lib.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / match self { [INFO] [stderr] 88 | | &TestEnum::Case1 => 0, [INFO] [stderr] 89 | | &TestEnum::Case2 => 1, [INFO] [stderr] 90 | | &TestEnum::Case3(_) => 2 [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 87 | match *self { [INFO] [stderr] 88 | TestEnum::Case1 => 0, [INFO] [stderr] 89 | TestEnum::Case2 => 1, [INFO] [stderr] 90 | TestEnum::Case3(_) => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `time::Duration` [INFO] [stderr] --> examples/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `telemetry::Flatten` [INFO] [stderr] --> examples/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use telemetry::Flatten; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> examples/main.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | Some(x) if x >= std::u32::MAX as i64 => std::u32::MAX, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.55s [INFO] running `"docker" "inspect" "ac1e6ee250f82ce66c3207db43dcba385ecbff200cf13f4e5e8b4741cdbdecf0"` [INFO] running `"docker" "rm" "-f" "ac1e6ee250f82ce66c3207db43dcba385ecbff200cf13f4e5e8b4741cdbdecf0"` [INFO] [stdout] ac1e6ee250f82ce66c3207db43dcba385ecbff200cf13f4e5e8b4741cdbdecf0