[INFO] crate telegram-bot 0.6.1 is already in cache [INFO] extracting crate telegram-bot 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/telegram-bot/0.6.1 [INFO] extracting crate telegram-bot 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telegram-bot/0.6.1 [INFO] validating manifest of telegram-bot-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of telegram-bot-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing telegram-bot-0.6.1 [INFO] finished frobbing telegram-bot-0.6.1 [INFO] frobbed toml for telegram-bot-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/telegram-bot/0.6.1/Cargo.toml [INFO] started frobbing telegram-bot-0.6.1 [INFO] finished frobbing telegram-bot-0.6.1 [INFO] frobbed toml for telegram-bot-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telegram-bot/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting telegram-bot-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/telegram-bot/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 533b71fd20a9b16321f1f5be698555385cf747ebd4b242db7cf36412951f42c1 [INFO] running `"docker" "start" "-a" "533b71fd20a9b16321f1f5be698555385cf747ebd4b242db7cf36412951f42c1"` [INFO] [stderr] Checking telegram-bot-raw v0.6.1 [INFO] [stderr] Checking telegram-bot v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stream.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | return Err(err) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stream.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | return Err(err) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/api.rs:213:50 [INFO] [stderr] | [INFO] [stderr] 213 | let send_future = self.send(request).map(|resp| Some(resp)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/api.rs:254:17 [INFO] [stderr] | [INFO] [stderr] 254 | let ref token = api.inner.token; [INFO] [stderr] | ----^^^^^^^^^------------------- help: try: `let token = &api.inner.token;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/api.rs:213:50 [INFO] [stderr] | [INFO] [stderr] 213 | let send_future = self.send(request).map(|resp| Some(resp)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/api.rs:254:17 [INFO] [stderr] | [INFO] [stderr] 254 | let ref token = api.inner.token; [INFO] [stderr] | ----^^^^^^^^^------------------- help: try: `let token = &api.inner.token;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/live_location.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | / match data.as_str() { [INFO] [stderr] 39 | | "/livelocation" => test(api.clone(), message.clone(), handle.clone()), [INFO] [stderr] 40 | | _ => (), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________________^ help: try this: `if let "/livelocation" = data.as_str() { test(api.clone(), message.clone(), handle.clone()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.39s [INFO] running `"docker" "inspect" "533b71fd20a9b16321f1f5be698555385cf747ebd4b242db7cf36412951f42c1"` [INFO] running `"docker" "rm" "-f" "533b71fd20a9b16321f1f5be698555385cf747ebd4b242db7cf36412951f42c1"` [INFO] [stdout] 533b71fd20a9b16321f1f5be698555385cf747ebd4b242db7cf36412951f42c1