[INFO] crate teko 0.1.9 is already in cache [INFO] extracting crate teko 0.1.9 into work/ex/clippy-test-run/sources/stable/reg/teko/0.1.9 [INFO] extracting crate teko 0.1.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/teko/0.1.9 [INFO] validating manifest of teko-0.1.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of teko-0.1.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing teko-0.1.9 [INFO] finished frobbing teko-0.1.9 [INFO] frobbed toml for teko-0.1.9 written to work/ex/clippy-test-run/sources/stable/reg/teko/0.1.9/Cargo.toml [INFO] started frobbing teko-0.1.9 [INFO] finished frobbing teko-0.1.9 [INFO] frobbed toml for teko-0.1.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/teko/0.1.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting teko-0.1.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/teko/0.1.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71c03d5356038459c09604427ef091091f51be6052a9f25a10b0f25aacb7791a [INFO] running `"docker" "start" "-a" "71c03d5356038459c09604427ef091091f51be6052a9f25a10b0f25aacb7791a"` [INFO] [stderr] Checking teko v0.1.9 (/opt/crater/workdir) [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parse.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | if !state.unmatched_opening_parentheses.pop().is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.unmatched_opening_parentheses.pop().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/utilities.rs:170:2 [INFO] [stderr] | [INFO] [stderr] 170 | fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | _____^ [INFO] [stderr] 171 | | use data_structures::{Boolean, Function, Macro}; [INFO] [stderr] 172 | | use data_structures::Commands::*; [INFO] [stderr] 173 | | use data_structures::Coredata::*; [INFO] [stderr] ... | [INFO] [stderr] 370 | | Ok(()) [INFO] [stderr] 371 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: item `data_structures::Sourcedata` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/utilities.rs:374:1 [INFO] [stderr] | [INFO] [stderr] 374 | / impl Sourcedata { [INFO] [stderr] 375 | | /// Return the head of a pair, unwind if not a pair. [INFO] [stderr] 376 | | pub fn head(&self) -> Option> { [INFO] [stderr] 377 | | if let Sourcedata(_, Coredata::Pair(ref head, _)) = *self { [INFO] [stderr] ... | [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parse.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | if !state.unmatched_opening_parentheses.pop().is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.unmatched_opening_parentheses.pop().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/parse.rs:244:2 [INFO] [stderr] | [INFO] [stderr] 244 | fn assert_expressions_ok() { [INFO] [stderr] | _____^ [INFO] [stderr] 245 | | assert_oks![ [INFO] [stderr] 246 | | parse_string, [INFO] [stderr] 247 | | "", [INFO] [stderr] ... | [INFO] [stderr] 281 | | ]; [INFO] [stderr] 282 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/utilities.rs:170:2 [INFO] [stderr] | [INFO] [stderr] 170 | fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | _____^ [INFO] [stderr] 171 | | use data_structures::{Boolean, Function, Macro}; [INFO] [stderr] 172 | | use data_structures::Commands::*; [INFO] [stderr] 173 | | use data_structures::Coredata::*; [INFO] [stderr] ... | [INFO] [stderr] 370 | | Ok(()) [INFO] [stderr] 371 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: item `data_structures::Sourcedata` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/utilities.rs:374:1 [INFO] [stderr] | [INFO] [stderr] 374 | / impl Sourcedata { [INFO] [stderr] 375 | | /// Return the head of a pair, unwind if not a pair. [INFO] [stderr] 376 | | pub fn head(&self) -> Option> { [INFO] [stderr] 377 | | if let Sourcedata(_, Coredata::Pair(ref head, _)) = *self { [INFO] [stderr] ... | [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.13s [INFO] running `"docker" "inspect" "71c03d5356038459c09604427ef091091f51be6052a9f25a10b0f25aacb7791a"` [INFO] running `"docker" "rm" "-f" "71c03d5356038459c09604427ef091091f51be6052a9f25a10b0f25aacb7791a"` [INFO] [stdout] 71c03d5356038459c09604427ef091091f51be6052a9f25a10b0f25aacb7791a