[INFO] crate tectonic_xdv 0.1.8 is already in cache [INFO] extracting crate tectonic_xdv 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/tectonic_xdv/0.1.8 [INFO] extracting crate tectonic_xdv 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tectonic_xdv/0.1.8 [INFO] validating manifest of tectonic_xdv-0.1.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tectonic_xdv-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tectonic_xdv-0.1.8 [INFO] finished frobbing tectonic_xdv-0.1.8 [INFO] frobbed toml for tectonic_xdv-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/tectonic_xdv/0.1.8/Cargo.toml [INFO] started frobbing tectonic_xdv-0.1.8 [INFO] finished frobbing tectonic_xdv-0.1.8 [INFO] frobbed toml for tectonic_xdv-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tectonic_xdv/0.1.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tectonic_xdv-0.1.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tectonic_xdv/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33336f3eb5acfe4667f7592472f50f09d6cccf0d9763589b82a4b37f853a7cd9 [INFO] running `"docker" "start" "-a" "33336f3eb5acfe4667f7592472f50f09d6cccf0d9763589b82a4b37f853a7cd9"` [INFO] [stderr] Checking tectonic_xdv v0.1.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | events: events, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `events` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:898:13 [INFO] [stderr] | [INFO] [stderr] 898 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:901:13 [INFO] [stderr] | [INFO] [stderr] 901 | global_offset: global_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | events: events, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `events` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:898:13 [INFO] [stderr] | [INFO] [stderr] 898 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:901:13 [INFO] [stderr] | [INFO] [stderr] 901 | global_offset: global_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:440:27 [INFO] [stderr] | [INFO] [stderr] 440 | cursor.assert_u32(25400000)?; // dimensions unit numerator [INFO] [stderr] | ^^^^^^^^ help: consider: `25_400_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:441:27 [INFO] [stderr] | [INFO] [stderr] 441 | cursor.assert_u32(473628672)?; // dimensions unit denominator [INFO] [stderr] | ^^^^^^^^^ help: consider: `473_628_672` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:802:27 [INFO] [stderr] | [INFO] [stderr] 802 | cursor.assert_u32(25400000)?; // dimensions unit numerator [INFO] [stderr] | ^^^^^^^^ help: consider: `25_400_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:803:27 [INFO] [stderr] | [INFO] [stderr] 803 | cursor.assert_u32(473628672)?; // dimensions unit denominator [INFO] [stderr] | ^^^^^^^^^ help: consider: `473_628_672` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:825:27 [INFO] [stderr] | [INFO] [stderr] 825 | cursor.assert_u32(0xDFDFDFDF)?; // at least four 0xDF's [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDFDF_DFDF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:440:27 [INFO] [stderr] | [INFO] [stderr] 440 | cursor.assert_u32(25400000)?; // dimensions unit numerator [INFO] [stderr] | ^^^^^^^^ help: consider: `25_400_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:441:27 [INFO] [stderr] | [INFO] [stderr] 441 | cursor.assert_u32(473628672)?; // dimensions unit denominator [INFO] [stderr] | ^^^^^^^^^ help: consider: `473_628_672` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:802:27 [INFO] [stderr] | [INFO] [stderr] 802 | cursor.assert_u32(25400000)?; // dimensions unit numerator [INFO] [stderr] | ^^^^^^^^ help: consider: `25_400_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:803:27 [INFO] [stderr] | [INFO] [stderr] 803 | cursor.assert_u32(473628672)?; // dimensions unit denominator [INFO] [stderr] | ^^^^^^^^^ help: consider: `473_628_672` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:825:27 [INFO] [stderr] | [INFO] [stderr] 825 | cursor.assert_u32(0xDFDFDFDF)?; // at least four 0xDF's [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDFDF_DFDF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &XdvError::Malformed(offset) => [INFO] [stderr] 45 | | write!(f, "unexpected XDV data at byte offset {}", offset), [INFO] [stderr] 46 | | &XdvError::IllegalOpcode(opcode, offset) => [INFO] [stderr] ... | [INFO] [stderr] 49 | | write!(f, "stream ended unexpectedly soon"), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | XdvError::Malformed(offset) => [INFO] [stderr] 45 | write!(f, "unexpected XDV data at byte offset {}", offset), [INFO] [stderr] 46 | XdvError::IllegalOpcode(opcode, offset) => [INFO] [stderr] 47 | write!(f, "illegal XDV opcode {} at byte offset {}", opcode, offset), [INFO] [stderr] 48 | XdvError::UnexpectedEndOfStream => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match self { [INFO] [stderr] 57 | | &XdvError::Malformed(_) => "malformed XDV data", [INFO] [stderr] 58 | | &XdvError::IllegalOpcode(_, _) => "illegal XDV opcode", [INFO] [stderr] 59 | | &XdvError::UnexpectedEndOfStream => "stream ended unexpectedly soon", [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *self { [INFO] [stderr] 57 | XdvError::Malformed(_) => "malformed XDV data", [INFO] [stderr] 58 | XdvError::IllegalOpcode(_, _) => "illegal XDV opcode", [INFO] [stderr] 59 | XdvError::UnexpectedEndOfStream => "stream ended unexpectedly soon", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 162 | | &FileType::Xdv => "XDV", [INFO] [stderr] 163 | | &FileType::Spx => "SPX", [INFO] [stderr] 164 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 161 | write!(f, "{}", match *self { [INFO] [stderr] 162 | FileType::Xdv => "XDV", [INFO] [stderr] 163 | FileType::Spx => "SPX", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:243:36 [INFO] [stderr] | [INFO] [stderr] 243 | unsafe { ptr::copy(ptr.offset(n_consumed as isize), ptr, n_saved_bytes); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(n_consumed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | / pub fn parse(&mut self, chunk: &[u8]) -> Result { [INFO] [stderr] 271 | | let mut cursor = Cursor::new(chunk, self.offset); [INFO] [stderr] 272 | | [INFO] [stderr] 273 | | while cursor.remaining() > 0 { [INFO] [stderr] ... | [INFO] [stderr] 423 | | Ok(cursor.checkpoint) [INFO] [stderr] 424 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:416:34 [INFO] [stderr] | [INFO] [stderr] 416 | if char_run_ended && self.cur_char_run.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.cur_char_run.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `counters`. [INFO] [stderr] --> src/lib.rs:519:18 [INFO] [stderr] | [INFO] [stderr] 519 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 519 | for in &mut counters { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:697:34 [INFO] [stderr] | [INFO] [stderr] 697 | self.cur_font_num = Some((opcode - Opcode::SetFontNumber0 as u8) as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(opcode - Opcode::SetFontNumber0 as u8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:719:32 [INFO] [stderr] | [INFO] [stderr] 719 | self.cur_char_run.push(char_num as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(char_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:925:12 [INFO] [stderr] | [INFO] [stderr] 925 | if self.buf.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:944:12 [INFO] [stderr] | [INFO] [stderr] 944 | if self.buf.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1011:21 [INFO] [stderr] | [INFO] [stderr] 1011 | 0 => Ok(self.get_u8()? as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1012:21 [INFO] [stderr] | [INFO] [stderr] 1012 | 1 => Ok(self.get_u16()? as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_u16()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1041:21 [INFO] [stderr] | [INFO] [stderr] 1041 | 0 => Ok(self.get_i8()? as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.get_i8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1042:21 [INFO] [stderr] | [INFO] [stderr] 1042 | 1 => Ok(self.get_i16()? as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.get_i16()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1052:21 [INFO] [stderr] | [INFO] [stderr] 1052 | 0 => Ok(self.get_u8()? as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.get_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1053:21 [INFO] [stderr] | [INFO] [stderr] 1053 | 1 => Ok(self.get_u16()? as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.get_u16()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &XdvError::Malformed(offset) => [INFO] [stderr] 45 | | write!(f, "unexpected XDV data at byte offset {}", offset), [INFO] [stderr] 46 | | &XdvError::IllegalOpcode(opcode, offset) => [INFO] [stderr] ... | [INFO] [stderr] 49 | | write!(f, "stream ended unexpectedly soon"), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | XdvError::Malformed(offset) => [INFO] [stderr] 45 | write!(f, "unexpected XDV data at byte offset {}", offset), [INFO] [stderr] 46 | XdvError::IllegalOpcode(opcode, offset) => [INFO] [stderr] 47 | write!(f, "illegal XDV opcode {} at byte offset {}", opcode, offset), [INFO] [stderr] 48 | XdvError::UnexpectedEndOfStream => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match self { [INFO] [stderr] 57 | | &XdvError::Malformed(_) => "malformed XDV data", [INFO] [stderr] 58 | | &XdvError::IllegalOpcode(_, _) => "illegal XDV opcode", [INFO] [stderr] 59 | | &XdvError::UnexpectedEndOfStream => "stream ended unexpectedly soon", [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *self { [INFO] [stderr] 57 | XdvError::Malformed(_) => "malformed XDV data", [INFO] [stderr] 58 | XdvError::IllegalOpcode(_, _) => "illegal XDV opcode", [INFO] [stderr] 59 | XdvError::UnexpectedEndOfStream => "stream ended unexpectedly soon", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 162 | | &FileType::Xdv => "XDV", [INFO] [stderr] 163 | | &FileType::Spx => "SPX", [INFO] [stderr] 164 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 161 | write!(f, "{}", match *self { [INFO] [stderr] 162 | FileType::Xdv => "XDV", [INFO] [stderr] 163 | FileType::Spx => "SPX", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:243:36 [INFO] [stderr] | [INFO] [stderr] 243 | unsafe { ptr::copy(ptr.offset(n_consumed as isize), ptr, n_saved_bytes); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(n_consumed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | / pub fn parse(&mut self, chunk: &[u8]) -> Result { [INFO] [stderr] 271 | | let mut cursor = Cursor::new(chunk, self.offset); [INFO] [stderr] 272 | | [INFO] [stderr] 273 | | while cursor.remaining() > 0 { [INFO] [stderr] ... | [INFO] [stderr] 423 | | Ok(cursor.checkpoint) [INFO] [stderr] 424 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:416:34 [INFO] [stderr] | [INFO] [stderr] 416 | if char_run_ended && self.cur_char_run.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.cur_char_run.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `counters`. [INFO] [stderr] --> src/lib.rs:519:18 [INFO] [stderr] | [INFO] [stderr] 519 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 519 | for in &mut counters { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:697:34 [INFO] [stderr] | [INFO] [stderr] 697 | self.cur_font_num = Some((opcode - Opcode::SetFontNumber0 as u8) as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(opcode - Opcode::SetFontNumber0 as u8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:719:32 [INFO] [stderr] | [INFO] [stderr] 719 | self.cur_char_run.push(char_num as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(char_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:925:12 [INFO] [stderr] | [INFO] [stderr] 925 | if self.buf.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:944:12 [INFO] [stderr] | [INFO] [stderr] 944 | if self.buf.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1011:21 [INFO] [stderr] | [INFO] [stderr] 1011 | 0 => Ok(self.get_u8()? as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1012:21 [INFO] [stderr] | [INFO] [stderr] 1012 | 1 => Ok(self.get_u16()? as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_u16()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1041:21 [INFO] [stderr] | [INFO] [stderr] 1041 | 0 => Ok(self.get_i8()? as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.get_i8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1042:21 [INFO] [stderr] | [INFO] [stderr] 1042 | 1 => Ok(self.get_i16()? as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.get_i16()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1052:21 [INFO] [stderr] | [INFO] [stderr] 1052 | 0 => Ok(self.get_u8()? as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.get_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1053:21 [INFO] [stderr] | [INFO] [stderr] 1053 | 1 => Ok(self.get_u16()? as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.get_u16()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.30s [INFO] running `"docker" "inspect" "33336f3eb5acfe4667f7592472f50f09d6cccf0d9763589b82a4b37f853a7cd9"` [INFO] running `"docker" "rm" "-f" "33336f3eb5acfe4667f7592472f50f09d6cccf0d9763589b82a4b37f853a7cd9"` [INFO] [stdout] 33336f3eb5acfe4667f7592472f50f09d6cccf0d9763589b82a4b37f853a7cd9