[INFO] crate tealdeer 1.1.0 is already in cache [INFO] extracting crate tealdeer 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/tealdeer/1.1.0 [INFO] extracting crate tealdeer 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tealdeer/1.1.0 [INFO] validating manifest of tealdeer-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tealdeer-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tealdeer-1.1.0 [INFO] finished frobbing tealdeer-1.1.0 [INFO] frobbed toml for tealdeer-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/tealdeer/1.1.0/Cargo.toml [INFO] started frobbing tealdeer-1.1.0 [INFO] finished frobbing tealdeer-1.1.0 [INFO] frobbed toml for tealdeer-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tealdeer/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tealdeer-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tealdeer/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 336b1bec89d6e61ce9b2027f77ad95900b77437a1c66b681dd04464a5202959d [INFO] running `"docker" "start" "-a" "336b1bec89d6e61ce9b2027f77ad95900b77437a1c66b681dd04464a5202959d"` [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling curl-sys v0.4.16 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking utime v0.2.1 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] Checking tar v0.4.20 [INFO] [stderr] Checking curl v0.4.19 [INFO] [stderr] Checking tealdeer v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | os: os, [INFO] [stderr] | ^^^^^^ help: replace it with: `os` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | os: os, [INFO] [stderr] | ^^^^^^ help: replace it with: `os` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> tests/lib.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | let _ = utime::set_file_times(testenv.cache_dir.path().join("tldr-master"), 1, 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/lib.rs:209:5 [INFO] [stderr] | [INFO] [stderr] 209 | / config_file [INFO] [stderr] 210 | | .write(include_str!("config.toml").as_bytes()) [INFO] [stderr] 211 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on `include_str!(..)` [INFO] [stderr] --> tests/lib.rs:210:16 [INFO] [stderr] | [INFO] [stderr] 210 | .write(include_str!("config.toml").as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `include_bytes!(..)` instead: `include_bytes!("config.toml")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on `include_str!(..)` [INFO] [stderr] --> tests/lib.rs:218:20 [INFO] [stderr] | [INFO] [stderr] 218 | file.write_all(include_str!("inkscape-v2.md").as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `include_bytes!(..)` instead: `include_bytes!("inkscape-v2.md")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tealdeer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | const MAX_CACHE_AGE: i64 = 2592000; // 30 days [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | const MAX_CACHE_AGE: i64 = 2592000; // 30 days [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "336b1bec89d6e61ce9b2027f77ad95900b77437a1c66b681dd04464a5202959d"` [INFO] running `"docker" "rm" "-f" "336b1bec89d6e61ce9b2027f77ad95900b77437a1c66b681dd04464a5202959d"` [INFO] [stdout] 336b1bec89d6e61ce9b2027f77ad95900b77437a1c66b681dd04464a5202959d