[INFO] crate tdo-export 0.2.1 is already in cache
[INFO] extracting crate tdo-export 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/tdo-export/0.2.1
[INFO] extracting crate tdo-export 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tdo-export/0.2.1
[INFO] validating manifest of tdo-export-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tdo-export-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tdo-export-0.2.1
[INFO] finished frobbing tdo-export-0.2.1
[INFO] frobbed toml for tdo-export-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/tdo-export/0.2.1/Cargo.toml
[INFO] started frobbing tdo-export-0.2.1
[INFO] finished frobbing tdo-export-0.2.1
[INFO] frobbed toml for tdo-export-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tdo-export/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tdo-export-0.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tdo-export/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cc8172c746132b740959b725f4512acb1b391b26a3f826783bcfc841d1298da0
[INFO] running `"docker" "start" "-a" "cc8172c746132b740959b725f4512acb1b391b26a3f826783bcfc841d1298da0"`
[INFO] [stderr]     Checking tdo-core v0.2.1
[INFO] [stderr]     Checking reqwest v0.5.2
[INFO] [stderr]     Checking tdo-export v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:247:14
[INFO] [stderr]     |
[INFO] [stderr] 247 |         _ => return Err(io::Error::new(io::ErrorKind::InvalidData, "No valid data.")),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, "No valid data."))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:36:12
[INFO] [stderr]    |
[INFO] [stderr] 36 |         if undone.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!undone.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 | /         let tasks: Vec<tdo_core::todo::Todo>;
[INFO] [stderr] 64 | |         if list_done {
[INFO] [stderr] 65 | |             tasks = list.list.to_owned();
[INFO] [stderr] 66 | |         } else {
[INFO] [stderr] 67 | |             tasks = list.list_undone();
[INFO] [stderr] 68 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let tasks = if list_done { list.list.to_owned() } else { list.list_undone() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:69:12
[INFO] [stderr]    |
[INFO] [stderr] 69 |         if tasks.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tasks.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 | /         let tasks: Vec<tdo_core::todo::Todo>;
[INFO] [stderr] 110 | |         if all {
[INFO] [stderr] 111 | |             tasks = list.list.to_owned();
[INFO] [stderr] 112 | |         } else {
[INFO] [stderr] 113 | |             tasks = list.list_undone();
[INFO] [stderr] 114 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let tasks = if all { list.list.to_owned() } else { list.list_undone() };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:116:12
[INFO] [stderr]     |
[INFO] [stderr] 116 |         if tasks.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tasks.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:161:13
[INFO] [stderr]     |
[INFO] [stderr] 161 | /             match content.status() {
[INFO] [stderr] 162 | |
[INFO] [stderr] 163 | |                 &reqwest::StatusCode::Created => {
[INFO] [stderr] 164 | |                     let response: tdo_core::todo::GHIssueResponse = content.json().unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 170 | |                 _ => Err(ErrorKind::GithubError(github_error::ErrorKind::UnknownError).into()),
[INFO] [stderr] 171 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 161 |             match *content.status() {
[INFO] [stderr] 162 | 
[INFO] [stderr] 163 |                 reqwest::StatusCode::Created => {
[INFO] [stderr] 164 |                     let response: tdo_core::todo::GHIssueResponse = content.json().unwrap();
[INFO] [stderr] 165 |                     Ok(tdo_core::todo::GitHub::new(repo, response.number))
[INFO] [stderr] 166 |                 }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:189:13
[INFO] [stderr]     |
[INFO] [stderr] 189 | /             match content.status() {
[INFO] [stderr] 190 | |                 &reqwest::StatusCode::Ok => {
[INFO] [stderr] 191 | |                     let response: tdo_core::todo::GHIssueResponse = content.json().unwrap();
[INFO] [stderr] 192 | |                     if todo.name != response.title {
[INFO] [stderr] ...   |
[INFO] [stderr] 206 | |                 }
[INFO] [stderr] 207 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 189 |             match *content.status() {
[INFO] [stderr] 190 |                 reqwest::StatusCode::Ok => {
[INFO] [stderr] 191 |                     let response: tdo_core::todo::GHIssueResponse = content.json().unwrap();
[INFO] [stderr] 192 |                     if todo.name != response.title {
[INFO] [stderr] 193 |                         todo.edit(&response.title);
[INFO] [stderr] 194 |                     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:224:44
[INFO] [stderr]     |
[INFO] [stderr] 224 |         let results: Vec<&str> = res.split(",").collect();
[INFO] [stderr]     |                                            ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:254:11
[INFO] [stderr]     |
[INFO] [stderr] 254 |     while temp_vec.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!temp_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:264:16
[INFO] [stderr]     |
[INFO] [stderr] 264 |             if temp_vec.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `temp_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:273:16
[INFO] [stderr]     |
[INFO] [stderr] 273 |             if temp_vec.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `temp_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:247:14
[INFO] [stderr]     |
[INFO] [stderr] 247 |         _ => return Err(io::Error::new(io::ErrorKind::InvalidData, "No valid data.")),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, "No valid data."))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:36:12
[INFO] [stderr]    |
[INFO] [stderr] 36 |         if undone.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!undone.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 | /         let tasks: Vec<tdo_core::todo::Todo>;
[INFO] [stderr] 64 | |         if list_done {
[INFO] [stderr] 65 | |             tasks = list.list.to_owned();
[INFO] [stderr] 66 | |         } else {
[INFO] [stderr] 67 | |             tasks = list.list_undone();
[INFO] [stderr] 68 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let tasks = if list_done { list.list.to_owned() } else { list.list_undone() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:69:12
[INFO] [stderr]    |
[INFO] [stderr] 69 |         if tasks.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tasks.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 | /         let tasks: Vec<tdo_core::todo::Todo>;
[INFO] [stderr] 110 | |         if all {
[INFO] [stderr] 111 | |             tasks = list.list.to_owned();
[INFO] [stderr] 112 | |         } else {
[INFO] [stderr] 113 | |             tasks = list.list_undone();
[INFO] [stderr] 114 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let tasks = if all { list.list.to_owned() } else { list.list_undone() };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:116:12
[INFO] [stderr]     |
[INFO] [stderr] 116 |         if tasks.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tasks.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:161:13
[INFO] [stderr]     |
[INFO] [stderr] 161 | /             match content.status() {
[INFO] [stderr] 162 | |
[INFO] [stderr] 163 | |                 &reqwest::StatusCode::Created => {
[INFO] [stderr] 164 | |                     let response: tdo_core::todo::GHIssueResponse = content.json().unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 170 | |                 _ => Err(ErrorKind::GithubError(github_error::ErrorKind::UnknownError).into()),
[INFO] [stderr] 171 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 161 |             match *content.status() {
[INFO] [stderr] 162 | 
[INFO] [stderr] 163 |                 reqwest::StatusCode::Created => {
[INFO] [stderr] 164 |                     let response: tdo_core::todo::GHIssueResponse = content.json().unwrap();
[INFO] [stderr] 165 |                     Ok(tdo_core::todo::GitHub::new(repo, response.number))
[INFO] [stderr] 166 |                 }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:189:13
[INFO] [stderr]     |
[INFO] [stderr] 189 | /             match content.status() {
[INFO] [stderr] 190 | |                 &reqwest::StatusCode::Ok => {
[INFO] [stderr] 191 | |                     let response: tdo_core::todo::GHIssueResponse = content.json().unwrap();
[INFO] [stderr] 192 | |                     if todo.name != response.title {
[INFO] [stderr] ...   |
[INFO] [stderr] 206 | |                 }
[INFO] [stderr] 207 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 189 |             match *content.status() {
[INFO] [stderr] 190 |                 reqwest::StatusCode::Ok => {
[INFO] [stderr] 191 |                     let response: tdo_core::todo::GHIssueResponse = content.json().unwrap();
[INFO] [stderr] 192 |                     if todo.name != response.title {
[INFO] [stderr] 193 |                         todo.edit(&response.title);
[INFO] [stderr] 194 |                     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:224:44
[INFO] [stderr]     |
[INFO] [stderr] 224 |         let results: Vec<&str> = res.split(",").collect();
[INFO] [stderr]     |                                            ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:254:11
[INFO] [stderr]     |
[INFO] [stderr] 254 |     while temp_vec.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!temp_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:264:16
[INFO] [stderr]     |
[INFO] [stderr] 264 |             if temp_vec.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `temp_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:273:16
[INFO] [stderr]     |
[INFO] [stderr] 273 |             if temp_vec.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `temp_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.72s
[INFO] running `"docker" "inspect" "cc8172c746132b740959b725f4512acb1b391b26a3f826783bcfc841d1298da0"`
[INFO] running `"docker" "rm" "-f" "cc8172c746132b740959b725f4512acb1b391b26a3f826783bcfc841d1298da0"`
[INFO] [stdout] cc8172c746132b740959b725f4512acb1b391b26a3f826783bcfc841d1298da0