[INFO] crate tdo 2.2.0 is already in cache
[INFO] extracting crate tdo 2.2.0 into work/ex/clippy-test-run/sources/stable/reg/tdo/2.2.0
[INFO] extracting crate tdo 2.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tdo/2.2.0
[INFO] validating manifest of tdo-2.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tdo-2.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tdo-2.2.0
[INFO] finished frobbing tdo-2.2.0
[INFO] frobbed toml for tdo-2.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tdo/2.2.0/Cargo.toml
[INFO] started frobbing tdo-2.2.0
[INFO] finished frobbing tdo-2.2.0
[INFO] frobbed toml for tdo-2.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tdo/2.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tdo-2.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tdo/2.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f813bd34a9b75f6926411232253661fdba63dcc921bdfa50dba29777f99e492a
[INFO] running `"docker" "start" "-a" "f813bd34a9b75f6926411232253661fdba63dcc921bdfa50dba29777f99e492a"`
[INFO] [stderr]     Checking tdo-core v0.2.1
[INFO] [stderr]     Checking reqwest v0.5.2
[INFO] [stderr]     Checking tdo-export v0.2.1
[INFO] [stderr]     Checking tdo v2.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/filesystem.rs:78:16
[INFO] [stderr]    |
[INFO] [stderr] 78 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 79 | |             if ask_user("The path to the target directory does not exist. Create it?") {
[INFO] [stderr] 80 | |                 let _ = match DirBuilder::new().recursive(true).create(parent_dir) {
[INFO] [stderr] 81 | |                     Ok(b) => b,
[INFO] [stderr] ...  |
[INFO] [stderr] 87 | |             }
[INFO] [stderr] 88 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 78 |         } else if ask_user("The path to the target directory does not exist. Create it?") {
[INFO] [stderr] 79 |     let _ = match DirBuilder::new().recursive(true).create(parent_dir) {
[INFO] [stderr] 80 |         Ok(b) => b,
[INFO] [stderr] 81 |         Err(err) => return Err(ValidationError::BuildDirErr(err).into()),
[INFO] [stderr] 82 |     };
[INFO] [stderr] 83 |     Ok(path.to_owned())
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:24:27
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let save_path = match env::home_dir() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/filesystem.rs:78:16
[INFO] [stderr]    |
[INFO] [stderr] 78 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 79 | |             if ask_user("The path to the target directory does not exist. Create it?") {
[INFO] [stderr] 80 | |                 let _ = match DirBuilder::new().recursive(true).create(parent_dir) {
[INFO] [stderr] 81 | |                     Ok(b) => b,
[INFO] [stderr] ...  |
[INFO] [stderr] 87 | |             }
[INFO] [stderr] 88 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 78 |         } else if ask_user("The path to the target directory does not exist. Create it?") {
[INFO] [stderr] 79 |     let _ = match DirBuilder::new().recursive(true).create(parent_dir) {
[INFO] [stderr] 80 |         Ok(b) => b,
[INFO] [stderr] 81 |         Err(err) => return Err(ValidationError::BuildDirErr(err).into()),
[INFO] [stderr] 82 |     };
[INFO] [stderr] 83 |     Ok(path.to_owned())
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:24:27
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let save_path = match env::home_dir() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/filesystem.rs:22:51
[INFO] [stderr]    |
[INFO] [stderr] 22 |             ValidationError::EnvError(ref err) => err.description().clone(),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 22 |             ValidationError::EnvError(ref err) => &(*err.description()).clone(),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 22 |             ValidationError::EnvError(ref err) => &str::clone(err.description()),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/filesystem.rs:23:54
[INFO] [stderr]    |
[INFO] [stderr] 23 |             ValidationError::BuildDirErr(ref err) => err.description().clone(),
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 23 |             ValidationError::BuildDirErr(ref err) => &(*err.description()).clone(),
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 23 |             ValidationError::BuildDirErr(ref err) => &str::clone(err.description()),
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/filesystem.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         io::stdout().flush().ok().expect("Could not flush stdout");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/filesystem.rs:58:34
[INFO] [stderr]    |
[INFO] [stderr] 58 |             Err(e) => return Err(ValidationError::EnvError(e).into()),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ValidationError::EnvError(e)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/filesystem.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |             Err(ValidationError::TargetIsADir.into())
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ValidationError::TargetIsADir`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/filesystem.rs:80:17
[INFO] [stderr]    |
[INFO] [stderr] 80 | /                 let _ = match DirBuilder::new().recursive(true).create(parent_dir) {
[INFO] [stderr] 81 | |                     Ok(b) => b,
[INFO] [stderr] 82 | |                     Err(err) => return Err(ValidationError::BuildDirErr(err).into()),
[INFO] [stderr] 83 | |                 };
[INFO] [stderr]    | |__________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/filesystem.rs:82:44
[INFO] [stderr]    |
[INFO] [stderr] 82 |                     Err(err) => return Err(ValidationError::BuildDirErr(err).into()),
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ValidationError::BuildDirErr(err)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/filesystem.rs:86:21
[INFO] [stderr]    |
[INFO] [stderr] 86 |                 Err(ValidationError::UserAbort.into())
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ValidationError::UserAbort`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/subcommands.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     match tdo.add_todo(in_list, todo) {
[INFO] [stderr] 23 | |         Err(e) => errorprint!(e.description()),
[INFO] [stderr] 24 | |         _ => {}
[INFO] [stderr] 25 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Err(e) = tdo.add_todo(in_list, todo) { errorprint!(e.description()) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/subcommands.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     stdout().flush().ok().expect("Could not flush stdout!");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/subcommands.rs:109:13
[INFO] [stderr]     |
[INFO] [stderr] 109 | /             match tdo.add_todo(None, todo) {
[INFO] [stderr] 110 | |                 Err(e) => errorprint!(e.description()),
[INFO] [stderr] 111 | |                 _ => {}
[INFO] [stderr] 112 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Err(e) = tdo.add_todo(None, todo) { errorprint!(e.description()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/subcommands.rs:121:16
[INFO] [stderr]     |
[INFO] [stderr] 121 |           if let Some(_) = todo.github {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 122 | |             match tdo_export::update_github_issue(&todo, &tdo.get_gh_token().unwrap()) {
[INFO] [stderr] 123 | |                 Ok(res) => list.add(res),
[INFO] [stderr] 124 | |                 Err(x) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 130 | |             list.add(todo);
[INFO] [stderr] 131 | |         }
[INFO] [stderr]     | |_________- help: try this: `if todo.github.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/subcommands.rs:140:13
[INFO] [stderr]     |
[INFO] [stderr] 140 | /             match tdo.clean_list(name) {
[INFO] [stderr] 141 | |                 Err(e) => errorprint!(e.description()),
[INFO] [stderr] 142 | |                 _ => {}
[INFO] [stderr] 143 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Err(e) = tdo.clean_list(name) { errorprint!(e.description()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/subcommands.rs:155:28
[INFO] [stderr]     |
[INFO] [stderr] 155 |             .fold(0, |acc, &ref item| if item.done { acc + 1 } else { acc });
[INFO] [stderr]     |                            ^^^^^^^^^ help: try removing the `&ref` part and just keep: `item`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_borrowed_reference)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/subcommands.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 | /             file.write(&tdo_export::gen_tasks_md(tdo, true).unwrap().into_bytes())
[INFO] [stderr] 175 | |                 .unwrap();
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/subcommands.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 |     stdout().flush().ok().expect("Could not flush stdout!");
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:166:21
[INFO] [stderr]     |
[INFO] [stderr] 166 | /                     match subcommands::reset(&mut tdo) {
[INFO] [stderr] 167 | |                         Some(x) => tdo = x,
[INFO] [stderr] 168 | |                         None => {}
[INFO] [stderr] 169 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Some(x) = subcommands::reset(&mut tdo) { tdo = x }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:182:5
[INFO] [stderr]     |
[INFO] [stderr] 182 | /     match tdo.save(target.to_str().unwrap()) {
[INFO] [stderr] 183 | |         Err(e) => errorprint!(e),
[INFO] [stderr] 184 | |         _ => {}
[INFO] [stderr] 185 | |     }
[INFO] [stderr]     | |_____^ help: try this: `if let Err(e) = tdo.save(target.to_str().unwrap()) { errorprint!(e) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tdo`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/filesystem.rs:22:51
[INFO] [stderr]    |
[INFO] [stderr] 22 |             ValidationError::EnvError(ref err) => err.description().clone(),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 22 |             ValidationError::EnvError(ref err) => &(*err.description()).clone(),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 22 |             ValidationError::EnvError(ref err) => &str::clone(err.description()),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/filesystem.rs:23:54
[INFO] [stderr]    |
[INFO] [stderr] 23 |             ValidationError::BuildDirErr(ref err) => err.description().clone(),
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 23 |             ValidationError::BuildDirErr(ref err) => &(*err.description()).clone(),
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 23 |             ValidationError::BuildDirErr(ref err) => &str::clone(err.description()),
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/filesystem.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         io::stdout().flush().ok().expect("Could not flush stdout");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/filesystem.rs:58:34
[INFO] [stderr]    |
[INFO] [stderr] 58 |             Err(e) => return Err(ValidationError::EnvError(e).into()),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ValidationError::EnvError(e)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/filesystem.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |             Err(ValidationError::TargetIsADir.into())
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ValidationError::TargetIsADir`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/filesystem.rs:80:17
[INFO] [stderr]    |
[INFO] [stderr] 80 | /                 let _ = match DirBuilder::new().recursive(true).create(parent_dir) {
[INFO] [stderr] 81 | |                     Ok(b) => b,
[INFO] [stderr] 82 | |                     Err(err) => return Err(ValidationError::BuildDirErr(err).into()),
[INFO] [stderr] 83 | |                 };
[INFO] [stderr]    | |__________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/filesystem.rs:82:44
[INFO] [stderr]    |
[INFO] [stderr] 82 |                     Err(err) => return Err(ValidationError::BuildDirErr(err).into()),
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ValidationError::BuildDirErr(err)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/filesystem.rs:86:21
[INFO] [stderr]    |
[INFO] [stderr] 86 |                 Err(ValidationError::UserAbort.into())
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ValidationError::UserAbort`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/subcommands.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     match tdo.add_todo(in_list, todo) {
[INFO] [stderr] 23 | |         Err(e) => errorprint!(e.description()),
[INFO] [stderr] 24 | |         _ => {}
[INFO] [stderr] 25 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Err(e) = tdo.add_todo(in_list, todo) { errorprint!(e.description()) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/subcommands.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     stdout().flush().ok().expect("Could not flush stdout!");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/subcommands.rs:109:13
[INFO] [stderr]     |
[INFO] [stderr] 109 | /             match tdo.add_todo(None, todo) {
[INFO] [stderr] 110 | |                 Err(e) => errorprint!(e.description()),
[INFO] [stderr] 111 | |                 _ => {}
[INFO] [stderr] 112 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Err(e) = tdo.add_todo(None, todo) { errorprint!(e.description()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/subcommands.rs:121:16
[INFO] [stderr]     |
[INFO] [stderr] 121 |           if let Some(_) = todo.github {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 122 | |             match tdo_export::update_github_issue(&todo, &tdo.get_gh_token().unwrap()) {
[INFO] [stderr] 123 | |                 Ok(res) => list.add(res),
[INFO] [stderr] 124 | |                 Err(x) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 130 | |             list.add(todo);
[INFO] [stderr] 131 | |         }
[INFO] [stderr]     | |_________- help: try this: `if todo.github.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/subcommands.rs:140:13
[INFO] [stderr]     |
[INFO] [stderr] 140 | /             match tdo.clean_list(name) {
[INFO] [stderr] 141 | |                 Err(e) => errorprint!(e.description()),
[INFO] [stderr] 142 | |                 _ => {}
[INFO] [stderr] 143 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Err(e) = tdo.clean_list(name) { errorprint!(e.description()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/subcommands.rs:155:28
[INFO] [stderr]     |
[INFO] [stderr] 155 |             .fold(0, |acc, &ref item| if item.done { acc + 1 } else { acc });
[INFO] [stderr]     |                            ^^^^^^^^^ help: try removing the `&ref` part and just keep: `item`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_borrowed_reference)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/subcommands.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 | /             file.write(&tdo_export::gen_tasks_md(tdo, true).unwrap().into_bytes())
[INFO] [stderr] 175 | |                 .unwrap();
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/subcommands.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 |     stdout().flush().ok().expect("Could not flush stdout!");
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:166:21
[INFO] [stderr]     |
[INFO] [stderr] 166 | /                     match subcommands::reset(&mut tdo) {
[INFO] [stderr] 167 | |                         Some(x) => tdo = x,
[INFO] [stderr] 168 | |                         None => {}
[INFO] [stderr] 169 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Some(x) = subcommands::reset(&mut tdo) { tdo = x }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:182:5
[INFO] [stderr]     |
[INFO] [stderr] 182 | /     match tdo.save(target.to_str().unwrap()) {
[INFO] [stderr] 183 | |         Err(e) => errorprint!(e),
[INFO] [stderr] 184 | |         _ => {}
[INFO] [stderr] 185 | |     }
[INFO] [stderr]     | |_____^ help: try this: `if let Err(e) = tdo.save(target.to_str().unwrap()) { errorprint!(e) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tdo`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "f813bd34a9b75f6926411232253661fdba63dcc921bdfa50dba29777f99e492a"`
[INFO] running `"docker" "rm" "-f" "f813bd34a9b75f6926411232253661fdba63dcc921bdfa50dba29777f99e492a"`
[INFO] [stdout] f813bd34a9b75f6926411232253661fdba63dcc921bdfa50dba29777f99e492a