[INFO] crate tdesktop_theme 0.3.0 is already in cache [INFO] extracting crate tdesktop_theme 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/tdesktop_theme/0.3.0 [INFO] extracting crate tdesktop_theme 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tdesktop_theme/0.3.0 [INFO] validating manifest of tdesktop_theme-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tdesktop_theme-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tdesktop_theme-0.3.0 [INFO] finished frobbing tdesktop_theme-0.3.0 [INFO] frobbed toml for tdesktop_theme-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/tdesktop_theme/0.3.0/Cargo.toml [INFO] started frobbing tdesktop_theme-0.3.0 [INFO] finished frobbing tdesktop_theme-0.3.0 [INFO] frobbed toml for tdesktop_theme-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tdesktop_theme/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tdesktop_theme-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tdesktop_theme/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e99729fcd6bd8c4c6741a239896571e3afbec16b2ff12c9ce418774aec20a01e [INFO] running `"docker" "start" "-a" "e99729fcd6bd8c4c6741a239896571e3afbec16b2ff12c9ce418774aec20a01e"` [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking tdesktop_theme v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:146:8 [INFO] [stderr] | [INFO] [stderr] 146 | if digit >= &b'0' && digit <= &b'9' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:146:26 [INFO] [stderr] | [INFO] [stderr] 146 | if digit >= &b'0' && digit <= &b'9' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | } else if digit >= &b'a' && digit <= &b'f' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'a'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:148:33 [INFO] [stderr] | [INFO] [stderr] 148 | } else if digit >= &b'a' && digit <= &b'f' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'f'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:150:15 [INFO] [stderr] | [INFO] [stderr] 150 | } else if digit >= &b'A' && digit <= &b'F' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'A'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | } else if digit >= &b'A' && digit <= &b'F' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'F'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parse.rs:279:28 [INFO] [stderr] | [INFO] [stderr] 279 | token: &contents[index..index + 1], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `index..=index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/parse.rs:285:19 [INFO] [stderr] | [INFO] [stderr] 285 | _ => if let None = token_start_index { [INFO] [stderr] | ____________- ^^^^ [INFO] [stderr] 286 | | token_start_index = Some(index); [INFO] [stderr] 287 | | token_start_line = line; [INFO] [stderr] 288 | | token_start_column = column; [INFO] [stderr] 289 | | }, [INFO] [stderr] | |_______- help: try this: `if token_start_index.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parse.rs:319:32 [INFO] [stderr] | [INFO] [stderr] 319 | if bytes.iter().all(|symbol| { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 320 | | (symbol >= &b'a' && symbol <= &b'z') [INFO] [stderr] 321 | | || (symbol >= &b'A' && symbol <= &b'Z') [INFO] [stderr] 322 | | || (symbol >= &b'0' && symbol <= &b'9') [INFO] [stderr] 323 | | || symbol == &b'_' [INFO] [stderr] 324 | | }) { [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:320:6 [INFO] [stderr] | [INFO] [stderr] 320 | (symbol >= &b'a' && symbol <= &b'z') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'a'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:320:25 [INFO] [stderr] | [INFO] [stderr] 320 | (symbol >= &b'a' && symbol <= &b'z') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'z'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:321:11 [INFO] [stderr] | [INFO] [stderr] 321 | || (symbol >= &b'A' && symbol <= &b'Z') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'A'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:321:30 [INFO] [stderr] | [INFO] [stderr] 321 | || (symbol >= &b'A' && symbol <= &b'Z') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'Z'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:322:11 [INFO] [stderr] | [INFO] [stderr] 322 | || (symbol >= &b'0' && symbol <= &b'9') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:322:30 [INFO] [stderr] | [INFO] [stderr] 322 | || (symbol >= &b'0' && symbol <= &b'9') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parse.rs:345:10 [INFO] [stderr] | [INFO] [stderr] 345 | if &colon.token != &b":" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 345 | if colon.token != b":" { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parse.rs:365:10 [INFO] [stderr] | [INFO] [stderr] 365 | if &semicolon.token != &b";" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 365 | if semicolon.token != b";" { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serialize.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | fn hex_to_bytes(color: &Color) -> Vec { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/serialize.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | zip.write(&palette[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/serialize.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | zip.write(&wallpaper.bytes[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: item `tdesktop_theme::TdesktopTheme` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/tdesktop_theme.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / impl TdesktopTheme { [INFO] [stderr] 14 | | /// Creates a new, empty `TdesktopTheme`. [INFO] [stderr] 15 | | /// [INFO] [stderr] 16 | | /// # Examples [INFO] [stderr] ... | [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tdesktop_theme::TdesktopTheme` [INFO] [stderr] --> src/tdesktop_theme.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> TdesktopTheme { [INFO] [stderr] 27 | | TdesktopTheme { [INFO] [stderr] 28 | | wallpaper: None, [INFO] [stderr] 29 | | variables: IndexMap::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/tdesktop_theme.rs:670:12 [INFO] [stderr] | [INFO] [stderr] 670 | if let None = self.wallpaper { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 671 | | self.wallpaper = other.wallpaper; [INFO] [stderr] 672 | | } [INFO] [stderr] | |_____- help: try this: `if self.wallpaper.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tdesktop_theme`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:146:8 [INFO] [stderr] | [INFO] [stderr] 146 | if digit >= &b'0' && digit <= &b'9' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:146:26 [INFO] [stderr] | [INFO] [stderr] 146 | if digit >= &b'0' && digit <= &b'9' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | } else if digit >= &b'a' && digit <= &b'f' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'a'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:148:33 [INFO] [stderr] | [INFO] [stderr] 148 | } else if digit >= &b'a' && digit <= &b'f' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'f'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:150:15 [INFO] [stderr] | [INFO] [stderr] 150 | } else if digit >= &b'A' && digit <= &b'F' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'A'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | } else if digit >= &b'A' && digit <= &b'F' { [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'F'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parse.rs:279:28 [INFO] [stderr] | [INFO] [stderr] 279 | token: &contents[index..index + 1], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `index..=index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/parse.rs:285:19 [INFO] [stderr] | [INFO] [stderr] 285 | _ => if let None = token_start_index { [INFO] [stderr] | ____________- ^^^^ [INFO] [stderr] 286 | | token_start_index = Some(index); [INFO] [stderr] 287 | | token_start_line = line; [INFO] [stderr] 288 | | token_start_column = column; [INFO] [stderr] 289 | | }, [INFO] [stderr] | |_______- help: try this: `if token_start_index.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parse.rs:319:32 [INFO] [stderr] | [INFO] [stderr] 319 | if bytes.iter().all(|symbol| { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 320 | | (symbol >= &b'a' && symbol <= &b'z') [INFO] [stderr] 321 | | || (symbol >= &b'A' && symbol <= &b'Z') [INFO] [stderr] 322 | | || (symbol >= &b'0' && symbol <= &b'9') [INFO] [stderr] 323 | | || symbol == &b'_' [INFO] [stderr] 324 | | }) { [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:320:6 [INFO] [stderr] | [INFO] [stderr] 320 | (symbol >= &b'a' && symbol <= &b'z') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'a'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:320:25 [INFO] [stderr] | [INFO] [stderr] 320 | (symbol >= &b'a' && symbol <= &b'z') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'z'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:321:11 [INFO] [stderr] | [INFO] [stderr] 321 | || (symbol >= &b'A' && symbol <= &b'Z') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'A'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:321:30 [INFO] [stderr] | [INFO] [stderr] 321 | || (symbol >= &b'A' && symbol <= &b'Z') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'Z'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:322:11 [INFO] [stderr] | [INFO] [stderr] 322 | || (symbol >= &b'0' && symbol <= &b'9') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:322:30 [INFO] [stderr] | [INFO] [stderr] 322 | || (symbol >= &b'0' && symbol <= &b'9') [INFO] [stderr] | ^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b'9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parse.rs:345:10 [INFO] [stderr] | [INFO] [stderr] 345 | if &colon.token != &b":" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 345 | if colon.token != b":" { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parse.rs:365:10 [INFO] [stderr] | [INFO] [stderr] 365 | if &semicolon.token != &b";" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 365 | if semicolon.token != b";" { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serialize.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | fn hex_to_bytes(color: &Color) -> Vec { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/serialize.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | zip.write(&palette[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/serialize.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | zip.write(&wallpaper.bytes[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: item `tdesktop_theme::TdesktopTheme` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/tdesktop_theme.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / impl TdesktopTheme { [INFO] [stderr] 14 | | /// Creates a new, empty `TdesktopTheme`. [INFO] [stderr] 15 | | /// [INFO] [stderr] 16 | | /// # Examples [INFO] [stderr] ... | [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tdesktop_theme::TdesktopTheme` [INFO] [stderr] --> src/tdesktop_theme.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> TdesktopTheme { [INFO] [stderr] 27 | | TdesktopTheme { [INFO] [stderr] 28 | | wallpaper: None, [INFO] [stderr] 29 | | variables: IndexMap::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/tdesktop_theme.rs:670:12 [INFO] [stderr] | [INFO] [stderr] 670 | if let None = self.wallpaper { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 671 | | self.wallpaper = other.wallpaper; [INFO] [stderr] 672 | | } [INFO] [stderr] | |_____- help: try this: `if self.wallpaper.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tdesktop_theme`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e99729fcd6bd8c4c6741a239896571e3afbec16b2ff12c9ce418774aec20a01e"` [INFO] running `"docker" "rm" "-f" "e99729fcd6bd8c4c6741a239896571e3afbec16b2ff12c9ce418774aec20a01e"` [INFO] [stdout] e99729fcd6bd8c4c6741a239896571e3afbec16b2ff12c9ce418774aec20a01e