[INFO] crate td_rredis 0.1.2 is already in cache [INFO] extracting crate td_rredis 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/td_rredis/0.1.2 [INFO] extracting crate td_rredis 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/td_rredis/0.1.2 [INFO] validating manifest of td_rredis-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of td_rredis-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing td_rredis-0.1.2 [INFO] finished frobbing td_rredis-0.1.2 [INFO] frobbed toml for td_rredis-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/td_rredis/0.1.2/Cargo.toml [INFO] started frobbing td_rredis-0.1.2 [INFO] finished frobbing td_rredis-0.1.2 [INFO] frobbed toml for td_rredis-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/td_rredis/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting td_rredis-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/td_rredis/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4466e10d6beade468353446716a3ee686ea28deff15fe7bea79910083a712a03 [INFO] running `"docker" "start" "-a" "4466e10d6beade468353446716a3ee686ea28deff15fe7bea79910083a712a03"` [INFO] [stderr] Checking sha1 v0.1.1 [INFO] [stderr] Checking url v0.5.10 [INFO] [stderr] Checking td_rredis v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:369:20 [INFO] [stderr] | [INFO] [stderr] 369 | InfoDict { map: map } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:415:17 [INFO] [stderr] | [INFO] [stderr] 415 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:416:17 [INFO] [stderr] | [INFO] [stderr] 416 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:417:17 [INFO] [stderr] | [INFO] [stderr] 417 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | Parser { reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | batch: batch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `batch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | con: con, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `con` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/script.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:369:20 [INFO] [stderr] | [INFO] [stderr] 369 | InfoDict { map: map } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:415:17 [INFO] [stderr] | [INFO] [stderr] 415 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:416:17 [INFO] [stderr] | [INFO] [stderr] 416 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:417:17 [INFO] [stderr] | [INFO] [stderr] 417 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | Parser { reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | batch: batch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `batch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | con: con, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `con` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/script.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cluster.rs:95:18 [INFO] [stderr] | [INFO] [stderr] 95 | _ => return (), [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/cluster.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | _ => return (), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cluster.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cluster.rs:95:18 [INFO] [stderr] | [INFO] [stderr] 95 | _ => return (), [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/cluster.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | _ => return (), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cluster.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:105:26 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(_) => return fail!((ErrorKind::PatternError, "Could not read enough bytes")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/lib.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | if !($expr) { return $err_result; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/script.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | / ensure!(self.script.hash == hash, [INFO] [stderr] 174 | | fail!((ErrorKind::BusyLoadingError, "load hash error"))); [INFO] [stderr] | |_________________________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/lib.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | if !($expr) { return $err_result; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/script.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | / ensure!(self.script.hash == hash, [INFO] [stderr] 185 | | fail!((ErrorKind::BusyLoadingError, "load hash error"))); [INFO] [stderr] | |_________________________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:105:26 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(_) => return fail!((ErrorKind::PatternError, "Could not read enough bytes")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: item `types::InfoDict` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:353:1 [INFO] [stderr] | [INFO] [stderr] 353 | / impl InfoDict { [INFO] [stderr] 354 | | /// Creates a new info dictionary from a string in the response of [INFO] [stderr] 355 | | /// the INFO command. Each line is a key, value pair with the [INFO] [stderr] 356 | | /// key and value separated by a colon (`:`). Lines starting with a [INFO] [stderr] ... | [INFO] [stderr] 391 | | } [INFO] [stderr] 392 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types.rs:361:16 [INFO] [stderr] | [INFO] [stderr] 361 | if line.len() == 0 || line.starts_with("#") { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types.rs:361:52 [INFO] [stderr] | [INFO] [stderr] 361 | if line.len() == 0 || line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/lib.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | if !($expr) { return $err_result; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/script.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | / ensure!(self.script.hash == hash, [INFO] [stderr] 174 | | fail!((ErrorKind::BusyLoadingError, "load hash error"))); [INFO] [stderr] | |_________________________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/lib.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | if !($expr) { return $err_result; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/script.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | / ensure!(self.script.hash == hash, [INFO] [stderr] 185 | | fail!((ErrorKind::BusyLoadingError, "load hash error"))); [INFO] [stderr] | |_________________________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types.rs:626:13 [INFO] [stderr] | [INFO] [stderr] 626 | / match FromRedisValue::from_redis_value(item) { [INFO] [stderr] 627 | | Ok(val) => rv.push(val), [INFO] [stderr] 628 | | Err(_) => {} [INFO] [stderr] 629 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(val) = FromRedisValue::from_redis_value(item) { rv.push(val) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/types.rs:743:75 [INFO] [stderr] | [INFO] [stderr] 743 | impl FromRedisValue for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 743 | impl FromRedisValue for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 747 | let mut rv = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/types.rs:749:17 [INFO] [stderr] | [INFO] [stderr] 749 | / loop { [INFO] [stderr] 750 | | let k = unwrap_or!(iter.next(), break); [INFO] [stderr] 751 | | let v = unwrap_or!(iter.next(), break); [INFO] [stderr] 752 | | rv.insert(try!(from_redis_value(k)), try!(from_redis_value(v))); [INFO] [stderr] 753 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(x) = iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/types.rs:761:56 [INFO] [stderr] | [INFO] [stderr] 761 | impl FromRedisValue for HashSet { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 761 | impl FromRedisValue for HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 765 | let mut rv = HashSet::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types.rs:863:9 [INFO] [stderr] | [INFO] [stderr] 863 | / match *v { [INFO] [stderr] 864 | | Value::Nil => { [INFO] [stderr] 865 | | return Ok(None); [INFO] [stderr] 866 | | } [INFO] [stderr] 867 | | _ => {} [INFO] [stderr] 868 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 863 | if let Value::Nil = *v { [INFO] [stderr] 864 | return Ok(None); [INFO] [stderr] 865 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/connection.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | db: match url.serialize_path().unwrap_or("".to_string()).trim_matches('/') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/connection.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / match connection_info.passwd { [INFO] [stderr] 110 | | Some(ref passwd) => { [INFO] [stderr] 111 | | match cmd("AUTH").arg(&**passwd).query::(&mut rv) { [INFO] [stderr] 112 | | Ok(Value::Okay) => {} [INFO] [stderr] ... | [INFO] [stderr] 127 | | None => {} [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | if let Some(ref passwd) = connection_info.passwd { [INFO] [stderr] 110 | match cmd("AUTH").arg(&**passwd).query::(&mut rv) { [INFO] [stderr] 111 | Ok(Value::Okay) => {} [INFO] [stderr] 112 | Err(err) => { [INFO] [stderr] 113 | if err.kind() != ErrorKind::ResponseError || [INFO] [stderr] 114 | err.extension_error_detail() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `query` doesn't need a mutable reference [INFO] [stderr] --> src/connection.rs:111:61 [INFO] [stderr] | [INFO] [stderr] 111 | match cmd("AUTH").arg(&**passwd).query::(&mut rv) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `query` doesn't need a mutable reference [INFO] [stderr] --> src/connection.rs:131:68 [INFO] [stderr] | [INFO] [stderr] 131 | match cmd("SELECT").arg(connection_info.db).query::(&mut rv) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/connection.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn new(addr: &ConnectionInfo) -> RedisResult> { [INFO] [stderr] 176 | | let tcp = try!(TcpStream::connect((&*addr.host, addr.port))); [INFO] [stderr] 177 | | Ok(BufReader::new(tcp)) [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/connection.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | try!(w.write(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | let _: () = try!(cmd.query(&self.con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | let _: () = try!(cmd.query(&self.con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | let _: () = try!(cmd.query(&self.con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | let _: () = try!(cmd.query(&self.con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/connection.rs:460:25 [INFO] [stderr] | [INFO] [stderr] 460 | pub fn from_pattern(&self) -> bool { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:517:9 [INFO] [stderr] | [INFO] [stderr] 517 | let _: () = try!(cmd("WATCH").arg(keys).query(con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:527:17 [INFO] [stderr] | [INFO] [stderr] 527 | let _: () = try!(cmd("UNWATCH").query(con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | let ref mut buf = &mut rv[i..]; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let buf = &mut (&mut rv[i..]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cmd.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / match self.batch.pop() { [INFO] [stderr] 47 | | Some(v) => { [INFO] [stderr] 48 | | return Some(v); [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | None => {} [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | if let Some(v) = self.batch.pop() { [INFO] [stderr] 47 | return Some(v); [INFO] [stderr] 48 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | fn encode_command(args: &Vec, cursor: u64) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arg]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cmd::Cmd` [INFO] [stderr] --> src/cmd.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / pub fn new() -> Cmd { [INFO] [stderr] 132 | | Cmd { [INFO] [stderr] 133 | | args: vec![], [INFO] [stderr] 134 | | cursor: None, [INFO] [stderr] 135 | | is_ignored: false, [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cmd.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / let mut cursor = 0; [INFO] [stderr] 243 | | [INFO] [stderr] 244 | | if rv.looks_like_cursor() { [INFO] [stderr] 245 | | let (next, b): (u64, Vec) = try!(from_redis_value(&rv)); [INFO] [stderr] ... | [INFO] [stderr] 249 | | batch = try!(from_redis_value(&rv)); [INFO] [stderr] 250 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let cursor = if rv.looks_like_cursor() { ..; next } else { ..; 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/cmd.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | let _: () = self.query(con).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cmd::Pipeline` [INFO] [stderr] --> src/cmd.rs:315:5 [INFO] [stderr] | [INFO] [stderr] 315 | / pub fn new() -> Pipeline { [INFO] [stderr] 316 | | Pipeline { [INFO] [stderr] 317 | | commands: vec![], [INFO] [stderr] 318 | | transaction_mode: false, [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd.rs:436:31 [INFO] [stderr] | [INFO] [stderr] 436 | from_redis_value(&(if self.commands.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/cmd.rs:462:9 [INFO] [stderr] | [INFO] [stderr] 462 | let _: () = self.query(con).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd.rs:466:12 [INFO] [stderr] | [INFO] [stderr] 466 | if self.commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/cmd.rs:482:1 [INFO] [stderr] | [INFO] [stderr] 482 | / pub fn cmd<'a>(name: &'a str) -> Cmd { [INFO] [stderr] 483 | | let mut rv = Cmd::new(); [INFO] [stderr] 484 | | rv.arg(name); [INFO] [stderr] 485 | | rv [INFO] [stderr] 486 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `perform` which has no body [INFO] [stderr] --> src/commands.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] ... [INFO] [stderr] 123 | / implement_commands! { [INFO] [stderr] 124 | | // most common operations [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | /// Get the value of a key. If key is a vec this becomes an `MGET`. [INFO] [stderr] ... | [INFO] [stderr] 716 | | } [INFO] [stderr] 717 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/commands.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | fn $name<'a $(, $tyargs: $ty)*>( [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 123 | / implement_commands! { [INFO] [stderr] 124 | | // most common operations [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | /// Get the value of a key. If key is a vec this becomes an `MGET`. [INFO] [stderr] ... | [INFO] [stderr] 716 | | } [INFO] [stderr] 717 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/commands.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | fn $name<'a $(, $tyargs: $ty)*>( [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 123 | / implement_commands! { [INFO] [stderr] 124 | | // most common operations [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | /// Get the value of a key. If key is a vec this becomes an `MGET`. [INFO] [stderr] ... | [INFO] [stderr] 716 | | } [INFO] [stderr] 717 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/script.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if hash.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hash.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/script.rs:168:66 [INFO] [stderr] | [INFO] [stderr] 168 | if err.kind() == ErrorKind::NoScriptError && self.script.code.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.script.code.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return Err(::std::convert::From::from($expr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/script.rs:174:33 [INFO] [stderr] | [INFO] [stderr] 174 | fail!((ErrorKind::BusyLoadingError, "load hash error"))); [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/script.rs:175:73 [INFO] [stderr] | [INFO] [stderr] 175 | } else if err.kind() == ErrorKind::NoScriptError && self.script.path.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.script.path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return Err(::std::convert::From::from($expr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/script.rs:185:33 [INFO] [stderr] | [INFO] [stderr] 185 | fail!((ErrorKind::BusyLoadingError, "load hash error"))); [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: the loop variable `counter` is only used to index `bytes`. [INFO] [stderr] --> src/slot.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | for counter in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 43 | for in &bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(((crc >> 8) as u8) ^ bytes[counter])` [INFO] [stderr] --> src/slot.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let index = (((crc >> 8) as u8) ^ bytes[counter]) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cluster::Cluster` [INFO] [stderr] --> src/cluster.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Cluster { [INFO] [stderr] 16 | | Cluster { [INFO] [stderr] 17 | | addrs: HashMap::new(), [INFO] [stderr] 18 | | conns: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cluster.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if self.addrs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.addrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | if !self.conns.get(addr).unwrap().is_work() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster.rs:59:27 [INFO] [stderr] | [INFO] [stderr] 59 | return Ok(self.conns.get(addr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(self.conns.get(addr).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cluster.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | connection.passwd = self.auths.get(&addr).map(|e| e.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.auths.get(&addr).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/cluster.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | let addr = self.slots.get(&slot).map_or(None, |e| Some(e.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.slots.get(&slot).and_then(|e| Some(e.clone()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/cluster.rs:93:15 [INFO] [stderr] | [INFO] [stderr] 93 | match self.slots.get(&slot).map_or(None, |e| Some(e.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.slots.get(&slot).and_then(|e| Some(e.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `td_rredis`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `types::InfoDict` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types.rs:353:1 [INFO] [stderr] | [INFO] [stderr] 353 | / impl InfoDict { [INFO] [stderr] 354 | | /// Creates a new info dictionary from a string in the response of [INFO] [stderr] 355 | | /// the INFO command. Each line is a key, value pair with the [INFO] [stderr] 356 | | /// key and value separated by a colon (`:`). Lines starting with a [INFO] [stderr] ... | [INFO] [stderr] 391 | | } [INFO] [stderr] 392 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types.rs:361:16 [INFO] [stderr] | [INFO] [stderr] 361 | if line.len() == 0 || line.starts_with("#") { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types.rs:361:52 [INFO] [stderr] | [INFO] [stderr] 361 | if line.len() == 0 || line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types.rs:626:13 [INFO] [stderr] | [INFO] [stderr] 626 | / match FromRedisValue::from_redis_value(item) { [INFO] [stderr] 627 | | Ok(val) => rv.push(val), [INFO] [stderr] 628 | | Err(_) => {} [INFO] [stderr] 629 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(val) = FromRedisValue::from_redis_value(item) { rv.push(val) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/types.rs:743:75 [INFO] [stderr] | [INFO] [stderr] 743 | impl FromRedisValue for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 743 | impl FromRedisValue for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 747 | let mut rv = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/types.rs:749:17 [INFO] [stderr] | [INFO] [stderr] 749 | / loop { [INFO] [stderr] 750 | | let k = unwrap_or!(iter.next(), break); [INFO] [stderr] 751 | | let v = unwrap_or!(iter.next(), break); [INFO] [stderr] 752 | | rv.insert(try!(from_redis_value(k)), try!(from_redis_value(v))); [INFO] [stderr] 753 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(x) = iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/types.rs:761:56 [INFO] [stderr] | [INFO] [stderr] 761 | impl FromRedisValue for HashSet { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 761 | impl FromRedisValue for HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 765 | let mut rv = HashSet::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types.rs:863:9 [INFO] [stderr] | [INFO] [stderr] 863 | / match *v { [INFO] [stderr] 864 | | Value::Nil => { [INFO] [stderr] 865 | | return Ok(None); [INFO] [stderr] 866 | | } [INFO] [stderr] 867 | | _ => {} [INFO] [stderr] 868 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 863 | if let Value::Nil = *v { [INFO] [stderr] 864 | return Ok(None); [INFO] [stderr] 865 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/connection.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | db: match url.serialize_path().unwrap_or("".to_string()).trim_matches('/') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/connection.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / match connection_info.passwd { [INFO] [stderr] 110 | | Some(ref passwd) => { [INFO] [stderr] 111 | | match cmd("AUTH").arg(&**passwd).query::(&mut rv) { [INFO] [stderr] 112 | | Ok(Value::Okay) => {} [INFO] [stderr] ... | [INFO] [stderr] 127 | | None => {} [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | if let Some(ref passwd) = connection_info.passwd { [INFO] [stderr] 110 | match cmd("AUTH").arg(&**passwd).query::(&mut rv) { [INFO] [stderr] 111 | Ok(Value::Okay) => {} [INFO] [stderr] 112 | Err(err) => { [INFO] [stderr] 113 | if err.kind() != ErrorKind::ResponseError || [INFO] [stderr] 114 | err.extension_error_detail() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `query` doesn't need a mutable reference [INFO] [stderr] --> src/connection.rs:111:61 [INFO] [stderr] | [INFO] [stderr] 111 | match cmd("AUTH").arg(&**passwd).query::(&mut rv) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `query` doesn't need a mutable reference [INFO] [stderr] --> src/connection.rs:131:68 [INFO] [stderr] | [INFO] [stderr] 131 | match cmd("SELECT").arg(connection_info.db).query::(&mut rv) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/connection.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn new(addr: &ConnectionInfo) -> RedisResult> { [INFO] [stderr] 176 | | let tcp = try!(TcpStream::connect((&*addr.host, addr.port))); [INFO] [stderr] 177 | | Ok(BufReader::new(tcp)) [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/connection.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | try!(w.write(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | let _: () = try!(cmd.query(&self.con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | let _: () = try!(cmd.query(&self.con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | let _: () = try!(cmd.query(&self.con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | let _: () = try!(cmd.query(&self.con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/connection.rs:460:25 [INFO] [stderr] | [INFO] [stderr] 460 | pub fn from_pattern(&self) -> bool { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:517:9 [INFO] [stderr] | [INFO] [stderr] 517 | let _: () = try!(cmd("WATCH").arg(keys).query(con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/connection.rs:527:17 [INFO] [stderr] | [INFO] [stderr] 527 | let _: () = try!(cmd("UNWATCH").query(con)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | let ref mut buf = &mut rv[i..]; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let buf = &mut (&mut rv[i..]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cmd.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / match self.batch.pop() { [INFO] [stderr] 47 | | Some(v) => { [INFO] [stderr] 48 | | return Some(v); [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | None => {} [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | if let Some(v) = self.batch.pop() { [INFO] [stderr] 47 | return Some(v); [INFO] [stderr] 48 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | fn encode_command(args: &Vec, cursor: u64) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arg]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cmd::Cmd` [INFO] [stderr] --> src/cmd.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / pub fn new() -> Cmd { [INFO] [stderr] 132 | | Cmd { [INFO] [stderr] 133 | | args: vec![], [INFO] [stderr] 134 | | cursor: None, [INFO] [stderr] 135 | | is_ignored: false, [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cmd.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / let mut cursor = 0; [INFO] [stderr] 243 | | [INFO] [stderr] 244 | | if rv.looks_like_cursor() { [INFO] [stderr] 245 | | let (next, b): (u64, Vec) = try!(from_redis_value(&rv)); [INFO] [stderr] ... | [INFO] [stderr] 249 | | batch = try!(from_redis_value(&rv)); [INFO] [stderr] 250 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let cursor = if rv.looks_like_cursor() { ..; next } else { ..; 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/cmd.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | let _: () = self.query(con).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cmd::Pipeline` [INFO] [stderr] --> src/cmd.rs:315:5 [INFO] [stderr] | [INFO] [stderr] 315 | / pub fn new() -> Pipeline { [INFO] [stderr] 316 | | Pipeline { [INFO] [stderr] 317 | | commands: vec![], [INFO] [stderr] 318 | | transaction_mode: false, [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd.rs:436:31 [INFO] [stderr] | [INFO] [stderr] 436 | from_redis_value(&(if self.commands.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/cmd.rs:462:9 [INFO] [stderr] | [INFO] [stderr] 462 | let _: () = self.query(con).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd.rs:466:12 [INFO] [stderr] | [INFO] [stderr] 466 | if self.commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/cmd.rs:482:1 [INFO] [stderr] | [INFO] [stderr] 482 | / pub fn cmd<'a>(name: &'a str) -> Cmd { [INFO] [stderr] 483 | | let mut rv = Cmd::new(); [INFO] [stderr] 484 | | rv.arg(name); [INFO] [stderr] 485 | | rv [INFO] [stderr] 486 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `perform` which has no body [INFO] [stderr] --> src/commands.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] ... [INFO] [stderr] 123 | / implement_commands! { [INFO] [stderr] 124 | | // most common operations [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | /// Get the value of a key. If key is a vec this becomes an `MGET`. [INFO] [stderr] ... | [INFO] [stderr] 716 | | } [INFO] [stderr] 717 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/commands.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | fn $name<'a $(, $tyargs: $ty)*>( [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 123 | / implement_commands! { [INFO] [stderr] 124 | | // most common operations [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | /// Get the value of a key. If key is a vec this becomes an `MGET`. [INFO] [stderr] ... | [INFO] [stderr] 716 | | } [INFO] [stderr] 717 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/commands.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | fn $name<'a $(, $tyargs: $ty)*>( [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 123 | / implement_commands! { [INFO] [stderr] 124 | | // most common operations [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | /// Get the value of a key. If key is a vec this becomes an `MGET`. [INFO] [stderr] ... | [INFO] [stderr] 716 | | } [INFO] [stderr] 717 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/script.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if hash.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hash.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/script.rs:168:66 [INFO] [stderr] | [INFO] [stderr] 168 | if err.kind() == ErrorKind::NoScriptError && self.script.code.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.script.code.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return Err(::std::convert::From::from($expr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/script.rs:174:33 [INFO] [stderr] | [INFO] [stderr] 174 | fail!((ErrorKind::BusyLoadingError, "load hash error"))); [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/script.rs:175:73 [INFO] [stderr] | [INFO] [stderr] 175 | } else if err.kind() == ErrorKind::NoScriptError && self.script.path.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.script.path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return Err(::std::convert::From::from($expr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/script.rs:185:33 [INFO] [stderr] | [INFO] [stderr] 185 | fail!((ErrorKind::BusyLoadingError, "load hash error"))); [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: the loop variable `counter` is only used to index `bytes`. [INFO] [stderr] --> src/slot.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | for counter in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 43 | for in &bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(((crc >> 8) as u8) ^ bytes[counter])` [INFO] [stderr] --> src/slot.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let index = (((crc >> 8) as u8) ^ bytes[counter]) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cluster::Cluster` [INFO] [stderr] --> src/cluster.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Cluster { [INFO] [stderr] 16 | | Cluster { [INFO] [stderr] 17 | | addrs: HashMap::new(), [INFO] [stderr] 18 | | conns: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cluster.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if self.addrs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.addrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | if !self.conns.get(addr).unwrap().is_work() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster.rs:59:27 [INFO] [stderr] | [INFO] [stderr] 59 | return Ok(self.conns.get(addr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(self.conns.get(addr).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conns[addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cluster.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | connection.passwd = self.auths.get(&addr).map(|e| e.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.auths.get(&addr).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/cluster.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | let addr = self.slots.get(&slot).map_or(None, |e| Some(e.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.slots.get(&slot).and_then(|e| Some(e.clone()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/cluster.rs:93:15 [INFO] [stderr] | [INFO] [stderr] 93 | match self.slots.get(&slot).map_or(None, |e| Some(e.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.slots.get(&slot).and_then(|e| Some(e.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `td_rredis`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4466e10d6beade468353446716a3ee686ea28deff15fe7bea79910083a712a03"` [INFO] running `"docker" "rm" "-f" "4466e10d6beade468353446716a3ee686ea28deff15fe7bea79910083a712a03"` [INFO] [stdout] 4466e10d6beade468353446716a3ee686ea28deff15fe7bea79910083a712a03