[INFO] crate tc_core 0.2.0 is already in cache [INFO] extracting crate tc_core 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/tc_core/0.2.0 [INFO] extracting crate tc_core 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tc_core/0.2.0 [INFO] validating manifest of tc_core-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tc_core-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tc_core-0.2.0 [INFO] finished frobbing tc_core-0.2.0 [INFO] frobbed toml for tc_core-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tc_core/0.2.0/Cargo.toml [INFO] started frobbing tc_core-0.2.0 [INFO] finished frobbing tc_core-0.2.0 [INFO] frobbed toml for tc_core-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tc_core/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tc_core-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tc_core/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 434df40a563c666f916909305c6b9ea14240302c10ff7927ccba977c8fee42d4 [INFO] running `"docker" "start" "-a" "434df40a563c666f916909305c6b9ea14240302c10ff7927ccba977c8fee42d4"` [INFO] [stderr] Compiling debug_stub_derive v0.3.0 [INFO] [stderr] Checking tc_core v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/container.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match keep_container { [INFO] [stderr] 146 | | true => self.stop(), [INFO] [stderr] 147 | | false => self.rm(), [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if keep_container { self.stop() } else { self.rm() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/docker.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | self.mapping.get(&internal_port).map(|p| p.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.mapping.get(&internal_port).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/docker.rs:35:50 [INFO] [stderr] | [INFO] [stderr] 35 | self.mapping.get(&internal_port).map(|p| p.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/wait_for_message.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | let mut iter = logs.lines().into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `logs.lines()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/wait_for_message.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | while let Some(line) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for line in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/container.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match keep_container { [INFO] [stderr] 146 | | true => self.stop(), [INFO] [stderr] 147 | | false => self.rm(), [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if keep_container { self.stop() } else { self.rm() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/docker.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | self.mapping.get(&internal_port).map(|p| p.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.mapping.get(&internal_port).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/docker.rs:35:50 [INFO] [stderr] | [INFO] [stderr] 35 | self.mapping.get(&internal_port).map(|p| p.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/wait_for_message.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | let mut iter = logs.lines().into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `logs.lines()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/wait_for_message.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | while let Some(line) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for line in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/wait_for_message.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let logs = r" [INFO] [stderr] | ____________________^ [INFO] [stderr] 63 | | Message one [INFO] [stderr] 64 | | Message two [INFO] [stderr] 65 | | Message three [INFO] [stderr] 66 | | ".as_bytes(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 62 | let logs = br" [INFO] [stderr] 63 | Message one [INFO] [stderr] 64 | Message two [INFO] [stderr] 65 | Message three [INFO] [stderr] 66 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.70s [INFO] running `"docker" "inspect" "434df40a563c666f916909305c6b9ea14240302c10ff7927ccba977c8fee42d4"` [INFO] running `"docker" "rm" "-f" "434df40a563c666f916909305c6b9ea14240302c10ff7927ccba977c8fee42d4"` [INFO] [stdout] 434df40a563c666f916909305c6b9ea14240302c10ff7927ccba977c8fee42d4